From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40B09C4332F for ; Fri, 9 Dec 2022 08:52:31 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p3Z6V-0000Rp-9b; Fri, 09 Dec 2022 03:51:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3Z6S-0000Rc-Ex for qemu-devel@nongnu.org; Fri, 09 Dec 2022 03:51:32 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3Z6Q-0006V6-KB for qemu-devel@nongnu.org; Fri, 09 Dec 2022 03:51:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670575889; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qAdDQZa/eE+RINGIRx7RCHSoVQqMguB8QyVweFfS02o=; b=NpDWWyDkORb6b15jDGGqDX2hUuPmGkwZnhEgsBx1+UnqNrri4ARdkJHFbSv3tr2q75vW0c 48FneLfldII+M/ip/JMIEHvNK24wV65ydqFtsxw0HoFjms/yINPzVw6ryIFwwJJx/s9JVX UpAybvlNf/xZJyUA74I/w4ZZaJwm+0c= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-157-sUvX1HjtP2-NbffI4cfthw-1; Fri, 09 Dec 2022 03:51:25 -0500 X-MC-Unique: sUvX1HjtP2-NbffI4cfthw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F01938032FB; Fri, 9 Dec 2022 08:51:24 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.195.144]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B8F1DC15BA8; Fri, 9 Dec 2022 08:51:24 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id A8FF121E6921; Fri, 9 Dec 2022 09:51:21 +0100 (CET) From: Markus Armbruster To: Richard Henderson Cc: qemu-devel@nongnu.org, Paolo Bonzini , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , "Daniel P. Berrange" , Thomas Huth , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: Target-dependent include path, why? References: <87edt9gnyz.fsf@pond.sub.org> Date: Fri, 09 Dec 2022 09:51:21 +0100 In-Reply-To: (Richard Henderson's message of "Thu, 8 Dec 2022 23:24:01 -0600") Message-ID: <87v8mlez92.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Richard Henderson writes: > On 12/8/22 23:12, Markus Armbruster wrote: >> I stumbled over this: >> ../include/ui/qemu-pixman.h:12:10: fatal error: pixman.h: No such file or directory >> 12 | #include >> | ^~~~~~~~~~ >> Works when included into target-dependent code. >> Running make -V=1 shows we're passing a number of -I only when compiling >> target-dependent code, i.e. together with -DNEED_CPU_H: >> -I/usr/include/pixman-1 -I/usr/include/capstone -I/usr/include/spice-server -I/usr/include/spice-1 >> -I/usr/include/cacard -I/usr/include/nss3 -I/usr/include/nspr4 -I/usr/include/PCSC >> -isystem../linux-headers -isystemlinux-headers >> Why? > > Because of where [pixman] is added as a dependency in meson.build. Is it added where it is for a reason, or is it accidental? > If you want to use it somewhere new, you've got to move the dependency.