From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A9FBC433FE for ; Tue, 22 Nov 2022 02:36:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A252910E360; Tue, 22 Nov 2022 02:36:04 +0000 (UTC) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 89F4810E362 for ; Tue, 22 Nov 2022 02:36:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669084562; x=1700620562; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=YYBiUT2DQ6IGZBv9TCyKPz6QLEE2eqB0Qkf0bRtjqoQ=; b=N0PiuDyoSbfsANGUPrmXN9nZ7Ny/BCSh+pU0Cf5hhaMYnnTNqKsfPYnV 2VHvW/vLSpIwxYIfrftYulxqSc7BbI65caWMUWoaWK96Xo/WfkYKWwXaJ SQ8qrKPi/hqX/3JkDs4/XdeD591lUBAnxfQlpiTc8vCSnbQnHJLPfjAoH su/g1fZhECQgDYGvqxmOWUkCBZgSk/jKutsR3CbjY6Yx90j5OIQoIBHeR 2WMSn9w2rvxwJRBACgRyna34K3YBbDoc8QniB2px8ZtRKlNMEmuE81s0G My+zfhk4u+aaF/ORBFcKrvPj4bl8LSaOYjLugV7IiNi41JaQDC2apRMVn g==; X-IronPort-AV: E=McAfee;i="6500,9779,10538"; a="375856333" X-IronPort-AV: E=Sophos;i="5.96,182,1665471600"; d="scan'208";a="375856333" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2022 18:36:02 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10538"; a="591987169" X-IronPort-AV: E=Sophos;i="5.96,182,1665471600"; d="scan'208";a="591987169" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.81.52]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2022 18:36:01 -0800 Date: Mon, 21 Nov 2022 18:35:31 -0800 Message-ID: <87v8n767ik.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Riana Tauro In-Reply-To: <20221121072946.1013463-3-riana.tauro@intel.com> References: <20221121072946.1013463-1-riana.tauro@intel.com> <20221121072946.1013463-3-riana.tauro@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH v3 2/3] drm/i915/hwmon: Add helper function to obtain energy values X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Sun, 20 Nov 2022 23:29:45 -0800, Riana Tauro wrote: > > diff --git a/drivers/gpu/drm/i915/i915_hwmon.h b/drivers/gpu/drm/i915/i915_hwmon.h > index 7ca9cf2c34c9..a6c8efeb868d 100644 > --- a/drivers/gpu/drm/i915/i915_hwmon.h > +++ b/drivers/gpu/drm/i915/i915_hwmon.h > @@ -12,6 +12,7 @@ struct drm_i915_private; > #if IS_REACHABLE(CONFIG_HWMON) > void i915_hwmon_register(struct drm_i915_private *i915); > void i915_hwmon_unregister(struct drm_i915_private *i915); > +int i915_hwmon_get_energy(struct drm_i915_private *i915, long *energy); > #else > static inline void i915_hwmon_register(struct drm_i915_private *i915) { }; > static inline void i915_hwmon_unregister(struct drm_i915_private *i915) { }; What about the #else case?