From: Kalle Valo <kvalo@kernel.org>
To: Arend van Spriel <aspriel@gmail.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
arend.vanspriel@broadcom.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wifi: cfg80211: fix memory leak in query_regdb_file()
Date: Mon, 24 Oct 2022 12:49:50 +0300 [thread overview]
Message-ID: <87v8o9zh35.fsf@kernel.org> (raw)
In-Reply-To: <CAJ65rDzroYUFnPuzH54dFB1fAYPynDrTZYy-fF72E=Y_bFER-g@mail.gmail.com> (Arend van Spriel's message of "Wed, 19 Oct 2022 04:44:18 -0700")
Arend van Spriel <aspriel@gmail.com> writes:
> In the function query_regdb_file() the alpha2 parameter is duplicated
> using kmemdup() and subsequently freed in regdb_fw_cb(). However,
> request_firmware_nowait() can fail without calling regdb_fw_cb() and
> thus leak memory.
>
> Fixes: 007f6c5e6eb4 ("cfg80211: support loading regulatory database as
> firmware file")
The fixes tag should be in one line.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-10-24 9:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 11:44 [PATCH] wifi: cfg80211: fix memory leak in query_regdb_file() Arend van Spriel
2022-10-24 9:49 ` Kalle Valo [this message]
2022-10-25 8:54 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8o9zh35.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=arend.vanspriel@broadcom.com \
--cc=aspriel@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.