From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3F78CCA487 for ; Thu, 21 Jul 2022 16:12:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qc7Cvbk8qrL7v5v9IGyPQOjwmiANdjiIMKg8lEL2++M=; b=d8nsFsgCaLm9xi B3FNnUOH3QTCHa0vN5QocwfhlEmqJvYmRQBHjRMOq9Tgqxi5tXEcc/zienb5U1Qlk9qpyQinSRlbK H3SW4UMxm8CaNi9ANoXAZBgMMyo8FckNy0uUcuEUhjryDFPLG2j9EWlV/Wa7bYxPBZBqt4tGqZ029 qF3RTGf0yk6HqWTQewr/IwK7WCGJhUkuyyr6YvWkzvlmT03LXHfA/GpFI3YFO4iTcF05TADyGaHyE dOEE7hRErryY2WgHy0ChAhcCY+jRu7zpL+mLccO5TRtPmLvltuIAGqYNN9Pqv+jKytfSYQb6e3p6H Z8U+KL1r4gwHuWewLivg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEYlS-009fCF-3X; Thu, 21 Jul 2022 16:11:02 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEYlI-009f4w-4w for linux-arm-kernel@lists.infradead.org; Thu, 21 Jul 2022 16:10:53 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BC524B8259F; Thu, 21 Jul 2022 16:10:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D9CDC3411E; Thu, 21 Jul 2022 16:10:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658419849; bh=V6ueizkBJsXR+EgG8vJ7ItqsOXrv15q7xeZdTH2eiT4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dF7K2zWC8CKclSOhiCVBVCe29O/OB0/rxfXrw8Wmmz0/AloMpvKDNx8IJhrE0gGDg 10weoBtXnLPLHIfDqvaP+nhpYbA2l8jTD78dPvZwh5mT6lfTQES80WHLP4Uq6lchPa frKp/ki/cubStPgO8WO+0fmfFYd7SZgeOwUdbBPPA69GR6vbIRf5Fn+x0mVGCGc0Bo PqNuAomOobxsow+BiXIwsKCFYRxcZVF4nVCMdFdO9pcxThmkpSz+2t9eisya5DJ8gU Lxhb4laNv8f/ryBeNakwe/RRjY1xsTSMDZIK58arT2yhwCg3RDRD8ZPZ+QTJ7VDQEa 1Mia0hin8asvg== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oEYlC-0098JK-TT; Thu, 21 Jul 2022 17:10:47 +0100 Date: Thu, 21 Jul 2022 17:10:46 +0100 Message-ID: <87v8rqxx89.wl-maz@kernel.org> From: Marc Zyngier To: Catalin Marinas Cc: linux-arm-kernel@lists.infradead.org, Will Deacon , Mark Rutland , pcc@google.com, Ard Biesheuvel , kernel-team@android.com Subject: Re: [PATCH] arm64: Use mov_q to load KPTI_NG_PTE_FLAGS/SWAPPER_R*_MMUFLAGS In-Reply-To: References: <20220721124244.903567-1-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, will@kernel.org, mark.rutland@arm.com, pcc@google.com, ardb@kernel.org, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220721_091052_361056_1C0A0E13 X-CRM114-Status: GOOD ( 21.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 21 Jul 2022 16:21:55 +0100, Catalin Marinas wrote: > > On Thu, Jul 21, 2022 at 01:42:44PM +0100, Marc Zyngier wrote: > > With f7b4c3b82e7d ("arm64: set UXN on swapper page tables"), > > the kernel fails to build: > > > > arch/arm64/kernel/head.S: Assembler messages: > > arch/arm64/kernel/head.S:334: Error: immediate cannot be moved by a single instruction > > arch/arm64/kernel/head.S:343: Error: immediate cannot be moved by a single instruction > > arch/arm64/kernel/head.S:354: Error: immediate cannot be moved by a single instruction > > arch/arm64/kernel/head.S:379: Error: immediate cannot be moved by a single instruction > > > > as the constants that inherit SWAPPER_P*_FLAGS cannot be loaded > > using a single 'mov' instruction. Move over to mov_q to fix this. > > > > Signed-off-by: Marc Zyngier > > Thanks for the fix Marc, this only applies to -next. We could either > revert Peter's patch [1] in -next but keep it for 5.19 or simply drop it > from for-next/fixes and send it to stable post 5.19. I'm more inclined > to do the latter. Agreed, this seems like a sensible decision. This is unlikely to affect a large user base at this stage anyway. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel