Re: [PATCH V10 14/22] LoongArch: Add signal handling support

["Eric W. Biederman" <ebiederm@xmission.com>]

Huacai Chen <chenhuacai@gmail.com> writes:

> Hi, Eric,
>
> On Mon, May 16, 2022 at 10:07 PM Eric W. Biederman
> <ebiederm@xmission.com> wrote:
>>
>> I can understand exporting these values but the names aren't very
>> well namespaced at all.  Which means they could accidentially
>> conflict with things.
>>
>> It would probably be better to do:
>> SC_USED_FP
>> SC_ADDRERR_RD
>> SC_ADDRERR_WR
> SC_ prefix is good, but ADRERR_RD/ADRERR_WR is used together with
> SIGSEGV/SIGBUS, so I want to keep the same as BUS_ADRERR (a single D)
> if possible.

Fair enough about the single D.  Please add the prefix in the next
version. Especially for kabi symbols in a namespace is a very good idea.


>> Given that neither lsx_context nor lasx_context are used in the kernel
>> code yet I would very much prefer that their inclusion wait until there
>> is actual code that needs them.
>>
>> If nothing else that will put the definitions in context so people can
>> more easily see the big picture and understand how the pieces fit.
> OK, I will remove lsx_context/lasx_context in the next version.

Thanks,
Eric