Re: + timekeeping-use-time_is_before_jiffies-instead-of-open-coding-it.patch added to -mm tree

[Thomas Gleixner <tglx@linutronix.de>]

On Fri, Apr 22 2022 at 13:37, Andrew Morton wrote:
> From: Wang Qing <wangqing@vivo.com>
> Subject: timekeeping: use time_is_before_jiffies() instead of open coding it
>
> Use the helper function time_is_{before,after}_jiffies() to improve code
> readability.
>
> Link: https://lkml.kernel.org/r/1650621172-66967-10-git-send-email-wangqing@vivo.com
> Signed-off-by: Wang Qing <wangqing@vivo.com>
> Cc: John Stultz <john.stultz@linaro.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
>  kernel/time/timekeeping.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- a/kernel/time/timekeeping.c~timekeeping-use-time_is_before_jiffies-instead-of-open-coding-it
> +++ a/kernel/time/timekeeping.c
> @@ -216,7 +216,7 @@ static void timekeeping_check_update(str
>  	}
>  
>  	if (tk->underflow_seen) {
> -		if (jiffies - tk->last_warning > WARNING_FREQ) {
> +		if (time_is_before_jiffies(tk->last_warning + WARNING_FREQ)) {

I have a hard time to see how this improves anything. The least thing it
improves is readability.

Yeah, I know some script told so....

Thanks,

        tglx