From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E0B0C433F5 for ; Tue, 29 Mar 2022 23:09:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ADA8710E3E1; Tue, 29 Mar 2022 23:09:24 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id AFCF289E65 for ; Tue, 29 Mar 2022 23:09:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648595363; x=1680131363; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=6EvBlWsx7zPtySi+uRrkUM6+7RrT6BRpK4AvQ0ESr0c=; b=E60xKOpgyxu7rlfdwRcduIZKSQujzbF0oQWwy9sXH4lz2i21bsbGH8yG gGjTUN5q/WJITxxm/wllMKqAHkgndoEhyDEJLiw98TQcMAw75SBvqDHbT ZOuwE9HNwz1g2meJ1LHT5nCjsrzrotUr5WYP/DqxOfILIQ1W/tCb7K3A7 06r4LB371XlJnk5x1OY4lxOgtzOgLKbs+j0V90dwevzTCvIKjW2+dFw2Q bQRHSdm26ndOBkzd/eEfQrYcNT5oc8kwbceghY30j5geehQsbQwmL8unR gDyFNfN6kHrZi6Km8bEoFRDkDI8FCtTVFr8hIdtfDkaW5lWpqOtW/P/lJ w==; X-IronPort-AV: E=McAfee;i="6200,9189,10301"; a="256975075" X-IronPort-AV: E=Sophos;i="5.90,220,1643702400"; d="scan'208";a="256975075" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2022 16:09:00 -0700 X-IronPort-AV: E=Sophos;i="5.90,220,1643702400"; d="scan'208";a="618314378" Received: from adixit-mobl1.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.199.225]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2022 16:09:00 -0700 Date: Tue, 29 Mar 2022 16:09:00 -0700 Message-ID: <87v8vw8igj.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Anshuman Gupta In-Reply-To: <20220328102227.14545-1-anshuman.gupta@intel.com> References: <20220328102227.14545-1-anshuman.gupta@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH] drm/i915/debugfs: Dump i915 children runtime status X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, Chris Wilson , rodrigo.vivi@intel.com Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 28 Mar 2022 03:22:27 -0700, Anshuman Gupta wrote: > > +#ifdef CONFIG_PM > +static int i915_runtime_dump_child_status(struct device *dev, void *data) > +{ > + struct seq_file *m = data; > + const char *rpm_status; > + > + /* Early return if runtime_pm is disabled */ > + if (dev->power.disable_depth) > + return 0; > + > + switch (dev->power.runtime_status) { > + case RPM_SUSPENDED: > + rpm_status = "suspended"; > + break; > + case RPM_SUSPENDING: > + rpm_status = "suspending"; > + break; > + case RPM_RESUMING: > + rpm_status = "resuming"; > + break; > + case RPM_ACTIVE: > + rpm_status = "active"; > + break; > + default: > + rpm_status = "unknown"; > + } > + > + seq_printf(m, "\t%s %s: Runtime status: %s\n", dev_driver_string(dev), > + dev_name(dev), rpm_status); > + > + return 0; > +} > +#endif Maybe a nit, but perhaps defining a const array is better than having a switch statement? Similar to what is done in rtpm_status_str(). The function itself is very similar to rtpm_status_str() so can probably benefit from that similarity. Can perhaps even be nearly identical to rtpm_status_str() (since that is static in the genpd (generic power domain) code). See also 2bd5306a8764 ("PM / Domains: add debugfs listing of struct generic_pm_domain-s"), though I am not sure if genpd's are applicable in our case and certainly look way out of scope for now. Thanks. > + > static int i915_runtime_pm_status(struct seq_file *m, void *unused) > { > struct drm_i915_private *dev_priv = node_to_i915(m->private); > @@ -500,6 +534,10 @@ static int i915_runtime_pm_status(struct seq_file *m, void *unused) > #ifdef CONFIG_PM > seq_printf(m, "Usage count: %d\n", > atomic_read(&dev_priv->drm.dev->power.usage_count)); > + seq_printf(m, "Runtime active children: %d\n", > + atomic_read(&dev_priv->drm.dev->power.child_count)); > + device_for_each_child(&pdev->dev, m, i915_runtime_dump_child_status); > + > #else > seq_printf(m, "Device Power Management (CONFIG_PM) disabled\n"); > #endif > -- > 2.26.2 >