From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D10DC433FE for ; Thu, 17 Mar 2022 10:17:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 90ADA49F07; Thu, 17 Mar 2022 06:17:23 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id E3qtQpyGSzaX; Thu, 17 Mar 2022 06:17:22 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 43A1649F1C; Thu, 17 Mar 2022 06:17:22 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id B5AB849F07 for ; Thu, 17 Mar 2022 06:17:21 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bv7uGVc8SqkZ for ; Thu, 17 Mar 2022 06:17:20 -0400 (EDT) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 244A949EE4 for ; Thu, 17 Mar 2022 06:17:20 -0400 (EDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6CAE9617BB; Thu, 17 Mar 2022 10:17:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D19A3C340E9; Thu, 17 Mar 2022 10:17:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647512238; bh=Ac3+Zu4JJhOiqtXO0r903zb8S377HU8RCpuDNXxEp2w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LIxewhOO7mTDGWxC+uGpYafMzpVkySVAs6tXhhapSeaXVim+9LNI7555bLoYnApeN n/b2xuUZpQXwKY6McT6P4ScoLs/JLLx3pwXXq7M134j0HTVMzwXA2/Du06nIK4tVic f1KAqb2NfmPLZLGIGXuTEkdeUspaVpScyjosUHPdXBvG47ifksIqpkLepnizo6vvTp aPV/DWF4VtB7JBQlew+Nw8j21TwmRnn7jq+5cAIMPabcKFrW86OpzB2Vu9/l1H8hu4 gWla4KDA67C4/j+yzLIlGunHoH6Q8zwat3WwZ0BQSDuWm/u4tu7I2OGui8WaD049xG +fHeBdE3Df2/g== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nUnC0-00F92j-GX; Thu, 17 Mar 2022 10:17:16 +0000 Date: Thu, 17 Mar 2022 10:17:16 +0000 Message-ID: <87v8wcyjbn.wl-maz@kernel.org> From: Marc Zyngier To: Jingyi Wang Subject: Re: Report an error on GICv4.1 vcpu de-schedule In-Reply-To: <4aae10ba-b39a-5f84-754b-69c2eb0a2c03@huawei.com> References: <4aae10ba-b39a-5f84-754b-69c2eb0a2c03@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: wangjingyi11@huawei.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, wanghaibin.wang@huawei.com, yuzenghui@huawei.com, Martin.Weidmann@arm.com, tangnianyao@huawei.com, chengjian8@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: kvm@vger.kernel.org, chengjian8@huawei.com, Martin.Weidmann@arm.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu SGkgSmluZ3lpLAoKT24gVGh1LCAxNyBNYXIgMjAyMiAwNzoyNzo0NSArMDAwMCwKSmluZ3lpIFdh bmcgPHdhbmdqaW5neWkxMUBodWF3ZWkuY29tPiB3cm90ZToKPiAKPiBIaSBNYXJj77yMCj4gCj4g VGhlIHBhdGNoICJLVk06IGFybTY0OiBEZWxheSB0aGUgcG9sbGluZyBvZiB0aGUgR0lDUl9WUEVO REJBU0VSLkRpcnR5Cj4gYml0Iig1N2UzY2ViZDAyMmZiYzAzNWRjZjE5MGFjNzg5ZmQyZmZjNzQ3 ZjViKSByZW1vdmUgdGhlIHBvbGxpbmcgb2YKPiBHSUNSX1ZQRU5EQkFTRVIuRGlydHkgYml0IGlu IHZjcHVfbG9hZCgpICwgd2hpbGUgY2hlY2sgdGhlIFZQVCBwYXJzaW5nCj4gcmVhZHkgaW4ga3Zt X3ZnaWNfZmx1c2hfaHdzdGF0ZSgpIGZvciBiZXR0ZXIgcGVyZm9ybWFuY2UuCj4gCj4gTW9zdCB0 aW1lIGl0IHdvcmtzLCBidXQgd2UgaGF2ZSBtZXQgYW4gZXJyb3Igb24gb3VyIGhhcmR3YXJlIHJl Y2VudGx5Lgo+IEluIHByZWVtcHRhYmxlIGtlcm5lbCwgdGhlIHZjcHUgY2FuIGJlIHByZWVtcHRl ZCBiZXR3ZWVuIHZjcHVfbG9hZCBhbmQKPiBrdm1fdmdpY19mbHVzaF9od3N0YXRlLiBBcyBhIHJl c3VsdCwgaXQgZ2V0IGRlLXNjaGVkdWxlZCBhbmQKPiBpdHNfY2xlYXJfdnBlbmRfdmFsaWQoKSBp cyBjYWxsZWQKPiAKPiAJdmFsID0gZ2ljcl9yZWFkX3ZwZW5kYmFzZXIodmxwaV9iYXNlICsgR0lD Ul9WUEVOREJBU0VSKTsKPiAJdmFsICY9IH5HSUNSX1ZQRU5EQkFTRVJfVmFsaWQ7Cj4gCXZhbCAm PSB+Y2xyOwo+IAl2YWwgfD0gc2V0Owo+IAlnaWNyX3dyaXRlX3ZwZW5kYmFzZXIodmFsLCB2bHBp X2Jhc2UgKyBHSUNSX1ZQRU5EQkFTRVIpOwo+IAo+IAo+IFRoZSBmdW5jdGlvbiBjbGVhcnMgVmFs aWQgYml0IG1lYW53aGlsZSBHSUNSX1ZQRU5EQkFTRVJfRGlydHkKPiBtYXliZSBzdGlsbCAxLCB3 aGljaCBjYXVzZSB0aGUgc3Vic2VxdWVudCBHSUNSX1ZQRU5EQkFTRVJfRGlydHkgcG9sbGluZwo+ IGZhaWwgYW5kIHJlcG9ydCAiIklUUyB2aXJ0dWFsIHBlbmRpbmcgdGFibGUgbm90IGNsZWFuaW5n Ii4KPiAKPiBXZSBoYXZlIGNvbW11bmljYXRlZCB3aXRoIE1hcnRpbiBmcm9tIEFSTSBhbmQgZ2V0 IHRoZSBjb25jbHVzaW9uCj4gdGhhdCB3ZSBzaG91bGQgbm90IGNoYW5nZSB2YWxpZCBiaXQgd2hp bGUgdGhlIGRpcnR5IGJpdCBub3QgY2xlYXLigJTigJQKPiAiVGhlIGRpcnR5IGJpdCByZXBvcnRz IHdoZXRoZXIgdGhlIGxhc3Qgc2NoZWR1bGUgL2RlLXNjaGVkdWxlCj4gb3BlcmF0aW9uIGhhcyBj b21wbGV0ZWQuVGhlIHJlc3RyaWN0aW9uIG9uIG5vdCBjaGFuZ2luZyBWYWxpZCB3aGVuIERpcnR5 Cj4gaXMgMSwgaXMgc28gdGhhdCBoYXJkd2FyZSBjYW4gYWx3YXlzIGNvbXBsZXRlIHRoZSBsYXN0 IG9wZXJhdGlvbiBmb3IKPiBzdGFydGluZyB0aGUgbmV4dCIuCgpJbmRlZWQsIHRoZSBzcGVjIGlz IGNyeXN0YWwgY2xlYXIgYWJvdXQgdGhhdCwgYW5kIGNsZWFyaW5nIFZhbGlkIHdoaWxlCkRpcnR5 IGlzIHNldCBpcyBwbGFpbiB3cm9uZy4KCj4gCj4gSSB0aGluayBtYXliZSB3ZSBjYW4gY2hlY2sg ZGlydHkgYml0IGNsZWFyIGJlZm9yZSBjbGVhcmluZyB0aGUgdmFsaWQgYml0Cj4gaW4gaXRzX2Ns ZWFyX3ZwZW5kX3ZhbGlkKCkgY29kZS4gSG9wZSB0byBrbm93IHlvdXIgb3BpbmlvbiBhYm91dCB0 aGlzCj4gaXNzdWUuCgpZZXMsIHRoYXQncyB3aGF0IHNob3VsZCBoYXBwZW4uIEkgY2FtZSB1cCB3 aXRoIHRoZSBwYXRjaCBiZWxvdy4gUGxlYXNlCmdpdmUgaXQgYSBzaG90IGFuZCBsZXQgbWUga25v dyBpZiB0aGF0IGhlbHBzLiBJZiBpdCBkb2VzLCBJJ2xsIHF1ZXVlCml0IGFzIGEgZml4LgoKVGhh bmtzLAoKCU0uCgpGcm9tIGMyM2NjYzljZmE2MDNlMzBhYzE4OWQ0M2FmNzVmMDNiNjBkNzgwYmMg TW9uIFNlcCAxNyAwMDowMDowMCAyMDAxCkZyb206IE1hcmMgWnluZ2llciA8bWF6QGtlcm5lbC5v cmc+CkRhdGU6IFRodSwgMTcgTWFyIDIwMjIgMDk6NDk6MDIgKzAwMDAKU3ViamVjdDogW1BBVENI XSBpcnFjaGlwL2dpYy12NDogV2FpdCBmb3IgR0lDUl9WUEVOREJBU0VSLkRpcnR5IHRvIGNsZWFy CiBiZWZvcmUgZGVzY2hlZHVsaW5nCgpUaGUgd2F5IEtWTSBkcml2ZXMgR0lDdjQuezAsMX0gaXMg YXMgZm9sbG93czoKLSB2Y3B1X2xvYWQoKSBtYWtlcyB0aGUgVlBFIHJlc2lkZW50LCBpbnN0cnVj dGluZyB0aGUgUkQgdG8gc3RhcnQKICBzY2FubmluZyBmb3IgaW50ZXJydXB0cwotIGp1c3QgYmVm b3JlIGVudGVyaW5nIHRoZSBndWVzdCwgd2UgY2hlY2sgdGhhdCB0aGUgUkQgaGFzIGZpbmlzaGVk CiAgc2Nhbm5pbmcgYW5kIHRoYXQgd2UgY2FuIHN0YXJ0IHJ1bm5pbmcgdGhlIHZjcHUKLSBvbiBw cmVlbXB0aW9uLCB3ZSBkZXNjaGVkdWxlIHRoZSBWUEUgYnkgbWFraW5nIGl0IGludmFsaWQgb24K ICB0aGUgUkQKCkhvd2V2ZXIsIHdlIGFyZSBwcmVlbXB0aWJsZSBiZXR3ZWVuIHRoZSBmaXJzdCB0 d28gc3RlcHMuIElmIGl0IHNvCmhhcHBlbnMgKmFuZCogdGhhdCB0aGUgUkQgd2FzIHN0aWxsIHNj YW5uaW5nLCB3ZSBub25ldGhlbGVzcyB3cml0ZQp0byB0aGUgR0lDUl9WUEVOREJBU0VSIHJlZ2lz dGVyIHdoaWxlIERpcnR5IGlzIHNldCwgYW5kIGJhZCB0aGluZ3MKaGFwcGVuICh3ZSdyZSBpbiBV TlBSRUQgbGFuZCkuCgpUaGlzIGFmZmVjdHMgYm90aCB0aGUgNC4wIGFuZCA0LjEgaW1wbGVtZW50 YXRpb25zLgoKTWFrZSBzdXJlIERpcnR5IGlzIGNsZWFyZWQgYmVmb3JlIHBlcmZvcm1pbmcgdGhl IGRlc2NoZWR1bGUsCm1lYW5pbmcgdGhhdCBpdHNfY2xlYXJfdnBlbmRfdmFsaWQoKSBiZWNvbWVz IGEgc29ydCBvZiBmdWxsIFZQRQpyZXNpZGVuY3kgYmFycmllci4KClJlcG9ydGVkLWJ5OiBKaW5n eWkgV2FuZyA8d2FuZ2ppbmd5aTExQGh1YXdlaS5jb20+ClNpZ25lZC1vZmYtYnk6IE1hcmMgWnlu Z2llciA8bWF6QGtlcm5lbC5vcmc+CkZpeGVzOiA1N2UzY2ViZDAyMmYgKCJLVk06IGFybTY0OiBE ZWxheSB0aGUgcG9sbGluZyBvZiB0aGUgR0lDUl9WUEVOREJBU0VSLkRpcnR5CmJpdCIpCkxpbms6 IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL3IvNGFhZTEwYmEtYjM5YS01Zjg0LTc1NGItNjljMmVi MGEyYzAzQGh1YXdlaS5jb20KLS0tCiBkcml2ZXJzL2lycWNoaXAvaXJxLWdpYy12My1pdHMuYyB8 IDI4ICsrKysrKysrKysrKysrKysrKystLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAxOSBpbnNl cnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvaXJxY2hpcC9p cnEtZ2ljLXYzLWl0cy5jIGIvZHJpdmVycy9pcnFjaGlwL2lycS1naWMtdjMtaXRzLmMKaW5kZXgg OWU5M2ZmMmI2Mzc1Li5jOWIxZGY5ODA4OTkgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvaXJxY2hpcC9p cnEtZ2ljLXYzLWl0cy5jCisrKyBiL2RyaXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLWl0cy5jCkBA IC0zMDExLDE4ICszMDExLDEyIEBAIHN0YXRpYyBpbnQgX19pbml0IGFsbG9jYXRlX2xwaV90YWJs ZXModm9pZCkKIAlyZXR1cm4gMDsKIH0KIAotc3RhdGljIHU2NCBpdHNfY2xlYXJfdnBlbmRfdmFs aWQodm9pZCBfX2lvbWVtICp2bHBpX2Jhc2UsIHU2NCBjbHIsIHU2NCBzZXQpCitzdGF0aWMgdTY0 IHJlYWRfdnBlbmRfZGlydHlfY2xlYXIodm9pZCBfX2lvbWVtICp2bHBpX2Jhc2UpCiB7CiAJdTMy IGNvdW50ID0gMTAwMDAwMDsJLyogMXMhICovCiAJYm9vbCBjbGVhbjsKIAl1NjQgdmFsOwogCi0J dmFsID0gZ2ljcl9yZWFkX3ZwZW5kYmFzZXIodmxwaV9iYXNlICsgR0lDUl9WUEVOREJBU0VSKTsK LQl2YWwgJj0gfkdJQ1JfVlBFTkRCQVNFUl9WYWxpZDsKLQl2YWwgJj0gfmNscjsKLQl2YWwgfD0g c2V0OwotCWdpY3Jfd3JpdGVfdnBlbmRiYXNlcih2YWwsIHZscGlfYmFzZSArIEdJQ1JfVlBFTkRC QVNFUik7Ci0KIAlkbyB7CiAJCXZhbCA9IGdpY3JfcmVhZF92cGVuZGJhc2VyKHZscGlfYmFzZSAr IEdJQ1JfVlBFTkRCQVNFUik7CiAJCWNsZWFuID0gISh2YWwgJiBHSUNSX1ZQRU5EQkFTRVJfRGly dHkpOwpAQCAtMzAzMywxMCArMzAyNywyNiBAQCBzdGF0aWMgdTY0IGl0c19jbGVhcl92cGVuZF92 YWxpZCh2b2lkIF9faW9tZW0gKnZscGlfYmFzZSwgdTY0IGNsciwgdTY0IHNldCkKIAkJfQogCX0g d2hpbGUgKCFjbGVhbiAmJiBjb3VudCk7CiAKLQlpZiAodW5saWtlbHkodmFsICYgR0lDUl9WUEVO REJBU0VSX0RpcnR5KSkgeworCWlmICh1bmxpa2VseSghY2xlYW4pKQogCQlwcl9lcnJfcmF0ZWxp bWl0ZWQoIklUUyB2aXJ0dWFsIHBlbmRpbmcgdGFibGUgbm90IGNsZWFuaW5nXG4iKTsKKworCXJl dHVybiB2YWw7Cit9CisKK3N0YXRpYyB1NjQgaXRzX2NsZWFyX3ZwZW5kX3ZhbGlkKHZvaWQgX19p b21lbSAqdmxwaV9iYXNlLCB1NjQgY2xyLCB1NjQgc2V0KQoreworCXU2NCB2YWw7CisKKwkvKiBN YWtlIHN1cmUgd2Ugd2FpdCB1bnRpbCB0aGUgUkQgaXMgZG9uZSB3aXRoIHRoZSBpbml0aWFsIHNj YW4gKi8KKwl2YWwgPSByZWFkX3ZwZW5kX2RpcnR5X2NsZWFyKHZscGlfYmFzZSk7CisJdmFsICY9 IH5HSUNSX1ZQRU5EQkFTRVJfVmFsaWQ7CisJdmFsICY9IH5jbHI7CisJdmFsIHw9IHNldDsKKwln aWNyX3dyaXRlX3ZwZW5kYmFzZXIodmFsLCB2bHBpX2Jhc2UgKyBHSUNSX1ZQRU5EQkFTRVIpOwor CisJdmFsID0gcmVhZF92cGVuZF9kaXJ0eV9jbGVhcih2bHBpX2Jhc2UpOworCWlmICh1bmxpa2Vs eSh2YWwgJiBHSUNSX1ZQRU5EQkFTRVJfRGlydHkpKQogCQl2YWwgfD0gR0lDUl9WUEVOREJBU0VS X1BlbmRpbmdMYXN0OwotCX0KIAogCXJldHVybiB2YWw7CiB9Ci0tIAoyLjM0LjEKCgotLSAKV2l0 aG91dCBkZXZpYXRpb24gZnJvbSB0aGUgbm9ybSwgcHJvZ3Jlc3MgaXMgbm90IHBvc3NpYmxlLgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwprdm1hcm0gbWFp bGluZyBsaXN0Cmt2bWFybUBsaXN0cy5jcy5jb2x1bWJpYS5lZHUKaHR0cHM6Ly9saXN0cy5jcy5j b2x1bWJpYS5lZHUvbWFpbG1hbi9saXN0aW5mby9rdm1hcm0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C8BAC433EF for ; Thu, 17 Mar 2022 10:18:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=K74xBNhvkr+Wvmz9jquqA2Pfmlve42rDwCywtK4iSBU=; b=yQguojNAXOz2/g GzHP/YHJ01Tl4w1ezWZAEa0FqI+JCjdqa995yt9+037YvS7HbBoWQpYRW686SAoychKDeFzPsbwHj X/3LlzQjMgs3e/5zA4i4Te72MY01K/edTsm9w+EaAtC4panOz4J01TKDmVk1Jl6i+xuH0la1PV52t sW9NAo/j3WB9THpDTG6KF8HXTEOJUvuEap4BzmMF8AZcBuk8swUeTdxDECmj98IZ2fYNEUuv9PHX8 nvr/KoLeL9boq4853FqaiYdePCX3nzljc9mR0kHkppMpQ2lYwEOP9E0zPWl+b+d3zPCoQy8IatAKG F2IC0uYYgf3U50a0J0fg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUnC9-00FgZw-Mu; Thu, 17 Mar 2022 10:17:26 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUnC5-00FgYO-6P for linux-arm-kernel@lists.infradead.org; Thu, 17 Mar 2022 10:17:23 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6CAE9617BB; Thu, 17 Mar 2022 10:17:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D19A3C340E9; Thu, 17 Mar 2022 10:17:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647512238; bh=Ac3+Zu4JJhOiqtXO0r903zb8S377HU8RCpuDNXxEp2w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LIxewhOO7mTDGWxC+uGpYafMzpVkySVAs6tXhhapSeaXVim+9LNI7555bLoYnApeN n/b2xuUZpQXwKY6McT6P4ScoLs/JLLx3pwXXq7M134j0HTVMzwXA2/Du06nIK4tVic f1KAqb2NfmPLZLGIGXuTEkdeUspaVpScyjosUHPdXBvG47ifksIqpkLepnizo6vvTp aPV/DWF4VtB7JBQlew+Nw8j21TwmRnn7jq+5cAIMPabcKFrW86OpzB2Vu9/l1H8hu4 gWla4KDA67C4/j+yzLIlGunHoH6Q8zwat3WwZ0BQSDuWm/u4tu7I2OGui8WaD049xG +fHeBdE3Df2/g== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nUnC0-00F92j-GX; Thu, 17 Mar 2022 10:17:16 +0000 Date: Thu, 17 Mar 2022 10:17:16 +0000 Message-ID: <87v8wcyjbn.wl-maz@kernel.org> From: Marc Zyngier To: Jingyi Wang Cc: , , , "wanghaibin.wang@huawei.com" , "yuzenghui@huawei.com" , , , Subject: Re: Report an error on GICv4.1 vcpu de-schedule In-Reply-To: <4aae10ba-b39a-5f84-754b-69c2eb0a2c03@huawei.com> References: <4aae10ba-b39a-5f84-754b-69c2eb0a2c03@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: wangjingyi11@huawei.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, wanghaibin.wang@huawei.com, yuzenghui@huawei.com, Martin.Weidmann@arm.com, tangnianyao@huawei.com, chengjian8@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220317_031721_360268_22B19B08 X-CRM114-Status: GOOD ( 33.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgSmluZ3lpLAoKT24gVGh1LCAxNyBNYXIgMjAyMiAwNzoyNzo0NSArMDAwMCwKSmluZ3lpIFdh bmcgPHdhbmdqaW5neWkxMUBodWF3ZWkuY29tPiB3cm90ZToKPiAKPiBIaSBNYXJj77yMCj4gCj4g VGhlIHBhdGNoICJLVk06IGFybTY0OiBEZWxheSB0aGUgcG9sbGluZyBvZiB0aGUgR0lDUl9WUEVO REJBU0VSLkRpcnR5Cj4gYml0Iig1N2UzY2ViZDAyMmZiYzAzNWRjZjE5MGFjNzg5ZmQyZmZjNzQ3 ZjViKSByZW1vdmUgdGhlIHBvbGxpbmcgb2YKPiBHSUNSX1ZQRU5EQkFTRVIuRGlydHkgYml0IGlu IHZjcHVfbG9hZCgpICwgd2hpbGUgY2hlY2sgdGhlIFZQVCBwYXJzaW5nCj4gcmVhZHkgaW4ga3Zt X3ZnaWNfZmx1c2hfaHdzdGF0ZSgpIGZvciBiZXR0ZXIgcGVyZm9ybWFuY2UuCj4gCj4gTW9zdCB0 aW1lIGl0IHdvcmtzLCBidXQgd2UgaGF2ZSBtZXQgYW4gZXJyb3Igb24gb3VyIGhhcmR3YXJlIHJl Y2VudGx5Lgo+IEluIHByZWVtcHRhYmxlIGtlcm5lbCwgdGhlIHZjcHUgY2FuIGJlIHByZWVtcHRl ZCBiZXR3ZWVuIHZjcHVfbG9hZCBhbmQKPiBrdm1fdmdpY19mbHVzaF9od3N0YXRlLiBBcyBhIHJl c3VsdCwgaXQgZ2V0IGRlLXNjaGVkdWxlZCBhbmQKPiBpdHNfY2xlYXJfdnBlbmRfdmFsaWQoKSBp cyBjYWxsZWQKPiAKPiAJdmFsID0gZ2ljcl9yZWFkX3ZwZW5kYmFzZXIodmxwaV9iYXNlICsgR0lD Ul9WUEVOREJBU0VSKTsKPiAJdmFsICY9IH5HSUNSX1ZQRU5EQkFTRVJfVmFsaWQ7Cj4gCXZhbCAm PSB+Y2xyOwo+IAl2YWwgfD0gc2V0Owo+IAlnaWNyX3dyaXRlX3ZwZW5kYmFzZXIodmFsLCB2bHBp X2Jhc2UgKyBHSUNSX1ZQRU5EQkFTRVIpOwo+IAo+IAo+IFRoZSBmdW5jdGlvbiBjbGVhcnMgVmFs aWQgYml0IG1lYW53aGlsZSBHSUNSX1ZQRU5EQkFTRVJfRGlydHkKPiBtYXliZSBzdGlsbCAxLCB3 aGljaCBjYXVzZSB0aGUgc3Vic2VxdWVudCBHSUNSX1ZQRU5EQkFTRVJfRGlydHkgcG9sbGluZwo+ IGZhaWwgYW5kIHJlcG9ydCAiIklUUyB2aXJ0dWFsIHBlbmRpbmcgdGFibGUgbm90IGNsZWFuaW5n Ii4KPiAKPiBXZSBoYXZlIGNvbW11bmljYXRlZCB3aXRoIE1hcnRpbiBmcm9tIEFSTSBhbmQgZ2V0 IHRoZSBjb25jbHVzaW9uCj4gdGhhdCB3ZSBzaG91bGQgbm90IGNoYW5nZSB2YWxpZCBiaXQgd2hp bGUgdGhlIGRpcnR5IGJpdCBub3QgY2xlYXLigJTigJQKPiAiVGhlIGRpcnR5IGJpdCByZXBvcnRz IHdoZXRoZXIgdGhlIGxhc3Qgc2NoZWR1bGUgL2RlLXNjaGVkdWxlCj4gb3BlcmF0aW9uIGhhcyBj b21wbGV0ZWQuVGhlIHJlc3RyaWN0aW9uIG9uIG5vdCBjaGFuZ2luZyBWYWxpZCB3aGVuIERpcnR5 Cj4gaXMgMSwgaXMgc28gdGhhdCBoYXJkd2FyZSBjYW4gYWx3YXlzIGNvbXBsZXRlIHRoZSBsYXN0 IG9wZXJhdGlvbiBmb3IKPiBzdGFydGluZyB0aGUgbmV4dCIuCgpJbmRlZWQsIHRoZSBzcGVjIGlz IGNyeXN0YWwgY2xlYXIgYWJvdXQgdGhhdCwgYW5kIGNsZWFyaW5nIFZhbGlkIHdoaWxlCkRpcnR5 IGlzIHNldCBpcyBwbGFpbiB3cm9uZy4KCj4gCj4gSSB0aGluayBtYXliZSB3ZSBjYW4gY2hlY2sg ZGlydHkgYml0IGNsZWFyIGJlZm9yZSBjbGVhcmluZyB0aGUgdmFsaWQgYml0Cj4gaW4gaXRzX2Ns ZWFyX3ZwZW5kX3ZhbGlkKCkgY29kZS4gSG9wZSB0byBrbm93IHlvdXIgb3BpbmlvbiBhYm91dCB0 aGlzCj4gaXNzdWUuCgpZZXMsIHRoYXQncyB3aGF0IHNob3VsZCBoYXBwZW4uIEkgY2FtZSB1cCB3 aXRoIHRoZSBwYXRjaCBiZWxvdy4gUGxlYXNlCmdpdmUgaXQgYSBzaG90IGFuZCBsZXQgbWUga25v dyBpZiB0aGF0IGhlbHBzLiBJZiBpdCBkb2VzLCBJJ2xsIHF1ZXVlCml0IGFzIGEgZml4LgoKVGhh bmtzLAoKCU0uCgpGcm9tIGMyM2NjYzljZmE2MDNlMzBhYzE4OWQ0M2FmNzVmMDNiNjBkNzgwYmMg TW9uIFNlcCAxNyAwMDowMDowMCAyMDAxCkZyb206IE1hcmMgWnluZ2llciA8bWF6QGtlcm5lbC5v cmc+CkRhdGU6IFRodSwgMTcgTWFyIDIwMjIgMDk6NDk6MDIgKzAwMDAKU3ViamVjdDogW1BBVENI XSBpcnFjaGlwL2dpYy12NDogV2FpdCBmb3IgR0lDUl9WUEVOREJBU0VSLkRpcnR5IHRvIGNsZWFy CiBiZWZvcmUgZGVzY2hlZHVsaW5nCgpUaGUgd2F5IEtWTSBkcml2ZXMgR0lDdjQuezAsMX0gaXMg YXMgZm9sbG93czoKLSB2Y3B1X2xvYWQoKSBtYWtlcyB0aGUgVlBFIHJlc2lkZW50LCBpbnN0cnVj dGluZyB0aGUgUkQgdG8gc3RhcnQKICBzY2FubmluZyBmb3IgaW50ZXJydXB0cwotIGp1c3QgYmVm b3JlIGVudGVyaW5nIHRoZSBndWVzdCwgd2UgY2hlY2sgdGhhdCB0aGUgUkQgaGFzIGZpbmlzaGVk CiAgc2Nhbm5pbmcgYW5kIHRoYXQgd2UgY2FuIHN0YXJ0IHJ1bm5pbmcgdGhlIHZjcHUKLSBvbiBw cmVlbXB0aW9uLCB3ZSBkZXNjaGVkdWxlIHRoZSBWUEUgYnkgbWFraW5nIGl0IGludmFsaWQgb24K ICB0aGUgUkQKCkhvd2V2ZXIsIHdlIGFyZSBwcmVlbXB0aWJsZSBiZXR3ZWVuIHRoZSBmaXJzdCB0 d28gc3RlcHMuIElmIGl0IHNvCmhhcHBlbnMgKmFuZCogdGhhdCB0aGUgUkQgd2FzIHN0aWxsIHNj YW5uaW5nLCB3ZSBub25ldGhlbGVzcyB3cml0ZQp0byB0aGUgR0lDUl9WUEVOREJBU0VSIHJlZ2lz dGVyIHdoaWxlIERpcnR5IGlzIHNldCwgYW5kIGJhZCB0aGluZ3MKaGFwcGVuICh3ZSdyZSBpbiBV TlBSRUQgbGFuZCkuCgpUaGlzIGFmZmVjdHMgYm90aCB0aGUgNC4wIGFuZCA0LjEgaW1wbGVtZW50 YXRpb25zLgoKTWFrZSBzdXJlIERpcnR5IGlzIGNsZWFyZWQgYmVmb3JlIHBlcmZvcm1pbmcgdGhl IGRlc2NoZWR1bGUsCm1lYW5pbmcgdGhhdCBpdHNfY2xlYXJfdnBlbmRfdmFsaWQoKSBiZWNvbWVz IGEgc29ydCBvZiBmdWxsIFZQRQpyZXNpZGVuY3kgYmFycmllci4KClJlcG9ydGVkLWJ5OiBKaW5n eWkgV2FuZyA8d2FuZ2ppbmd5aTExQGh1YXdlaS5jb20+ClNpZ25lZC1vZmYtYnk6IE1hcmMgWnlu Z2llciA8bWF6QGtlcm5lbC5vcmc+CkZpeGVzOiA1N2UzY2ViZDAyMmYgKCJLVk06IGFybTY0OiBE ZWxheSB0aGUgcG9sbGluZyBvZiB0aGUgR0lDUl9WUEVOREJBU0VSLkRpcnR5CmJpdCIpCkxpbms6 IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL3IvNGFhZTEwYmEtYjM5YS01Zjg0LTc1NGItNjljMmVi MGEyYzAzQGh1YXdlaS5jb20KLS0tCiBkcml2ZXJzL2lycWNoaXAvaXJxLWdpYy12My1pdHMuYyB8 IDI4ICsrKysrKysrKysrKysrKysrKystLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAxOSBpbnNl cnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvaXJxY2hpcC9p cnEtZ2ljLXYzLWl0cy5jIGIvZHJpdmVycy9pcnFjaGlwL2lycS1naWMtdjMtaXRzLmMKaW5kZXgg OWU5M2ZmMmI2Mzc1Li5jOWIxZGY5ODA4OTkgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvaXJxY2hpcC9p cnEtZ2ljLXYzLWl0cy5jCisrKyBiL2RyaXZlcnMvaXJxY2hpcC9pcnEtZ2ljLXYzLWl0cy5jCkBA IC0zMDExLDE4ICszMDExLDEyIEBAIHN0YXRpYyBpbnQgX19pbml0IGFsbG9jYXRlX2xwaV90YWJs ZXModm9pZCkKIAlyZXR1cm4gMDsKIH0KIAotc3RhdGljIHU2NCBpdHNfY2xlYXJfdnBlbmRfdmFs aWQodm9pZCBfX2lvbWVtICp2bHBpX2Jhc2UsIHU2NCBjbHIsIHU2NCBzZXQpCitzdGF0aWMgdTY0 IHJlYWRfdnBlbmRfZGlydHlfY2xlYXIodm9pZCBfX2lvbWVtICp2bHBpX2Jhc2UpCiB7CiAJdTMy IGNvdW50ID0gMTAwMDAwMDsJLyogMXMhICovCiAJYm9vbCBjbGVhbjsKIAl1NjQgdmFsOwogCi0J dmFsID0gZ2ljcl9yZWFkX3ZwZW5kYmFzZXIodmxwaV9iYXNlICsgR0lDUl9WUEVOREJBU0VSKTsK LQl2YWwgJj0gfkdJQ1JfVlBFTkRCQVNFUl9WYWxpZDsKLQl2YWwgJj0gfmNscjsKLQl2YWwgfD0g c2V0OwotCWdpY3Jfd3JpdGVfdnBlbmRiYXNlcih2YWwsIHZscGlfYmFzZSArIEdJQ1JfVlBFTkRC QVNFUik7Ci0KIAlkbyB7CiAJCXZhbCA9IGdpY3JfcmVhZF92cGVuZGJhc2VyKHZscGlfYmFzZSAr IEdJQ1JfVlBFTkRCQVNFUik7CiAJCWNsZWFuID0gISh2YWwgJiBHSUNSX1ZQRU5EQkFTRVJfRGly dHkpOwpAQCAtMzAzMywxMCArMzAyNywyNiBAQCBzdGF0aWMgdTY0IGl0c19jbGVhcl92cGVuZF92 YWxpZCh2b2lkIF9faW9tZW0gKnZscGlfYmFzZSwgdTY0IGNsciwgdTY0IHNldCkKIAkJfQogCX0g d2hpbGUgKCFjbGVhbiAmJiBjb3VudCk7CiAKLQlpZiAodW5saWtlbHkodmFsICYgR0lDUl9WUEVO REJBU0VSX0RpcnR5KSkgeworCWlmICh1bmxpa2VseSghY2xlYW4pKQogCQlwcl9lcnJfcmF0ZWxp bWl0ZWQoIklUUyB2aXJ0dWFsIHBlbmRpbmcgdGFibGUgbm90IGNsZWFuaW5nXG4iKTsKKworCXJl dHVybiB2YWw7Cit9CisKK3N0YXRpYyB1NjQgaXRzX2NsZWFyX3ZwZW5kX3ZhbGlkKHZvaWQgX19p b21lbSAqdmxwaV9iYXNlLCB1NjQgY2xyLCB1NjQgc2V0KQoreworCXU2NCB2YWw7CisKKwkvKiBN YWtlIHN1cmUgd2Ugd2FpdCB1bnRpbCB0aGUgUkQgaXMgZG9uZSB3aXRoIHRoZSBpbml0aWFsIHNj YW4gKi8KKwl2YWwgPSByZWFkX3ZwZW5kX2RpcnR5X2NsZWFyKHZscGlfYmFzZSk7CisJdmFsICY9 IH5HSUNSX1ZQRU5EQkFTRVJfVmFsaWQ7CisJdmFsICY9IH5jbHI7CisJdmFsIHw9IHNldDsKKwln aWNyX3dyaXRlX3ZwZW5kYmFzZXIodmFsLCB2bHBpX2Jhc2UgKyBHSUNSX1ZQRU5EQkFTRVIpOwor CisJdmFsID0gcmVhZF92cGVuZF9kaXJ0eV9jbGVhcih2bHBpX2Jhc2UpOworCWlmICh1bmxpa2Vs eSh2YWwgJiBHSUNSX1ZQRU5EQkFTRVJfRGlydHkpKQogCQl2YWwgfD0gR0lDUl9WUEVOREJBU0VS X1BlbmRpbmdMYXN0OwotCX0KIAogCXJldHVybiB2YWw7CiB9Ci0tIAoyLjM0LjEKCgotLSAKV2l0 aG91dCBkZXZpYXRpb24gZnJvbSB0aGUgbm9ybSwgcHJvZ3Jlc3MgaXMgbm90IHBvc3NpYmxlLgoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJt LWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtl cm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E6A2C433F5 for ; Thu, 17 Mar 2022 10:17:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232504AbiCQKSh (ORCPT ); Thu, 17 Mar 2022 06:18:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232419AbiCQKSg (ORCPT ); Thu, 17 Mar 2022 06:18:36 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10326E0985 for ; Thu, 17 Mar 2022 03:17:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 751BD617D5 for ; Thu, 17 Mar 2022 10:17:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D19A3C340E9; Thu, 17 Mar 2022 10:17:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647512238; bh=Ac3+Zu4JJhOiqtXO0r903zb8S377HU8RCpuDNXxEp2w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LIxewhOO7mTDGWxC+uGpYafMzpVkySVAs6tXhhapSeaXVim+9LNI7555bLoYnApeN n/b2xuUZpQXwKY6McT6P4ScoLs/JLLx3pwXXq7M134j0HTVMzwXA2/Du06nIK4tVic f1KAqb2NfmPLZLGIGXuTEkdeUspaVpScyjosUHPdXBvG47ifksIqpkLepnizo6vvTp aPV/DWF4VtB7JBQlew+Nw8j21TwmRnn7jq+5cAIMPabcKFrW86OpzB2Vu9/l1H8hu4 gWla4KDA67C4/j+yzLIlGunHoH6Q8zwat3WwZ0BQSDuWm/u4tu7I2OGui8WaD049xG +fHeBdE3Df2/g== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nUnC0-00F92j-GX; Thu, 17 Mar 2022 10:17:16 +0000 Date: Thu, 17 Mar 2022 10:17:16 +0000 Message-ID: <87v8wcyjbn.wl-maz@kernel.org> From: Marc Zyngier To: Jingyi Wang Cc: , , , "wanghaibin.wang@huawei.com" , "yuzenghui@huawei.com" , , , Subject: Re: Report an error on GICv4.1 vcpu de-schedule In-Reply-To: <4aae10ba-b39a-5f84-754b-69c2eb0a2c03@huawei.com> References: <4aae10ba-b39a-5f84-754b-69c2eb0a2c03@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: wangjingyi11@huawei.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, wanghaibin.wang@huawei.com, yuzenghui@huawei.com, Martin.Weidmann@arm.com, tangnianyao@huawei.com, chengjian8@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hi Jingyi, On Thu, 17 Mar 2022 07:27:45 +0000, Jingyi Wang wrote: >=20 > Hi Marc=EF=BC=8C >=20 > The patch "KVM: arm64: Delay the polling of the GICR_VPENDBASER.Dirty > bit"(57e3cebd022fbc035dcf190ac789fd2ffc747f5b) remove the polling of > GICR_VPENDBASER.Dirty bit in vcpu_load() , while check the VPT parsing > ready in kvm_vgic_flush_hwstate() for better performance. >=20 > Most time it works, but we have met an error on our hardware recently. > In preemptable kernel, the vcpu can be preempted between vcpu_load and > kvm_vgic_flush_hwstate. As a result, it get de-scheduled and > its_clear_vpend_valid() is called >=20 > val =3D gicr_read_vpendbaser(vlpi_base + GICR_VPENDBASER); > val &=3D ~GICR_VPENDBASER_Valid; > val &=3D ~clr; > val |=3D set; > gicr_write_vpendbaser(val, vlpi_base + GICR_VPENDBASER); >=20 >=20 > The function clears Valid bit meanwhile GICR_VPENDBASER_Dirty > maybe still 1, which cause the subsequent GICR_VPENDBASER_Dirty polling > fail and report ""ITS virtual pending table not cleaning". >=20 > We have communicated with Martin from ARM and get the conclusion > that we should not change valid bit while the dirty bit not clear=E2=80= =94=E2=80=94 > "The dirty bit reports whether the last schedule /de-schedule > operation has completed.The restriction on not changing Valid when Dirty > is 1, is so that hardware can always complete the last operation for > starting the next". Indeed, the spec is crystal clear about that, and clearing Valid while Dirty is set is plain wrong. >=20 > I think maybe we can check dirty bit clear before clearing the valid bit > in its_clear_vpend_valid() code. Hope to know your opinion about this > issue. Yes, that's what should happen. I came up with the patch below. Please give it a shot and let me know if that helps. If it does, I'll queue it as a fix. Thanks, M. =46rom c23ccc9cfa603e30ac189d43af75f03b60d780bc Mon Sep 17 00:00:00 2001 From: Marc Zyngier Date: Thu, 17 Mar 2022 09:49:02 +0000 Subject: [PATCH] irqchip/gic-v4: Wait for GICR_VPENDBASER.Dirty to clear before descheduling The way KVM drives GICv4.{0,1} is as follows: - vcpu_load() makes the VPE resident, instructing the RD to start scanning for interrupts - just before entering the guest, we check that the RD has finished scanning and that we can start running the vcpu - on preemption, we deschedule the VPE by making it invalid on the RD However, we are preemptible between the first two steps. If it so happens *and* that the RD was still scanning, we nonetheless write to the GICR_VPENDBASER register while Dirty is set, and bad things happen (we're in UNPRED land). This affects both the 4.0 and 4.1 implementations. Make sure Dirty is cleared before performing the deschedule, meaning that its_clear_vpend_valid() becomes a sort of full VPE residency barrier. Reported-by: Jingyi Wang Signed-off-by: Marc Zyngier Fixes: 57e3cebd022f ("KVM: arm64: Delay the polling of the GICR_VPENDBASER.= Dirty bit") Link: https://lore.kernel.org/r/4aae10ba-b39a-5f84-754b-69c2eb0a2c03@huawei= .com --- drivers/irqchip/irq-gic-v3-its.c | 28 +++++++++++++++++++--------- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-= its.c index 9e93ff2b6375..c9b1df980899 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -3011,18 +3011,12 @@ static int __init allocate_lpi_tables(void) return 0; } =20 -static u64 its_clear_vpend_valid(void __iomem *vlpi_base, u64 clr, u64 set) +static u64 read_vpend_dirty_clear(void __iomem *vlpi_base) { u32 count =3D 1000000; /* 1s! */ bool clean; u64 val; =20 - val =3D gicr_read_vpendbaser(vlpi_base + GICR_VPENDBASER); - val &=3D ~GICR_VPENDBASER_Valid; - val &=3D ~clr; - val |=3D set; - gicr_write_vpendbaser(val, vlpi_base + GICR_VPENDBASER); - do { val =3D gicr_read_vpendbaser(vlpi_base + GICR_VPENDBASER); clean =3D !(val & GICR_VPENDBASER_Dirty); @@ -3033,10 +3027,26 @@ static u64 its_clear_vpend_valid(void __iomem *vlpi= _base, u64 clr, u64 set) } } while (!clean && count); =20 - if (unlikely(val & GICR_VPENDBASER_Dirty)) { + if (unlikely(!clean)) pr_err_ratelimited("ITS virtual pending table not cleaning\n"); + + return val; +} + +static u64 its_clear_vpend_valid(void __iomem *vlpi_base, u64 clr, u64 set) +{ + u64 val; + + /* Make sure we wait until the RD is done with the initial scan */ + val =3D read_vpend_dirty_clear(vlpi_base); + val &=3D ~GICR_VPENDBASER_Valid; + val &=3D ~clr; + val |=3D set; + gicr_write_vpendbaser(val, vlpi_base + GICR_VPENDBASER); + + val =3D read_vpend_dirty_clear(vlpi_base); + if (unlikely(val & GICR_VPENDBASER_Dirty)) val |=3D GICR_VPENDBASER_PendingLast; - } =20 return val; } --=20 2.34.1 --=20 Without deviation from the norm, progress is not possible.