Re: [Intel-gfx] [PATCH 2/3] drm/i915: Simplify intel_dsc_source_support()

[Jani Nikula <jani.nikula@linux.intel.com>]

On Fri, 21 Jan 2022, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> We can simplify the icl check in intel_dsc_source_support()
> by noting that the only case when DSC is not supported is when
> using transcoder A.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_vdsc.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c b/drivers/gpu/drm/i915/display/intel_vdsc.c
> index 9b05f93ed8bc..3faea903b9ae 100644
> --- a/drivers/gpu/drm/i915/display/intel_vdsc.c
> +++ b/drivers/gpu/drm/i915/display/intel_vdsc.c
> @@ -341,19 +341,14 @@ bool intel_dsc_source_support(const struct intel_crtc_state *crtc_state)
>  	const struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
>  	struct drm_i915_private *i915 = to_i915(crtc->base.dev);
>  	enum transcoder cpu_transcoder = crtc_state->cpu_transcoder;
> -	enum pipe pipe = crtc->pipe;
>  
>  	if (!INTEL_INFO(i915)->display.has_dsc)
>  		return false;
>  
> -	/* On TGL, DSC is supported on all Pipes */
>  	if (DISPLAY_VER(i915) >= 12)
>  		return true;
>  
> -	if (DISPLAY_VER(i915) >= 11 &&
> -	    (pipe != PIPE_A || cpu_transcoder == TRANSCODER_EDP ||
> -	     cpu_transcoder == TRANSCODER_DSI_0 ||
> -	     cpu_transcoder == TRANSCODER_DSI_1))
> +	if (DISPLAY_VER(i915) >= 11 && cpu_transcoder != TRANSCODER_A)
>  		return true;
>  
>  	return false;

-- 
Jani Nikula, Intel Open Source Graphics Center