From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by gabe.freedesktop.org (Postfix) with ESMTPS id D87FD10E9CA
 for <igt-dev@lists.freedesktop.org>; Tue, 14 Dec 2021 05:04:25 +0000 (UTC)
Date: Mon, 13 Dec 2021 21:04:22 -0800
Message-ID: <87v8zr93qh.wl-ashutosh.dixit@intel.com>
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
In-Reply-To: <87y24n9557.wl-ashutosh.dixit@intel.com>
References: <20211213181208.159531-1-zbigniew.kempczynski@intel.com>
 <87y24n9557.wl-ashutosh.dixit@intel.com>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=ISO-8859-2
Content-Transfer-Encoding: quoted-printable
Subject: Re: [igt-dev] [PATCH i-g-t] lib/i915/intel_memory_region: Handle
 -ENODEV path individually
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
To: Zbigniew =?ISO-8859-2?Q?Kempczy=F1ski?= <zbigniew.kempczynski@intel.com>
Cc: igt-dev@lists.freedesktop.org, Petri Latvala <petri.latvala@intel.com>
List-ID: <igt-dev@lists.freedesktop.org>

On Mon, 13 Dec 2021 20:33:56 -0800, Dixit, Ashutosh wrote:
>
> On Mon, 13 Dec 2021 10:12:08 -0800, Zbigniew Kempczy=F1ski wrote:
> >
> > As Ashutosh noticed I've handled errors from the kernel too wide
> > packing it to same error bag and returning system memory region in this
> > case. That's of course is wrong and can lead to return system memory on
> > discrete if invalid arguments would be passed to the query.
> >
> > Return previous behavior of query memory regions handling -ENODEV path
> > individually. For this error lets assume we got kernel which doesn't
> > support this query yet so returning system memory region is a reasonable
> > choice because this region exists for all of i915 gens.
>
> Looks good now so this is:
>
> Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
>
> But could you please point out where the -ENODEV return code is coming
> from and which stable kernel. Thanks.

OK I see where it's coming from on 5.15.y so don't bother. Thanks.