From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Magnus Karlsson <magnus.karlsson@gmail.com>,
Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: bpf <bpf@vger.kernel.org>
Subject: Re: libxsk move from libbpf to libxdp
Date: Mon, 25 Oct 2021 18:03:23 +0200 [thread overview]
Message-ID: <87v91lay7o.fsf@toke.dk> (raw)
In-Reply-To: <CAJ8uoz35Xqx1YCnxB0wCd-58_u9fdzEy5xS45Jcs82gXiAnK1Q@mail.gmail.com>
Magnus Karlsson <magnus.karlsson@gmail.com> writes:
> On Fri, Oct 22, 2021 at 7:49 PM Andrii Nakryiko
> <andrii.nakryiko@gmail.com> wrote:
>>
>> Hey guys,
>>
>> It's been a while since we chatted about libxsk move. I believe last
>> time we were already almost ready to recommend libxdp for this, but
>> I'd like to double-check. Can one of you please own [0], validate that
>> whatever APIs are provided by libxdp are equivalent to what libbpf
>> provides, and start marking xdk.h APIs as deprecated? Thanks!
>
> Resending since Gmail had jumped out of plain text mode again.
>
> No problem, I will own this. I will verify the APIs are the same then
> submit a patch marking the ones in libbpf's xsk.h as deprecated.
>
> One question is what to do with the samples and the selftests for xsk.
> They currently rely on libbpf's xsk support. Two options that I see:
>
> 1: Require libxdp on the system. Do not try to compile the xsk samples
> and selftests if libxdp is not available so the rest of the bpf
> samples and selftests are not impacted.
> 2: Provide a standalone mock-up file of xsk.c and xsk.h that samples
> and selftests could use.
>
> I prefer #1 as it is better for the long-term. #2 means I would have
> to maintain that mock-up file as libxdp features are added. Sounds
> like double the amount of work to me. Thoughts?
I agree #1 is preferable of those two. Another option is to move the
samples to the xdp-tools repo instead? Doesn't work for selftests, of
course; if it's acceptable to conditionally-compile the XSK tests
depending on system library availability that would be fine by me...
I pinged the Debian maintainer of libbpf to see if I can get him to pick
up libxdp as well, or sponsor me to maintain it. Should make the
transition smoother; guess I also need to get hold of the OpenSuse
people.
-Toke
next prev parent reply other threads:[~2021-10-25 16:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 17:49 libxsk move from libbpf to libxdp Andrii Nakryiko
2021-10-25 9:11 ` Magnus Karlsson
2021-10-25 16:03 ` Toke Høiland-Jørgensen [this message]
2021-10-26 4:18 ` Andrii Nakryiko
2021-10-26 6:47 ` Magnus Karlsson
2021-10-26 14:57 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v91lay7o.fsf@toke.dk \
--to=toke@redhat.com \
--cc=andrii.nakryiko@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=magnus.karlsson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.