All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joachim Wiberg <troglobit@gmail.com>
To: Arnout Vandecappelle <arnout@mind.be>, buildroot@buildroot.org
Cc: Matt Weber <matthew.weber@collins.com>
Subject: Re: [Buildroot] [PATCH v2 2/3] package/smcroute: add sysv init script
Date: Tue, 28 Sep 2021 09:43:35 +0200	[thread overview]
Message-ID: <87v92l2li0.fsf@gmail.com> (raw)
In-Reply-To: <a275f09f-0ece-a6f9-f440-8d8659a3b5dd@mind.be>

On Sat, Sep 11, 2021 at 16:33, Arnout Vandecappelle <arnout@mind.be> wrote:
> On 30/08/2021 17:30, Joachim Wiberg wrote:
>  This is not how we usually write our start scripts, but I like it!

Thank you, I wasn't sure it would pass inspection :)

>> +{
>> +    start-stop-daemon -q -p "$PIDFILE" "$@"
>  Can't you pass the -x here as well (which makes sure that you actually kill the
> intended daemon in stop() and not some other random process that happens to have
> the same PID)?

Huh, from the usage text of start-stop-daemon it wasn't clear to me if
-x was reserved only for starting.  Thanks for alerting me to this!

>  Anyway, I applied as is.

Thanks, I'll push another bump later today, for the v2.5.3 release,
which will include a fix for -x as well.

Cheers
 /Joachim
 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2021-09-28  7:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-30 15:30 [Buildroot] [PATCH v2 0/3] bump smcroute and add start script Joachim Wiberg
2021-08-30 15:30 ` [Buildroot] [PATCH v2 1/3] package/smcroute: bump version to v2.5.2 Joachim Wiberg
2021-09-11 14:31   ` Arnout Vandecappelle
2021-08-30 15:30 ` [Buildroot] [PATCH v2 2/3] package/smcroute: add sysv init script Joachim Wiberg
2021-09-11 14:33   ` Arnout Vandecappelle
2021-09-28  7:43     ` Joachim Wiberg [this message]
2021-08-30 15:30 ` [Buildroot] [PATCH v2 3/3] package/smcroute: prune old smcroute compat script Joachim Wiberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v92l2li0.fsf@gmail.com \
    --to=troglobit@gmail.com \
    --cc=arnout@mind.be \
    --cc=buildroot@buildroot.org \
    --cc=matthew.weber@collins.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.