From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E267C4320A for ; Tue, 27 Jul 2021 08:13:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 237D260FC2 for ; Tue, 27 Jul 2021 08:13:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235912AbhG0INe (ORCPT ); Tue, 27 Jul 2021 04:13:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:53932 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235629AbhG0INd (ORCPT ); Tue, 27 Jul 2021 04:13:33 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C4D2F60F59; Tue, 27 Jul 2021 08:13:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627373613; bh=mk07JVZASltCbgO3uwu3i4rtcnRvAK+drZiyBEF4OnY=; h=References:From:To:Cc:Subject:In-reply-to:Date:From; b=fMLQJajZ6Gj4KlLPr2lzsZn3QfkjDXgX/9tuv8to94Fa8KUwIPJ2LkNO5VySc9qMh 2M1BTSd2TZGFW6huVn/J9cDje+MUt3XzsyN/7JZWl1xj3L1AryykJVy+7RVsHEhA6I 8iDOdelx61H/+2QsMRywExa7erRP6EmEf4POLZ3NAt8pdg0KXBryXyghZeR1Gi9cFG /Eub147X8tI1vdRZCGPl1z/kRwtST8ADhmfYLxV85NR2oLcMNVXrv4p93Xo4uEyzYH 0jO7CE2aee1+e/WQnUZzqkDpAs7cyj2rYJP5+Q/KcilllYUDrQOO4dl2aaFNqnbpwu kb1xE95MS7VCg== References: <20210727073142.84666-1-zhangqilong3@huawei.com> User-agent: mu4e 1.4.15; emacs 27.2 From: Felipe Balbi To: Zhang Qilong Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Subject: Re: [PATCH -next v2] usb: gadget: remove leaked entry from udc driver list In-reply-to: <20210727073142.84666-1-zhangqilong3@huawei.com> Date: Tue, 27 Jul 2021 11:13:06 +0300 Message-ID: <87v94wtbsd.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hi, Zhang Qilong writes: > The usb_add_gadget_udc will add a new gadget to the udc class > driver list. Not calling usb_del_gadget_udc in error branch > will result in residual gadget entry in the udc driver list. > We fix it by calling usb_del_gadget_udc to clean it when error > return. > > Fixes:48ba02b2e2b1a ("usb: gadget: add udc driver for max3420") > Signed-off-by: Zhang Qilong Thank you, Acked-by: Felipe Balbi -- balbi