From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B4F7C07E96 for ; Thu, 8 Jul 2021 14:58:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 26D9F61279 for ; Thu, 8 Jul 2021 14:58:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 26D9F61279 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1VUD-0003e7-9Y for qemu-devel@archiver.kernel.org; Thu, 08 Jul 2021 10:58:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47470) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1VSF-0000DT-De for qemu-devel@nongnu.org; Thu, 08 Jul 2021 10:56:43 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:22850) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1VSC-00015C-4S for qemu-devel@nongnu.org; Thu, 08 Jul 2021 10:56:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625756199; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rlhQYxcegNFp3YGNxTiYlLa80ewIdvgAKiVYN2QRzYA=; b=axRJBQOvL8Dp04z1oDbl08fnh2qORvA0rsszHuMLjDB5RFXNlfA7JT2I8nLMt45OMIm/91 DEMWfqlgGXqvKffYpRKkxPloIkyAFF8Eehvf3zbCHnkzirz6GgWYvX2eKlMTbbe34TOPh6 h7qSuA6N4E4xocVFBNqNrdidJYyTzi0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-378-bbTM7aa8Ny6k0oRNELIgdw-1; Thu, 08 Jul 2021 10:56:36 -0400 X-MC-Unique: bbTM7aa8Ny6k0oRNELIgdw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C8D0A939 for ; Thu, 8 Jul 2021 14:56:35 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-104.ams2.redhat.com [10.36.112.104]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4754C60C13; Thu, 8 Jul 2021 14:56:32 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id D55D91132B52; Thu, 8 Jul 2021 16:56:29 +0200 (CEST) From: Markus Armbruster To: Thomas Huth Subject: Re: [RFC PATCH] audio: Make the AudiodevDriver enum conditional References: <20210624183716.515721-1-thuth@redhat.com> <4c27da0d-ef3c-c1da-0d80-d8496292b85c@redhat.com> Date: Thu, 08 Jul 2021 16:56:29 +0200 In-Reply-To: <4c27da0d-ef3c-c1da-0d80-d8496292b85c@redhat.com> (Thomas Huth's message of "Fri, 25 Jun 2021 10:45:44 +0200") Message-ID: <87v95kdfc2.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.45, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eric Blake , "Daniel P. =?utf-8?Q?Berrang=C3=A9?=" , qemu-devel@nongnu.org, Gerd Hoffmann Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Thomas Huth writes: > On 25/06/2021 10.30, Daniel P. Berrang=C3=A9 wrote: >> On Thu, Jun 24, 2021 at 08:37:16PM +0200, Thomas Huth wrote: >>> This way, the upper layers like libvirt could have the possibility >>> to use QAPI to find out which audio drivers have been enabled during >>> compile-time of QEMU. >>> >>> Signed-off-by: Thomas Huth >>> --- >>> Note: Marked as RFC since it's quite a lot of ifdef'ing here... >>> not sure whether I really like it... >> Same as my patch here: >> https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg00654.html > > Oh, nice, I guess it means that it's not such a bad idea to introduce > all those #ifdefs here :-) > > Anyway, looks like my patch was incomplete anyway (I just hacked it > together after my corresponding DisplayType patch - see=20 > https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg06529.html), > since it lacks the wiring via a qapi command, so please disregard this > RFC PATCH. Are you going to respin your series from March, Daniel? I reviewed Daniel's series back then, and pointed out a few minor issues, mostly in commit messages. I hope that wasn't the reason for it getting stuck :)