From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79854C433ED for ; Thu, 15 Apr 2021 14:57:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1A0DF6141B for ; Thu, 15 Apr 2021 14:57:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A0DF6141B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43906 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lX3QW-0008C1-4m for qemu-devel@archiver.kernel.org; Thu, 15 Apr 2021 10:57:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42166) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lX3P8-00071D-Vo for qemu-devel@nongnu.org; Thu, 15 Apr 2021 10:55:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:50568) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lX3P7-0002Vr-Bf for qemu-devel@nongnu.org; Thu, 15 Apr 2021 10:55:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618498536; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jQamOzTdeEQxg1fRqjSZav8WCzE4gUYGj8a1QsxzlX0=; b=XJZBKHHC+GP4n3In1kjBh16BRNUCWgDNnX6znAmwEiPb7sdhcG4vxsFnlxaWTgW8mYdT1X Q6TAt4emd1tTyKp6OJ7HfduPykOkTdIMohm4B5HBAGK0NNy4zluBb4UUp+EkIDGvnnyLw3 X61a4K4pwB2ghhn0qBUU+Fog7eJPt1s= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-165-8k-RVlaRPtCLEa2kP0MEvg-1; Thu, 15 Apr 2021 10:55:32 -0400 X-MC-Unique: 8k-RVlaRPtCLEa2kP0MEvg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7591983DD20; Thu, 15 Apr 2021 14:55:31 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-114-17.ams2.redhat.com [10.36.114.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4491560D08; Thu, 15 Apr 2021 14:55:30 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id BA67E113525D; Thu, 15 Apr 2021 16:55:28 +0200 (CEST) From: Markus Armbruster To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: tidying up osdep.h References: <9f580695-b88a-7f4e-6e84-cfd3eed0914e@redhat.com> Date: Thu, 15 Apr 2021 16:55:28 +0200 In-Reply-To: <9f580695-b88a-7f4e-6e84-cfd3eed0914e@redhat.com> ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Thu, 15 Apr 2021 10:59:31 +0200") Message-ID: <87v98nbnrz.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=216.205.24.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Daniel P. Berrange" , QEMU Developers , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Philippe Mathieu-Daud=C3=A9 writes: > On 4/14/21 9:17 PM, Peter Maydell wrote: >> (cc'ing people related to the recent 'extern "C"' patches and also >> randomly Markus as somebody who's had opinions on header cleanups >> in the past...) >>=20 >> osdep.h as it stands today is a mix of two things: >> (1) it has the "must be included by everybody" items: >> (a) config-host.h, poison.h, compiler.h >> (b) things which must be done before any system header is included >> (like defining __STDC_CONSTANT_MACROS or WIN32_LEAN_AND_MEAN) >> (c) includes of system headers which we need to then fix up for >> portability issues (eg redefining assert on mingw, defining >> fallback versions of missing macros) >> (2) it has declarations for a library of QEMU functions, some of which >> typically wrap and abstract away OS specifics (like qemu_create(), >> qemu_unlink()), and some of which seem to have just been dumped >> in here for convenience (like qemu_hw_version()) >>=20 >> Every file needs (1), which is why we mandate osdep.h as the first >> include; most files don't need a lot of the things in (2) (for instance >> qemu_hw_version() is used in just half a dozen .c files). Is it worth >> trying to split some of the type (2) items out into their own header fil= es? >>=20 >> I suspect that the advantages would be primarily just making osdep.h >> a bit clearer to read and less of an "attractive nuisance" for new >> additions; I imagine the bulk of the extra compilation time represented >> by osdep.h is going to be because it pulls in dozens of system >> headers, most of which are going to be required under heading (1). > > What about: > > - extract qemu_hw_version() to "qemu/legacy_api.h"? > > - extract (1) from osdep.h as osinc.h (because described as > "OS includes and handling of OS dependencies")? > Or KISS as "qemu-first-include.h"... For what it's worth, the autoconf convention is to call it "config.h". > - osdep.h now contains the declarations for osdep.c > > Regards, > > Phil.