From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Lorenzo Bianconi <lorenzo@kernel.org>, linux-wireless@vger.kernel.org
Cc: johannes@sipsolutions.net
Subject: Re: [PATCH mac80211] mac80211: check if atf has been disabled in __ieee80211_schedule_txq
Date: Sat, 26 Dec 2020 16:51:08 +0100 [thread overview]
Message-ID: <87v9cozhub.fsf@toke.dk> (raw)
In-Reply-To: <93889406c50f1416214c079ca0b8c9faecc5143e.1608975195.git.lorenzo@kernel.org>
Lorenzo Bianconi <lorenzo@kernel.org> writes:
> Check if atf has been disabled in __ieee80211_schedule_txq() in order to
> avoid a given sta is always put to the beginning of the active_txqs list
> and never moved to the end since deficit is not decremented in
> ieee80211_sta_register_airtime()
>
> Fixes: b4809e9484da1 ("mac80211: Add airtime accounting and scheduling to TXQs")
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
> ---
> net/mac80211/tx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
> index 56a4d0d20a26..fa69644a14f9 100644
> --- a/net/mac80211/tx.c
> +++ b/net/mac80211/tx.c
> @@ -3836,7 +3836,7 @@ void __ieee80211_schedule_txq(struct ieee80211_hw *hw,
> * get immediately moved to the back of the list on the next
> * call to ieee80211_next_txq().
> */
> - if (txqi->txq.sta &&
> + if (txqi->txq.sta && local->airtime_flags &&
> wiphy_ext_feature_isset(local->hw.wiphy,
> NL80211_EXT_FEATURE_AIRTIME_FAIRNESS))
> list_add(&txqi->schedule_order,
> --
> 2.29.2
prev parent reply other threads:[~2020-12-26 15:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-26 9:39 [PATCH mac80211] mac80211: check if atf has been disabled in __ieee80211_schedule_txq Lorenzo Bianconi
2020-12-26 15:51 ` Toke Høiland-Jørgensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9cozhub.fsf@toke.dk \
--to=toke@toke.dk \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.