From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Ville Syrjälä" <ville.syrjala@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 05/11] drm/i915: refactor some crtc code out of intel display.
Date: Wed, 16 Dec 2020 14:18:01 +0200 [thread overview]
Message-ID: <87v9d23pxi.fsf@intel.com> (raw)
In-Reply-To: <X9nzGCAqpRWDCMh5@intel.com>
On Wed, 16 Dec 2020, Ville Syrjälä <ville.syrjala@intel.com> wrote:
> On Wed, Dec 16, 2020 at 12:03:37PM +0200, Jani Nikula wrote:
>> On Fri, 11 Dec 2020, Dave Airlie <airlied@gmail.com> wrote:
>> > From: Dave Airlie <airlied@redhat.com>
>> >
>> > There may be more crtc code that can be pulled out, but this
>> > is a good start.
>> >
>> > RFC: maybe call the new file something different
>>
>> I checked this is just code movement. I did clean up intel_crtc.h
>> locally a bit though. (I'll probably re-send the series with a few fixes
>> to pass CI.)
>>
>> I'm not averse to renaming the file later if needed, I'm more concerned
>> about choosing a meaningful bunch of functions to take out and put in
>> the new file.
>>
>> Ville, I saw you had some comments about this - is this making sensible
>> progress or making further refactoring harder?
>
> Just means we have to move 90% of the proposed intel_crtc.c
> into i9xx_plane.c again. So the plane bits here are just
> pointless churn IMO.
Fair enough. I just don't want to stall on this again like we've stalled
every time there's been proposals to clean up intel_display.c. And it's
always about some things that could be moved to a different file or
grouped differently or something. I'm pretty close to a point where I'll
take *anything* to chop up the file, and then we'll have better clarity
with smaller files when the dust settles.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-12-16 12:18 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 7:29 [Intel-gfx] [RFC v3] refactor intel display a bit more Dave Airlie
2020-12-11 7:29 ` [Intel-gfx] [PATCH 01/11] drm/i915/display: move needs_modeset to an inline in header Dave Airlie
2020-12-11 7:29 ` [Intel-gfx] [PATCH 02/11] drm/i915/display: move to_intel_frontbuffer to header Dave Airlie
2020-12-11 7:29 ` [Intel-gfx] [PATCH 03/11] drm/i915/display: fix misused comma Dave Airlie
2020-12-11 7:29 ` [Intel-gfx] [PATCH 04/11] drm/i915: refactor cursor code out of i915_display.c Dave Airlie
2020-12-16 10:05 ` Jani Nikula
2020-12-11 7:29 ` [Intel-gfx] [PATCH 05/11] drm/i915: refactor some crtc code out of intel display Dave Airlie
2020-12-16 10:03 ` Jani Nikula
2020-12-16 11:44 ` Ville Syrjälä
2020-12-16 12:18 ` Jani Nikula [this message]
2020-12-11 7:29 ` [Intel-gfx] [PATCH 06/11] drm/i915: refactor pll code out into intel_dpll.c Dave Airlie
2020-12-16 10:31 ` Jani Nikula
2020-12-11 7:29 ` [Intel-gfx] [PATCH 07/11] drm/i915: split fdi code out from intel_display.c Dave Airlie
2020-12-16 10:38 ` Jani Nikula
2020-12-11 7:29 ` [Intel-gfx] [PATCH 08/11] drm/i915: migrate hsw fdi code to new file Dave Airlie
2020-12-16 11:07 ` Jani Nikula
2020-12-11 7:29 ` [Intel-gfx] [PATCH 09/11] drm/i915: migrate skl planes code " Dave Airlie
2020-12-11 16:53 ` kernel test robot
2020-12-11 16:53 ` kernel test robot
2020-12-11 22:00 ` kernel test robot
2020-12-11 22:00 ` kernel test robot
2020-12-11 22:19 ` kernel test robot
2020-12-11 22:19 ` kernel test robot
2020-12-11 22:19 ` [Intel-gfx] [RFC PATCH] drm/i915: skl_plane_ctl_crtc() can be static kernel test robot
2020-12-11 22:19 ` kernel test robot
2020-12-11 7:29 ` [Intel-gfx] [PATCH 10/11] drm/i915: move pipe update code into crtc Dave Airlie
2020-12-11 7:29 ` [Intel-gfx] [PATCH 11/11] drm/i915: split fb scalable checks into g4x and skl versions Dave Airlie
2020-12-11 7:58 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [01/11] drm/i915/display: move needs_modeset to an inline in header Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9d23pxi.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.