From: Felipe Balbi <balbi@kernel.org>
To: Luo Jiaxing <luojiaxing@huawei.com>,
akpm@linux-foundation.org, viro@zeniv.linux.org.uk,
andriy.shevchenko@linux.intel.com
Cc: linux-kernel@vger.kernel.org, martin.petersen@oracle.com,
john.garry@huawei.com, himanshu.madhani@cavium.com,
gregkh@linuxfoundation.org, uma.shankar@intel.com,
anshuman.gupta@intel.com, animesh.manna@intel.com,
linux-usb@vger.kernel.org, linux-scsi@vger.kernel.org,
linuxarm@huawei.com
Subject: Re: [PATCH v2 4/5] usb: dwc3: debugfs: Introduce DEFINE_SHOW_STORE_ATTRIBUTE
Date: Fri, 30 Oct 2020 10:59:18 +0200 [thread overview]
Message-ID: <87v9esks2h.fsf@kernel.org> (raw)
In-Reply-To: <1604046722-15531-5-git-send-email-luojiaxing@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 813 bytes --]
Luo Jiaxing <luojiaxing@huawei.com> writes:
> Seq instroduce a new helper marco DEFINE_SHOW_STORE_ATTRIBUTE for
^^^^^^^^^^ ^^^^^
introduce macro
> Read-Write file, So we apply it at dwc3 debugfs to reduce some duplicate
^^ ^^^^^^^^^
so duplicated
> code.
to be fair, your commit is doing more than what it claims. Maybe update
commit log with a "while at that, also use DEFINE_SHOW_ATTRIBUTE() where
possible".
> Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com>
other than that, this looks okay. Since it depends on the definition of
DEFINE_SHOW_STORE_ATTRIBUTE:
Acked-by: Felipe Balbi <balbi@kernel.org>
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
next prev parent reply other threads:[~2020-10-30 8:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 8:31 [PATCH v2 0/5] Introduce a new helper marco DEFINE_SHOW_STORE_ATTRIBUTE at seq_file.c Luo Jiaxing
2020-10-30 8:31 ` [PATCH v2 1/5] seq_file: Introduce DEFINE_SHOW_STORE_ATTRIBUTE() helper macro Luo Jiaxing
2020-10-30 8:31 ` [PATCH v2 2/5] scsi: hisi_sas: Introduce DEFINE_SHOW_STORE_ATTRIBUTE for debugfs Luo Jiaxing
2020-10-30 8:32 ` [PATCH v2 3/5] scsi: qla2xxx: " Luo Jiaxing
2020-10-31 8:45 ` kernel test robot
2020-10-31 8:45 ` kernel test robot
2020-10-30 8:32 ` [PATCH v2 4/5] usb: dwc3: debugfs: Introduce DEFINE_SHOW_STORE_ATTRIBUTE Luo Jiaxing
2020-10-30 8:59 ` Felipe Balbi [this message]
2020-10-30 8:32 ` [PATCH v2 5/5] drm/i915/display: Introduce DEFINE_SHOW_STORE_ATTRIBUTE for debugfs Luo Jiaxing
2020-10-31 11:06 ` kernel test robot
2020-10-31 11:06 ` kernel test robot
2020-10-30 8:44 ` [PATCH v2 0/5] Introduce a new helper marco DEFINE_SHOW_STORE_ATTRIBUTE at seq_file.c Greg KH
2020-11-03 8:19 ` luojiaxing
2020-11-03 8:27 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9esks2h.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=animesh.manna@intel.com \
--cc=anshuman.gupta@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=himanshu.madhani@cavium.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=luojiaxing@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=uma.shankar@intel.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.