From: Nathan Lynch <nathanl@linux.ibm.com>
To: Scott Cheloha <cheloha@linux.ibm.com>, linuxppc-dev@ozlabs.org
Cc: Laurent Dufour <ldufour@linux.vnet.ibm.com>,
Michal Suchanek <msuchanek@suse.de>,
David Hildenbrand <david@redhat.com>,
Rick Lindsley <ricklind@linux.vnet.ibm.com>
Subject: Re: [PATCH v3] pseries/drmem: don't cache node id in drmem_lmb struct
Date: Fri, 14 Aug 2020 14:31:01 -0500 [thread overview]
Message-ID: <87v9hlxbwq.fsf@linux.ibm.com> (raw)
In-Reply-To: <87y2mhxhls.fsf@linux.ibm.com>
Nathan Lynch <nathanl@linux.ibm.com> writes:
> I'm satisfied that this change does not reintroduce that problem. The
> removal path still derives the node without going to the device tree,
> but now performs a more efficient lookup.
Er, actually it's slightly less efficient in the remove path, as you
note in your commit message. This doesn't alter my opinion of the
change. The higher-level algorithmic inefficiencies (e.g. all the
for_each_drmem_lmb loops) in this code are more of a concern.
next prev parent reply other threads:[~2020-08-14 19:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 1:51 [PATCH v3] pseries/drmem: don't cache node id in drmem_lmb struct Scott Cheloha
2020-08-14 17:27 ` Nathan Lynch
2020-08-14 19:31 ` Nathan Lynch [this message]
2020-08-21 8:33 ` Laurent Dufour
2020-09-10 18:28 ` Scott Cheloha
2020-09-09 13:27 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9hlxbwq.fsf@linux.ibm.com \
--to=nathanl@linux.ibm.com \
--cc=cheloha@linux.ibm.com \
--cc=david@redhat.com \
--cc=ldufour@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=msuchanek@suse.de \
--cc=ricklind@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.