From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD276C35671 for ; Sun, 23 Feb 2020 08:56:27 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9F40220656 for ; Sun, 23 Feb 2020 08:56:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LRnCLGHM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F40220656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j5n3N-0007K5-HY; Sun, 23 Feb 2020 08:55:57 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j5n3L-0007K0-SO for xen-devel@lists.xenproject.org; Sun, 23 Feb 2020 08:55:55 +0000 X-Inumbo-ID: 4d2bb193-561a-11ea-89e2-12813bfff9fa Received: from us-smtp-1.mimecast.com (unknown [205.139.110.120]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 4d2bb193-561a-11ea-89e2-12813bfff9fa; Sun, 23 Feb 2020 08:55:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582448155; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iD8dLw9qomGN6w1NHtW9KjOAj02GgFIgkJJercvcAPE=; b=LRnCLGHMHyYV9QsA27kMccLY1fOZiHkci/1QpBzstTfStygnD9DTalg55VFgJv4VfjFAMW 8g+REtFYgmLifrN7rm5PgNlRJbTJ1c4OFlH6+g1V38Gqx1NrGy8XB+P0laKXFkrYitQXPk GNVgyP7o8h/zkNDmEDcpx82JL4iN9ZY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-144-HNaFP9EAOsGTkhIbjq0DfQ-1; Sun, 23 Feb 2020 03:55:49 -0500 X-MC-Unique: HNaFP9EAOsGTkhIbjq0DfQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1281A1007269; Sun, 23 Feb 2020 08:55:48 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-129.ams2.redhat.com [10.36.116.129]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7BC231001902; Sun, 23 Feb 2020 08:55:38 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id F0F7411386A6; Sun, 23 Feb 2020 09:55:36 +0100 (CET) From: Markus Armbruster To: Vladimir Sementsov-Ogievskiy References: <20200131130118.1716-1-vsementsov@virtuozzo.com> <20200131130118.1716-4-vsementsov@virtuozzo.com> Date: Sun, 23 Feb 2020 09:55:36 +0100 In-Reply-To: <20200131130118.1716-4-vsementsov@virtuozzo.com> (Vladimir Sementsov-Ogievskiy's message of "Fri, 31 Jan 2020 16:01:10 +0300") Message-ID: <87v9nxwulz.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: Re: [Xen-devel] [PATCH v7 03/11] scripts: add coccinelle script to use auto propagated errp X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Stefano Stabellini , Michael Roth , qemu-block@nongnu.org, Paul Durrant , Laszlo Ersek , qemu-devel@nongnu.org, Greg Kurz , Gerd Hoffmann , Stefan Hajnoczi , Anthony Perard , xen-devel@lists.xenproject.org, Max Reitz , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , armbru@redhat.com, Stefan Berger Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" VmxhZGltaXIgU2VtZW50c292LU9naWV2c2tpeSA8dnNlbWVudHNvdkB2aXJ0dW96em8uY29tPiB3 cml0ZXM6Cgo+IFNjcmlwdCBhZGRzIEVSUlBfQVVUT19QUk9QQUdBVEUgbWFjcm8gaW52b2NhdGlv biB3aGVyZSBhcHByb3ByaWF0ZSBhbmQKPiBkb2VzIGNvcnJlc3BvbmRpbmcgY2hhbmdlcyBpbiBj b2RlIChsb29rIGZvciBkZXRhaWxzIGluCj4gaW5jbHVkZS9xYXBpL2Vycm9yLmgpCj4KPiBVc2Fn ZSBleGFtcGxlOgo+IHNwYXRjaCAtLXNwLWZpbGUgc2NyaXB0cy9jb2NjaW5lbGxlL2F1dG8tcHJv cGFnYXRlZC1lcnJwLmNvY2NpIFwKPiAgLS1tYWNyby1maWxlIHNjcmlwdHMvY29jY2ktbWFjcm8t ZmlsZS5oIC0taW4tcGxhY2UgLS1uby1zaG93LWRpZmYgXAo+ICBibG9ja2Rldi1uYmQuYyBxZW11 LW5iZC5jIHtibG9jay9uYmQqLG5iZC8qLGluY2x1ZGUvYmxvY2svbmJkKn0uW2hjXQo+Cj4gU2ln bmVkLW9mZi1ieTogVmxhZGltaXIgU2VtZW50c292LU9naWV2c2tpeSA8dnNlbWVudHNvdkB2aXJ0 dW96em8uY29tPgo+IC0tLQo+Cj4gQ0M6IEVyaWMgQmxha2UgPGVibGFrZUByZWRoYXQuY29tPgo+ IENDOiBLZXZpbiBXb2xmIDxrd29sZkByZWRoYXQuY29tPgo+IENDOiBNYXggUmVpdHogPG1yZWl0 ekByZWRoYXQuY29tPgo+IENDOiBHcmVnIEt1cnogPGdyb3VnQGthb2Qub3JnPgo+IENDOiBTdGVm YW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+Cj4gQ0M6IEFudGhvbnkgUGVy YXJkIDxhbnRob255LnBlcmFyZEBjaXRyaXguY29tPgo+IENDOiBQYXVsIER1cnJhbnQgPHBhdWxA eGVuLm9yZz4KPiBDQzogU3RlZmFuIEhham5vY3ppIDxzdGVmYW5oYUByZWRoYXQuY29tPgo+IEND OiAiUGhpbGlwcGUgTWF0aGlldS1EYXVkw6kiIDxwaGlsbWRAcmVkaGF0LmNvbT4KPiBDQzogTGFz emxvIEVyc2VrIDxsZXJzZWtAcmVkaGF0LmNvbT4KPiBDQzogR2VyZCBIb2ZmbWFubiA8a3JheGVs QHJlZGhhdC5jb20+Cj4gQ0M6IFN0ZWZhbiBCZXJnZXIgPHN0ZWZhbmJAbGludXguaWJtLmNvbT4K PiBDQzogTWFya3VzIEFybWJydXN0ZXIgPGFybWJydUByZWRoYXQuY29tPgo+IENDOiBNaWNoYWVs IFJvdGggPG1kcm90aEBsaW51eC52bmV0LmlibS5jb20+Cj4gQ0M6IHFlbXUtYmxvY2tAbm9uZ251 Lm9yZwo+IENDOiB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKPgo+ICBpbmNsdWRlL3Fh cGkvZXJyb3IuaCAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDMgKwo+ICBzY3JpcHRzL2Nv Y2NpbmVsbGUvYXV0by1wcm9wYWdhdGVkLWVycnAuY29jY2kgfCAxNTggKysrKysrKysrKysrKysr KysrCj4gIDIgZmlsZXMgY2hhbmdlZCwgMTYxIGluc2VydGlvbnMoKykKPiAgY3JlYXRlIG1vZGUg MTAwNjQ0IHNjcmlwdHMvY29jY2luZWxsZS9hdXRvLXByb3BhZ2F0ZWQtZXJycC5jb2NjaQo+Cj4g ZGlmZiAtLWdpdCBhL2luY2x1ZGUvcWFwaS9lcnJvci5oIGIvaW5jbHVkZS9xYXBpL2Vycm9yLmgK PiBpbmRleCBiOTQ1MmQ0ODA2Li43OWY4ZTk1MjE0IDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvcWFw aS9lcnJvci5oCj4gKysrIGIvaW5jbHVkZS9xYXBpL2Vycm9yLmgKPiBAQCAtMTQxLDYgKzE0MSw5 IEBACj4gICAqICAgICAgICAgLi4uCj4gICAqICAgICB9Cj4gICAqCj4gKyAqIEZvciBtYXNzIGNv bnZlcnNpb24gdXNlIHNjcmlwdAo+ICsgKiAgIHNjcmlwdHMvY29jY2luZWxsZS9hdXRvLXByb3Bh Z2F0ZWQtZXJycC5jb2NjaQo+ICsgKgo+ICAgKgo+ICAgKiBSZWNlaXZlIGFuZCBhY2N1bXVsYXRl IG11bHRpcGxlIGVycm9ycyAoZmlyc3Qgb25lIHdpbnMpOgo+ICAgKiAgICAgRXJyb3IgKmVyciA9 IE5VTEwsICpsb2NhbF9lcnIgPSBOVUxMOwoKRXh0cmEgYmxhbmsgbGluZS4KCj4gZGlmZiAtLWdp dCBhL3NjcmlwdHMvY29jY2luZWxsZS9hdXRvLXByb3BhZ2F0ZWQtZXJycC5jb2NjaSBiL3Njcmlw dHMvY29jY2luZWxsZS9hdXRvLXByb3BhZ2F0ZWQtZXJycC5jb2NjaQo+IG5ldyBmaWxlIG1vZGUg MTAwNjQ0Cj4gaW5kZXggMDAwMDAwMDAwMC4uZmIwM2M4NzFjYgo+IC0tLSAvZGV2L251bGwKPiAr KysgYi9zY3JpcHRzL2NvY2NpbmVsbGUvYXV0by1wcm9wYWdhdGVkLWVycnAuY29jY2kKPiBAQCAt MCwwICsxLDE1OCBAQAo+ICsvLyBVc2UgRVJSUF9BVVRPX1BST1BBR0FURSAoc2VlIGluY2x1ZGUv cWFwaS9lcnJvci5oKQo+ICsvLwo+ICsvLyBDb3B5cmlnaHQgKGMpIDIwMjAgVmlydHVvenpvIElu dGVybmF0aW9uYWwgR21iSC4KPiArLy8KPiArLy8gVGhpcyBwcm9ncmFtIGlzIGZyZWUgc29mdHdh cmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vciBtb2RpZnkKPiArLy8gaXQgdW5kZXIg dGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBhcyBwdWJsaXNoZWQg YnkKPiArLy8gdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbjsgZWl0aGVyIHZlcnNpb24gMiBv ZiB0aGUgTGljZW5zZSwgb3IKPiArLy8gKGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lv bi4KPiArLy8KPiArLy8gVGhpcyBwcm9ncmFtIGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRo YXQgaXQgd2lsbCBiZSB1c2VmdWwsCj4gKy8vIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0 aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mCj4gKy8vIE1FUkNIQU5UQUJJTElUWSBv ciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUKPiArLy8gR05VIEdl bmVyYWwgUHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4KPiArLy8KPiArLy8gWW91IHNo b3VsZCBoYXZlIHJlY2VpdmVkIGEgY29weSBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vu c2UKPiArLy8gYWxvbmcgd2l0aCB0aGlzIHByb2dyYW0uICBJZiBub3QsIHNlZSA8aHR0cDovL3d3 dy5nbnUub3JnL2xpY2Vuc2VzLz4uCj4gKy8vCj4gKy8vIFVzYWdlIGV4YW1wbGU6Cj4gKy8vIHNw YXRjaCAtLXNwLWZpbGUgc2NyaXB0cy9jb2NjaW5lbGxlL2F1dG8tcHJvcGFnYXRlZC1lcnJwLmNv Y2NpIFwKPiArLy8gIC0tbWFjcm8tZmlsZSBzY3JpcHRzL2NvY2NpLW1hY3JvLWZpbGUuaCAtLWlu LXBsYWNlIC0tbm8tc2hvdy1kaWZmIFwKPiArLy8gIGJsb2NrZGV2LW5iZC5jIHFlbXUtbmJkLmMg e2Jsb2NrL25iZCosbmJkLyosaW5jbHVkZS9ibG9jay9uYmQqfS5baGNdCj4gKwo+ICtAcnVsZTBA Cj4gKy8vIEFkZCBpbnZvY2F0aW9uIHRvIGVycnAtZnVuY3Rpb25zIHdoZXJlIG5lY2Vzc2FyeQo+ ICsvLyBXZSBzaG91bGQgc2tpcCBmdW5jdGlvbnMgd2l0aCAiRXJyb3IgKmNvbnN0ICplcnJwIgo+ ICsvLyBwYXJhbWV0ZXIsIGJ1dCBob3cgdG8gZG8gaXQgd2l0aCBjb2NjaW5lbGxlPwo+ICsvLyBJ IGRvbid0IGtub3csIHNvLCBJIHNraXAgdGhlbSBieSBmdW5jdGlvbiBuYW1lIHJlZ2V4Lgo+ICsv LyBJdCdzIHNhZmU6IGlmIHdlIGRpZCBub3Qgc2tpcCBzb21lIGZ1bmN0aW9ucyB3aXRoCj4gKy8v ICJFcnJvciAqY29uc3QgKmVycnAiLCBFUlJQX0FVVE9fUFJPUEFHQVRFIGludm9jYXRpb24KPiAr Ly8gd2lsbCBmYWlsIHRvIGNvbXBpbGUsIGJlY2F1c2Ugb2YgY29uc3QgdmlvbGF0aW9uLgoKTm90 IHNraXBwaW5nIGEgZnVuY3Rpb24gd2Ugc2hvdWxkIHNraXAgZmFpbHMgdG8gY29tcGlsZS4KCldo YXQgYWJvdXQgc2tpcHBpbmcgYSBmdW5jdGlvbiB3ZSBzaG91bGQgbm90IHNraXA/Cgo+ICtpZGVu dGlmaWVyIGZuICF+ICJlcnJvcl9hcHBlbmRfLipfaGludCI7Cj4gK2lkZW50aWZpZXIgbG9jYWxf ZXJyLCBFUlJQOwoKQSBmZXcgb2Ygb3VyIGNvY2NpbmVsbGUgc2NyaXB0cyB1c2UgQUxMX0NBUFMg Zm9yIG1ldGEtdmFyaWFibGVzLiAgTW9zdApkb24ndC4gIEVpdGhlciBpcyBmaW5lIHdpdGggbWUu ICBNaXhpbmcgdGhlIHR3byBzdHlsZXMgZmVlbHMgYSBiaXQKY29uZnVzaW5nLCB0aG91Z2guCgo+ ICtAQAo+ICsKPiArIGZuKC4uLiwgRXJyb3IgKipFUlJQLCAuLi4pCj4gKyB7Cj4gKysgICBFUlJQ X0FVVE9fUFJPUEFHQVRFKCk7Cj4gKyAgICA8Ky4uLgo+ICsgICAgICAgIHdoZW4gIT0gRVJSUF9B VVRPX1BST1BBR0FURSgpOwo+ICsoCj4gKyAgICBlcnJvcl9hcHBlbmRfaGludChFUlJQLCAuLi4p Owo+ICt8Cj4gKyAgICBlcnJvcl9wcmVwZW5kKEVSUlAsIC4uLik7Cj4gK3wKPiArICAgIEVycm9y ICpsb2NhbF9lcnIgPSBOVUxMOwo+ICspCj4gKyAgICAuLi4rPgo+ICsgfQoKTWlzc2VzIGVycm9y X3ZwcmVwZW5kKCkuICBDdXJyZW50bHkgaGFybWxlc3MsIGJ1dCBhcyBsb25nIGFzIHdlIGNvbW1p dAp0aGUgc2NyaXB0LCB3ZSBiZXR0ZXIgbWFrZSBpdCBhcyByb2J1c3QgYXMgd2UgcmVhc29uYWJs eSBjYW4uCgpUaGUgcHJldmlvdXMgcGF0Y2ggZXhwbGFpbnMgdGhpcyBDb2NjaW5lbGxlIHNjcmlw dCdzIGludGVudDoKCiAgVG8gYWNoaWV2ZSB0aGVzZSBnb2FscywgbGF0ZXIgcGF0Y2hlcyB3aWxs IGFkZCBpbnZvY2F0aW9ucwogIG9mIHRoaXMgbWFjcm8gYXQgdGhlIHN0YXJ0IG9mIGZ1bmN0aW9u cyB3aXRoIGVpdGhlciB1c2UKICBlcnJvcl9wcmVwZW5kL2Vycm9yX2FwcGVuZF9oaW50IChzb2x2 aW5nIDEpIG9yIHdoaWNoIHVzZQogIGxvY2FsX2VycitlcnJvcl9wcm9wYWdhdGUgdG8gY2hlY2sg ZXJyb3JzLCBzd2l0Y2hpbmcgdGhvc2UKICBmdW5jdGlvbnMgdG8gdXNlICplcnJwIGluc3RlYWQg KHNvbHZpbmcgMiBhbmQgMykuCgpUaGlzIHJ1bGUgbWF0Y2hlcyAidXNlIGVycm9yX3ByZXBlbmQv ZXJyb3JfYXBwZW5kX2hpbnQiIGRpcmVjdGx5LiAgSXQKYXBwZWFycyB0byB1c2UgcHJlc2VuY2Ug b2YgYSBsb2NhbCBFcnJvciAqIHZhcmlhYmxlIGFzIHByb3h5IGZvciAidXNlCmxvY2FsX2Vycitl cnJvcl9wcm9wYWdhdGUgdG8gY2hlY2sgZXJyb3JzIi4gIEhtbS4KCldlIG9idmlvdXNseSBoYXZl IHN1Y2ggYSB2YXJpYWJsZSB3aGVuIHdlIHVzZSAibG9jYWxfZXJyK2Vycm9yX3Byb3BhZ2F0ZQp0 byBjaGVjayBlcnJvcnMiLiAgQnV0IHdlIGNvdWxkIGFsc28gaGF2ZSBzdWNoIHZhcmlhYmxlcyB3 aXRob3V0IHVzZSBvZgplcnJvcl9wcm9wYWdhdGUoKS4gIEluIGZhY3QsIGVycm9yLmggZG9jdW1l bnRzIHN1Y2ggdXNlOgoKICogQ2FsbCBhIGZ1bmN0aW9uIGFuZCByZWNlaXZlIGFuIGVycm9yIGZy b20gaXQ6CiAqICAgICBFcnJvciAqZXJyID0gTlVMTDsKICogICAgIGZvbyhhcmcsICZlcnIpOwog KiAgICAgaWYgKGVycikgewogKiAgICAgICAgIGhhbmRsZSB0aGUgZXJyb3IuLi4KICogICAgIH0K CndoZXJlICJoYW5kbGUgdGhlIGVycm9yIiBmcmVlcyBpdC4KCkkgZmlndXJlIHN1Y2ggdXNlcyB0 eXBpY2FsbHkgb2NjdXIgaW4gZnVuY3Rpb25zIHdpdGhvdXQgYW4gRXJyb3IgKiplcnJwCnBhcmFt ZXRlci4gIFRoaXMgcnVsZSBkb2Vzbid0IGFwcGx5IHRoZW4uICBCdXQgdGhleSBjb3VsZCBvY2N1 ciBldmVuIGluCmZ1bmN0aW9ucyB3aXRoIHN1Y2ggYSBwYXJhbWV0ZXIuICBDb25zaWRlcjoKCiAg ICB2b2lkIGZvbyhFcnJvciAqKmVycnApCiAgICB7CiAgICAgICAgRXJyb3IgKmVyciA9IE5VTEw7 CgogICAgICAgIGJhcigmZXJyKTsKICAgICAgICBpZiAoZXJyKSB7CiAgICAgICAgICAgIGVycm9y X2ZyZWUoZXJyKTsKICAgICAgICAgICAgZXJyb3Jfc2V0ZyhlcnJwLCAiY29tcGxldGVseSBkaWZm ZXJlbnQgZXJyb3IiKTsKICAgICAgICB9CiAgICB9CgpSZWFzb25hYmxlIGVub3VnaCB3aGVuIGJh cigpIGdpdmVzIHVzIGFuIGVycm9yIHRoYXQncyBtaXNsZWFkaW5nIGluIHRoaXMKY29udGV4dCwg aXNuJ3QgaXQ/CgpUaGUgc2NyaXB0IHRyYW5zZm9ybXMgaXQgbGlrZSB0aGlzOgoKICAgIHZvaWQg Zm9vKEVycm9yICoqZXJycCkKICAgIHsKICAgLSAgICBFcnJvciAqZXJyID0gTlVMTDsKICAgKyAg ICBFUlJQX0FVVE9fUFJPUEFHQVRFKCk7CgogICAtICAgIGJhcigmZXJyKTsKICAgLSAgICBpZiAo ZXJyKSB7CiAgIC0gICAgICAgIGVycm9yX2ZyZWUoZXJyKTsKICAgKyAgICBiYXIoZXJycCk7CiAg ICsgICAgaWYgKCplcnJwKSB7CiAgICsgICAgICAgIGVycm9yX2ZyZWVfZXJycChlcnJwKTsKICAg ICAgICAgICAgZXJyb3Jfc2V0ZyhlcnJwLCAiY29tcGxldGVseSBkaWZmZXJlbnQgZXJyb3IiKTsK ICAgICAgICB9CiAgICB9CgpVbndhbnRlZC4KCk5vdywgaWYgdGhpcyBzY3JpcHQgYXBwbGllZCBp biBqdXN0IGEgZmV3IGRvemVuIHBsYWNlcywgd2UgY291bGQgcmVseSBvbgpleWViYWxsaW5nIGl0 cyBvdXRwdXQgdG8gY2F0Y2ggdW53YW50ZWQgdHJhbnNmb3JtYXRpb25zLiAgU2luY2UgaXQKYXBw bGllcyBpbiBzbyBtYW55IG1vcmUsIEkgZG9uJ3QgZmVlbCBjb21mb3J0YWJsZSByZWx5aW5nIG9u IHJldmlld2VyCmV5ZWJhbGxzLgoKQ2FuIHdlIG1ha2UgcnVsZTAgZGlyZWN0bHkgbWF0Y2ggZXJy b3JfcHJvcGFnYXRlKGVycnAsIGxvY2FsX2VycikKc29tZWhvdz8KCkFub3RoZXIgb2JzZXJ2YXRp b246IHRoZSBydWxlIGRvZXMgbm90IG1hdGNoIGVycm9yX3JlcG9ydGZfZXJyKCkgYW5kCndhcm5f cmVwb3J0Zl9lcnIoKS4gIFRoZXNlIGNvbWJpbmUgZXJyb3JfcHJlcGVuZCgpLAplcnJvcl9yZXBv cnQoKS93YXJuX3JlcG9ydCgpIGFuZCBlcnJvcl9mcmVlKCksIGZvciBjb252ZW5pZW5jZS4gIERv bid0CnRoZWlyIHVzZXJzIG5lZWQgRVJSUF9BVVRPX1BST1BBR0FURSgpIGp1c3QgbGlrZSBlcnJv cl9wcmVwZW5kKCkncwp1c2Vycz8KCj4gKwo+ICtAQAo+ICsvLyBTd2l0Y2ggdW51c3VhbCAoRXJy b3IgKiopIHBhcmFtZXRlciBuYW1lcyB0byBlcnJwCj4gKy8vICh0aGlzIGlzIG5lY2Vzc2FyeSB0 byB1c2UgRVJSUF9BVVRPX1BST1BBR0FURSkuCgpQbGVhc2UgcHV0IHlvdXIgcnVsZSBjb21tZW50 cyByaWdodCBiZWZvcmUgdGhlIHJ1bGUsIGkuZS4gYmVmb3JlIHRoZQpALWxpbmUgaW50cm9kdWNp bmcgbWV0YXZhcmlhYmxlIGRlY2xhcmF0aW9ucywgbm90IGFmdGVyLiAgU2FtZQplbHNld2hlcmUu Cgo+ICtpZGVudGlmaWVyIHJ1bGUwLmZuOwo+ICtpZGVudGlmaWVyIHJ1bGUwLkVSUlAgIT0gZXJy cDsKPiArQEAKPiArCj4gKyBmbiguLi4sCj4gKy0gICBFcnJvciAqKkVSUlAKPiArKyAgIEVycm9y ICoqZXJycAo+ICsgICAgLC4uLikKPiArIHsKPiArICAgICA8Li4uCj4gKy0gICAgRVJSUAo+ICsr ICAgIGVycnAKPiArICAgICAuLi4+Cj4gKyB9CgpUaGlzIG5vcm1hbGl6ZXMgZXJycCBwYXJhbWV0 ZXIgbmFtaW5nLiAgSXQgbWF0Y2hlcyBleGFjdGx5IHdoZW4gcnVsZTAKbWF0Y2hlcyAoYW5kIGlu c2VydHMgRVJSUF9BVVRPX1BST1BBR0FURSgpKSBhbmQgdGhlIEVycm9yICoqIHBhcmFtZXRlcgpp cyB1bnVzdWFsLiAgR29vZC4KCj4gKwo+ICtAcnVsZTFACj4gKy8vIFdlIHdhbnQgdG8gcGF0Y2gg ZXJyb3IgcHJvcGFnYXRpb24gaW4gZnVuY3Rpb25zIHJlZ2FyZGxlc3Mgb2YKPiArLy8gd2hldGhl ciB0aGUgZnVuY3Rpb24gYWxyZWFkeSB1c2VzIEVSUlBfQVVUT19QUk9QQUdBVEUgcHJpb3IgdG8K PiArLy8gYXBwbHlpbmcgcnVsZTAsIGhlbmNlIHRoaXMgb25lIGRvZXMgbm90IGluaGVyaXQgZnJv bSBpdC4KCkknbSBub3Qgc3VyZSBJIGdldCB0aGlzIGNvbW1lbnQuICBMZXQncyBzZWUgd2hhdCB0 aGUgcnVsZSBkb2VzLgoKPiAraWRlbnRpZmllciBmbiAhfiAiZXJyb3JfYXBwZW5kXy4qX2hpbnQi Owo+ICtpZGVudGlmaWVyIGxvY2FsX2VycjsKPiArc3ltYm9sIGVycnA7Cj4gK0BACj4gKwo+ICsg Zm4oLi4uLCBFcnJvciAqKmVycnAsIC4uLikKPiArIHsKPiArICAgICA8Li4uCj4gKy0gICAgRXJy b3IgKmxvY2FsX2VyciA9IE5VTEw7Cj4gKyAgICAgLi4uPgo+ICsgfQoKcnVsZTEgbWF0Y2hlcyBs aWtlIHJ1bGUwLCBleGNlcHQgdGhlIEVycm9yICoqIHBhcmFtZXRlciBtYXRjaCBpcwp0aWdodGVu ZWQgZnJvbSBhbnkgQyBpZGVudGlmaWVyIHRvIHRoZSBDIGlkZW50aWZpZXIgZXJycCwgYW5kIHRo ZQpmdW5jdGlvbiBib2R5IG1hdGNoIHRpZ2h0ZW5lZCBmcm9tICJlaXRoZXIgdXNlCmVycm9yX3By ZXBlbmQvZXJyb3JfYXBwZW5kX2hpbnQgb3Igd2hpY2ggdXNlIGxvY2FsX2VycitlcnJvcl9wcm9w YWdhdGUKdG8gY2hlY2sgZXJyb3JzIiB0byBqdXN0IHRoZSBsYXR0ZXIuCgpJIGZpZ3VyZSB0aWdo dGVuaW5nIHRoZSBFcnJvciAqKiBwYXJhbWV0ZXIgbWF0Y2ggaGFzIG5vIGVmZmVjdCwgYmVjYXVz ZQp3ZSBhbHJlYWR5IG5vcm1hbGl6ZWQgdGhlIHBhcmFtZXRlciBuYW1lLgoKU28gcnVsZTEgZGVs ZXRlcyB2YXJpYWJsZSBsb2NhbF9lcnIgd2hlcmUgcnVsZTAgYXBwbGllZC4gIENvcnJlY3Q/Cgo+ ICsKPiArQEAKPiArLy8gSGFuZGxlIHBhdHRlcm4gd2l0aCBnb3RvLCBvdGhlcndpc2Ugd2UnbGwg ZmluaXNoIHVwCj4gKy8vIHdpdGggbGFiZWxzIGF0IGZ1bmN0aW9uIGVuZCB3aGljaCB3aWxsIG5v dCBjb21waWxlLgo+ICtpZGVudGlmaWVyIHJ1bGUxLmZuLCBydWxlMS5sb2NhbF9lcnI7Cj4gK2lk ZW50aWZpZXIgT1VUOwo+ICtAQAo+ICsKPiArIGZuKC4uLikKPiArIHsKPiArICAgICA8Li4uCj4g Ky0gICAgZ290byBPVVQ7Cj4gKysgICAgcmV0dXJuOwo+ICsgICAgIC4uLj4KPiArLSBPVVQ6Cj4g Ky0gICAgZXJyb3JfcHJvcGFnYXRlKGVycnAsIGxvY2FsX2Vycik7Cj4gKyB9CgpUaGlzIGlzIG9u ZSBzcGVjaWFsIGNhc2Ugb2YgZXJyb3JfcHJvcGFnYXRlKCkgZGVsZXRpb24uICBJdCBhZGRpdGlv bmFsbHkKZ2V0cyByaWQgb2YgYSBnb3RvIHdlIG5vIGxvbmdlciB3YW50LiAgRm9yIHRoZSBnZW5l cmFsIGNhc2UsIHNlZSBiZWxvdy4KClRoZSBydWxlIGFwcGxpZXMgb25seSB3aGVyZSBydWxlMSBq dXN0IGRlbGV0ZWQgdGhlIHZhcmlhYmxlLiAgVGh1cywgdGhlCnR3byBydWxlcyB3b3JrIGluIHRh bmRlbS4gIE1ha2VzIHNlbnNlLgoKPiArCj4gK0BACj4gK2lkZW50aWZpZXIgcnVsZTEuZm4sIHJ1 bGUxLmxvY2FsX2VycjsKClRoaXMgcnVsZSBhbHNvIHdvcmtzIGluIHRhbmRlbSB3aXRoIHJ1bGUx LgoKPiArZXhwcmVzc2lvbiBsaXN0IGFyZ3M7IC8vIHRvIHJlaW5kZW50IGVycm9yX3Byb3BhZ2F0 ZV9wcmVwZW5kCgpXaGF0IGlzIHRoZSBjb21tZW50IHRyeWluZyB0byB0ZWxsIG1lPwoKPiArQEAK PiArCj4gKyBmbiguLi4pCj4gKyB7Cj4gKyAgICAgPC4uLgo+ICsoCj4gKy0gICAgZXJyb3JfZnJl ZShsb2NhbF9lcnIpOwo+ICstICAgIGxvY2FsX2VyciA9IE5VTEw7Cj4gKysgICAgZXJyb3JfZnJl ZV9lcnJwKGVycnApOwoKUmVtaW5kZXI6CgogICAgc3RhdGljIGlubGluZSB2b2lkIGVycm9yX2Zy ZWVfZXJycChFcnJvciAqKmVycnApCiAgICB7CiAgICAgICAgYXNzZXJ0KGVycnAgJiYgKmVycnAp OwogICAgICAgIGVycm9yX2ZyZWUoKmVycnApOwogICAgICAgICplcnJwID0gTlVMTDsKICAgIH0K Ck5vdyBsZXQncyBleGFtaW5lIHRoZSBhY3R1YWwgY2hhbmdlLgoKVGhlIGFzc2VydGlvbidzIGZp cnN0IGhhbGYgdHJpdmlhbGx5IGhvbGRzLCBFUlJQX0FVVE9fUFJPUEFHQVRFKCkKZW5zdXJlcyBp dC4KClRoZSBzZWNvbmQgaGFsZiBpcyBuZXcuICBXZSBub3cgY3Jhc2ggd2hlbiB3ZSBoYXZlbid0 IHNldCBhbiBlcnJvci4gIFdoeQppcyB0aGlzIHNhZmU/ICBOb3RlIHRoYXQgZXJyb3JfZnJlZShs b2NhbF9lcnIpIGRvZXMgbm90aGluZyB3aGVuCiFsb2NhbF9lcnIuCgpUaGUgemFwcGluZyBvZiB0 aGUgdmFyaWFibGUgcG9pbnRpbmcgdG8gdGhlIEVycm9yIGp1c3QgZnJlZWQgaXMKdW5jaGFuZ2Vk LgoKPiArfAo+ICstICAgIGVycm9yX2ZyZWUobG9jYWxfZXJyKTsKPiArKyAgICBlcnJvcl9mcmVl X2VycnAoZXJycCk7CgpIZXJlLCB0aGUgemFwcGluZyBpcyBuZXcuICBaYXBwaW5nIGRhbmdsaW5n IHBvaW50ZXJzIGlzIG9idmlvdXNseSBzYWZlLgpOZWVkZWQsIG9yIGVsc2UgdGhlIGF1dG9tYXRp YyBlcnJvcl9wcm9wYWdhdGUoKSBkdWUgdG8KRVJSUF9BVVRPX1BST1BBR0FURSgpIHdvdWxkIHBy b3BhZ2F0ZSB0aGUgZGFuZ2xpbmcgcG9pbnRlci4KCj4gK3wKPiArLSAgICBlcnJvcl9yZXBvcnRf ZXJyKGxvY2FsX2Vycik7Cj4gKysgICAgZXJyb3JfcmVwb3J0X2VycnAoZXJycCk7CgpUaGUgb25s eSBkaWZmZXJlbmNlIHRvIHRoZSBwcmV2aW91cyBjYXNlIGlzIHRoYXQgd2UgYWxzbyByZXBvcnQg dGhlCmVycm9yLgoKVGhlIHByZXZpb3VzIGNhc2UgaGFzIGEgYnVkZHkgdGhhdCBhZGRpdGlvbmFs bHkgbWF0Y2hlcyAqZXJycCA9IE5VTEwuCldoeSBub3QgdGhpcyBvbmU/Cgo+ICt8Cj4gKy0gICAg d2Fybl9yZXBvcnRfZXJyKGxvY2FsX2Vycik7Cj4gKysgICAgd2Fybl9yZXBvcnRfZXJycChlcnJw KTsKCkxpa2V3aXNlLgoKV2hhdCBhYm91dCBlcnJvcl9yZXBvcnRmX2VycigpLCB3YXJuX3JlcG9y dGZfZXJyKCk/CgpVcCB0byBoZXJlLCB0aGlzIHJ1bGUgdHJhbnNmb3JtcyB0aGUgdmFyaW91cyBm b3JtcyBvZiBlcnJvcl9mcmVlKCkuCk5leHQ6IGVycm9yX3Byb3BhZ2F0ZSgpLgoKPiArfAo+ICst ICAgIGVycm9yX3Byb3BhZ2F0ZV9wcmVwZW5kKGVycnAsIGxvY2FsX2VyciwgYXJncyk7Cj4gKysg ICAgZXJyb3JfcHJlcGVuZChlcnJwLCBhcmdzKTsKPiArfAo+ICstICAgIGVycm9yX3Byb3BhZ2F0 ZShlcnJwLCBsb2NhbF9lcnIpOwoKcnVsZTAncyBhZGRpbmcgb2YgRVJSUF9BVVRPX1BST1BBR0FU RSgpIG1hZGUgZXJyb3JfcHJvcGFnYXRlKCkKcmVkdW5kYW50LgoKVGhpcyBpcyB0aGUgZ2VuZXJh bCBjYXNlIG9mIGVycm9yX3Byb3BhZ2F0ZSgpIGRlbGV0aW9uLgoKSSdkIHB1dCB0aGUgcGxhaW4g ZXJyb3JfcHJvcGFnYXRlKCkgZmlyc3QsIHZhcmlhdGlvbnMgc2Vjb25kLCBsaWtlIHlvdQpkbyB3 aXRoIGVycm9yX2ZyZWUoKS4KCklmIG5laXRoZXIgb2YgdGhlc2UgdHdvIHBhdHRlcm5zIG1hdGNo IG9uIGEgcGF0aCBmcm9tCkVSUlBfQVVUT19QUk9QQUdBVEUoKSB0byByZXR1cm4sIHdlIGVmZmVj dGl2ZWx5IGluc2VydCBlcnJvcl9wcm9wYWdhdGUoKQp3aGVyZSBpdCB3YXNuJ3QgYmVmb3JlLiAg RG9lcyBub3RoaW5nIHdoZW4gdGhlIGxvY2FsIGVycm9yIGlzIG51bGwKdGhlcmUuICBCdWcgZml4 IHdoZW4gaXQgaXNuJ3Q6IGl0J3MgYXQgbGVhc3QgYSBtZW1vcnkgbGVhaywgYW5kIHF1aXRlCnBv c3NpYmx5IHdvcnNlLgoKSWRlbnRpZnlpbmcgdGhlc2UgYnVnIGZpeGVzIHdvdWxkIGJlIG5pY2Us IGJ1dCBJIGRvbid0IGhhdmUgcHJhY3RpY2FsCmlkZWFzIG9uIGhvdyB0byBkbyB0aGF0LgoKQ2Fu IHdlIGV4cGxhaW4gdGhpcyBpbiB0aGUgY29tbWl0IG1lc3NhZ2U/Cgo+ICspCj4gKyAgICAgLi4u Pgo+ICsgfQo+ICsKPiArQEAKPiAraWRlbnRpZmllciBydWxlMS5mbiwgcnVsZTEubG9jYWxfZXJy Owo+ICtAQAo+ICsKPiArIGZuKC4uLikKPiArIHsKPiArICAgICA8Li4uCj4gKygKPiArLSAgICAm bG9jYWxfZXJyCj4gKysgICAgZXJycAo+ICt8Cj4gKy0gICAgbG9jYWxfZXJyCj4gKysgICAgKmVy cnAKPiArKQo+ICsgICAgIC4uLj4KPiArIH0KCkFsc28gaW4gdGFuZGVtIHdpdGggcnVsZTEsIGZp eGVzIHVwIHVzZXMgb2YgbG9jYWxfZXJyLiAgR29vZC4KCj4gKwo+ICtAQAo+ICtpZGVudGlmaWVy IHJ1bGUxLmZuOwo+ICtAQAo+ICsKPiArIGZuKC4uLikKPiArIHsKPiArICAgICA8Li4uCj4gKy0g KmVycnAgIT0gTlVMTAo+ICsrICplcnJwCj4gKyAgICAgLi4uPgo+ICsgfQoKU3RpbGwgaW4gdGFu ZGVtIHdpdGggcnVsZTEsIG5vcm1hbGl6ZXMgc3R5bGUuICBHb29kLgoKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QK WGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5v cmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48E92C35670 for ; Sun, 23 Feb 2020 08:57:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 03F5A20656 for ; Sun, 23 Feb 2020 08:57:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KjDLdlxf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03F5A20656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50892 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j5n4y-0007Cd-5p for qemu-devel@archiver.kernel.org; Sun, 23 Feb 2020 03:57:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48336) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j5n3R-0006I3-2i for qemu-devel@nongnu.org; Sun, 23 Feb 2020 03:56:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j5n3O-0001Wf-6f for qemu-devel@nongnu.org; Sun, 23 Feb 2020 03:56:00 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:35747 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j5n3O-0001TC-2g for qemu-devel@nongnu.org; Sun, 23 Feb 2020 03:55:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582448156; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iD8dLw9qomGN6w1NHtW9KjOAj02GgFIgkJJercvcAPE=; b=KjDLdlxfXvwc3NYqxAbTKaOj+76Zbo0+4gfqcZ9oSBPNMzDkPueGM04J4ykkveF9boxTR7 cMZ4SPDg1XBg4e5Nh4RTJxJUGzWltiRhchxgxnhCyD2HC5FiG4ghhAos+IvlQKlBkWK3RS 3gZtkqIKU2FzXuZWnceff43ItAXMTRA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-144-HNaFP9EAOsGTkhIbjq0DfQ-1; Sun, 23 Feb 2020 03:55:49 -0500 X-MC-Unique: HNaFP9EAOsGTkhIbjq0DfQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1281A1007269; Sun, 23 Feb 2020 08:55:48 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-129.ams2.redhat.com [10.36.116.129]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7BC231001902; Sun, 23 Feb 2020 08:55:38 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id F0F7411386A6; Sun, 23 Feb 2020 09:55:36 +0100 (CET) From: Markus Armbruster To: Vladimir Sementsov-Ogievskiy Subject: Re: [PATCH v7 03/11] scripts: add coccinelle script to use auto propagated errp References: <20200131130118.1716-1-vsementsov@virtuozzo.com> <20200131130118.1716-4-vsementsov@virtuozzo.com> Date: Sun, 23 Feb 2020 09:55:36 +0100 In-Reply-To: <20200131130118.1716-4-vsementsov@virtuozzo.com> (Vladimir Sementsov-Ogievskiy's message of "Fri, 31 Jan 2020 16:01:10 +0300") Message-ID: <87v9nxwulz.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Stefano Stabellini , Michael Roth , qemu-block@nongnu.org, Paul Durrant , Laszlo Ersek , qemu-devel@nongnu.org, Greg Kurz , Gerd Hoffmann , Stefan Hajnoczi , Anthony Perard , xen-devel@lists.xenproject.org, Max Reitz , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , armbru@redhat.com, Stefan Berger Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Vladimir Sementsov-Ogievskiy writes: > Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and > does corresponding changes in code (look for details in > include/qapi/error.h) > > Usage example: > spatch --sp-file scripts/coccinelle/auto-propagated-errp.cocci \ > --macro-file scripts/cocci-macro-file.h --in-place --no-show-diff \ > blockdev-nbd.c qemu-nbd.c {block/nbd*,nbd/*,include/block/nbd*}.[hc] > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > > CC: Eric Blake > CC: Kevin Wolf > CC: Max Reitz > CC: Greg Kurz > CC: Stefano Stabellini > CC: Anthony Perard > CC: Paul Durrant > CC: Stefan Hajnoczi > CC: "Philippe Mathieu-Daud=C3=A9" > CC: Laszlo Ersek > CC: Gerd Hoffmann > CC: Stefan Berger > CC: Markus Armbruster > CC: Michael Roth > CC: qemu-block@nongnu.org > CC: xen-devel@lists.xenproject.org > > include/qapi/error.h | 3 + > scripts/coccinelle/auto-propagated-errp.cocci | 158 ++++++++++++++++++ > 2 files changed, 161 insertions(+) > create mode 100644 scripts/coccinelle/auto-propagated-errp.cocci > > diff --git a/include/qapi/error.h b/include/qapi/error.h > index b9452d4806..79f8e95214 100644 > --- a/include/qapi/error.h > +++ b/include/qapi/error.h > @@ -141,6 +141,9 @@ > * ... > * } > * > + * For mass conversion use script > + * scripts/coccinelle/auto-propagated-errp.cocci > + * > * > * Receive and accumulate multiple errors (first one wins): > * Error *err =3D NULL, *local_err =3D NULL; Extra blank line. > diff --git a/scripts/coccinelle/auto-propagated-errp.cocci b/scripts/cocc= inelle/auto-propagated-errp.cocci > new file mode 100644 > index 0000000000..fb03c871cb > --- /dev/null > +++ b/scripts/coccinelle/auto-propagated-errp.cocci > @@ -0,0 +1,158 @@ > +// Use ERRP_AUTO_PROPAGATE (see include/qapi/error.h) > +// > +// Copyright (c) 2020 Virtuozzo International GmbH. > +// > +// This program is free software; you can redistribute it and/or modify > +// it under the terms of the GNU General Public License as published by > +// the Free Software Foundation; either version 2 of the License, or > +// (at your option) any later version. > +// > +// This program is distributed in the hope that it will be useful, > +// but WITHOUT ANY WARRANTY; without even the implied warranty of > +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +// GNU General Public License for more details. > +// > +// You should have received a copy of the GNU General Public License > +// along with this program. If not, see . > +// > +// Usage example: > +// spatch --sp-file scripts/coccinelle/auto-propagated-errp.cocci \ > +// --macro-file scripts/cocci-macro-file.h --in-place --no-show-diff \ > +// blockdev-nbd.c qemu-nbd.c {block/nbd*,nbd/*,include/block/nbd*}.[hc] > + > +@rule0@ > +// Add invocation to errp-functions where necessary > +// We should skip functions with "Error *const *errp" > +// parameter, but how to do it with coccinelle? > +// I don't know, so, I skip them by function name regex. > +// It's safe: if we did not skip some functions with > +// "Error *const *errp", ERRP_AUTO_PROPAGATE invocation > +// will fail to compile, because of const violation. Not skipping a function we should skip fails to compile. What about skipping a function we should not skip? > +identifier fn !~ "error_append_.*_hint"; > +identifier local_err, ERRP; A few of our coccinelle scripts use ALL_CAPS for meta-variables. Most don't. Either is fine with me. Mixing the two styles feels a bit confusing, though. > +@@ > + > + fn(..., Error **ERRP, ...) > + { > ++ ERRP_AUTO_PROPAGATE(); > + <+... > + when !=3D ERRP_AUTO_PROPAGATE(); > +( > + error_append_hint(ERRP, ...); > +| > + error_prepend(ERRP, ...); > +| > + Error *local_err =3D NULL; > +) > + ...+> > + } Misses error_vprepend(). Currently harmless, but as long as we commit the script, we better make it as robust as we reasonably can. The previous patch explains this Coccinelle script's intent: To achieve these goals, later patches will add invocations of this macro at the start of functions with either use error_prepend/error_append_hint (solving 1) or which use local_err+error_propagate to check errors, switching those functions to use *errp instead (solving 2 and 3). This rule matches "use error_prepend/error_append_hint" directly. It appears to use presence of a local Error * variable as proxy for "use local_err+error_propagate to check errors". Hmm. We obviously have such a variable when we use "local_err+error_propagate to check errors". But we could also have such variables without use of error_propagate(). In fact, error.h documents such use: * Call a function and receive an error from it: * Error *err =3D NULL; * foo(arg, &err); * if (err) { * handle the error... * } where "handle the error" frees it. I figure such uses typically occur in functions without an Error **errp parameter. This rule doesn't apply then. But they could occur even in functions with such a parameter. Consider: void foo(Error **errp) { Error *err =3D NULL; bar(&err); if (err) { error_free(err); error_setg(errp, "completely different error"); } } Reasonable enough when bar() gives us an error that's misleading in this context, isn't it? The script transforms it like this: void foo(Error **errp) { - Error *err =3D NULL; + ERRP_AUTO_PROPAGATE(); - bar(&err); - if (err) { - error_free(err); + bar(errp); + if (*errp) { + error_free_errp(errp); error_setg(errp, "completely different error"); } } Unwanted. Now, if this script applied in just a few dozen places, we could rely on eyeballing its output to catch unwanted transformations. Since it applies in so many more, I don't feel comfortable relying on reviewer eyeballs. Can we make rule0 directly match error_propagate(errp, local_err) somehow? Another observation: the rule does not match error_reportf_err() and warn_reportf_err(). These combine error_prepend(), error_report()/warn_report() and error_free(), for convenience. Don't their users need ERRP_AUTO_PROPAGATE() just like error_prepend()'s users? > + > +@@ > +// Switch unusual (Error **) parameter names to errp > +// (this is necessary to use ERRP_AUTO_PROPAGATE). Please put your rule comments right before the rule, i.e. before the @-line introducing metavariable declarations, not after. Same elsewhere. > +identifier rule0.fn; > +identifier rule0.ERRP !=3D errp; > +@@ > + > + fn(..., > +- Error **ERRP > ++ Error **errp > + ,...) > + { > + <... > +- ERRP > ++ errp > + ...> > + } This normalizes errp parameter naming. It matches exactly when rule0 matches (and inserts ERRP_AUTO_PROPAGATE()) and the Error ** parameter is unusual. Good. > + > +@rule1@ > +// We want to patch error propagation in functions regardless of > +// whether the function already uses ERRP_AUTO_PROPAGATE prior to > +// applying rule0, hence this one does not inherit from it. I'm not sure I get this comment. Let's see what the rule does. > +identifier fn !~ "error_append_.*_hint"; > +identifier local_err; > +symbol errp; > +@@ > + > + fn(..., Error **errp, ...) > + { > + <... > +- Error *local_err =3D NULL; > + ...> > + } rule1 matches like rule0, except the Error ** parameter match is tightened from any C identifier to the C identifier errp, and the function body match tightened from "either use error_prepend/error_append_hint or which use local_err+error_propagate to check errors" to just the latter. I figure tightening the Error ** parameter match has no effect, because we already normalized the parameter name. So rule1 deletes variable local_err where rule0 applied. Correct? > + > +@@ > +// Handle pattern with goto, otherwise we'll finish up > +// with labels at function end which will not compile. > +identifier rule1.fn, rule1.local_err; > +identifier OUT; > +@@ > + > + fn(...) > + { > + <... > +- goto OUT; > ++ return; > + ...> > +- OUT: > +- error_propagate(errp, local_err); > + } This is one special case of error_propagate() deletion. It additionally gets rid of a goto we no longer want. For the general case, see below. The rule applies only where rule1 just deleted the variable. Thus, the two rules work in tandem. Makes sense. > + > +@@ > +identifier rule1.fn, rule1.local_err; This rule also works in tandem with rule1. > +expression list args; // to reindent error_propagate_prepend What is the comment trying to tell me? > +@@ > + > + fn(...) > + { > + <... > +( > +- error_free(local_err); > +- local_err =3D NULL; > ++ error_free_errp(errp); Reminder: static inline void error_free_errp(Error **errp) { assert(errp && *errp); error_free(*errp); *errp =3D NULL; } Now let's examine the actual change. The assertion's first half trivially holds, ERRP_AUTO_PROPAGATE() ensures it. The second half is new. We now crash when we haven't set an error. Why is this safe? Note that error_free(local_err) does nothing when !local_err. The zapping of the variable pointing to the Error just freed is unchanged. > +| > +- error_free(local_err); > ++ error_free_errp(errp); Here, the zapping is new. Zapping dangling pointers is obviously safe. Needed, or else the automatic error_propagate() due to ERRP_AUTO_PROPAGATE() would propagate the dangling pointer. > +| > +- error_report_err(local_err); > ++ error_report_errp(errp); The only difference to the previous case is that we also report the error. The previous case has a buddy that additionally matches *errp =3D NULL. Why not this one? > +| > +- warn_report_err(local_err); > ++ warn_report_errp(errp); Likewise. What about error_reportf_err(), warn_reportf_err()? Up to here, this rule transforms the various forms of error_free(). Next: error_propagate(). > +| > +- error_propagate_prepend(errp, local_err, args); > ++ error_prepend(errp, args); > +| > +- error_propagate(errp, local_err); rule0's adding of ERRP_AUTO_PROPAGATE() made error_propagate() redundant. This is the general case of error_propagate() deletion. I'd put the plain error_propagate() first, variations second, like you do with error_free(). If neither of these two patterns match on a path from ERRP_AUTO_PROPAGATE() to return, we effectively insert error_propagate() where it wasn't before. Does nothing when the local error is null there. Bug fix when it isn't: it's at least a memory leak, and quite possibly worse. Identifying these bug fixes would be nice, but I don't have practical ideas on how to do that. Can we explain this in the commit message? > +) > + ...> > + } > + > +@@ > +identifier rule1.fn, rule1.local_err; > +@@ > + > + fn(...) > + { > + <... > +( > +- &local_err > ++ errp > +| > +- local_err > ++ *errp > +) > + ...> > + } Also in tandem with rule1, fixes up uses of local_err. Good. > + > +@@ > +identifier rule1.fn; > +@@ > + > + fn(...) > + { > + <... > +- *errp !=3D NULL > ++ *errp > + ...> > + } Still in tandem with rule1, normalizes style. Good.