From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hgj0X-0002Ms-Nz for ath10k@lists.infradead.org; Fri, 28 Jun 2019 05:01:11 +0000 From: Kalle Valo Subject: Re: [PATCH v2 16/27] net: remove unneeded memset References: <20190628024843.15635-1-huangfq.daxian@gmail.com> Date: Fri, 28 Jun 2019 08:00:54 +0300 In-Reply-To: <20190628024843.15635-1-huangfq.daxian@gmail.com> (Fuqian Huang's message of "Fri, 28 Jun 2019 10:48:31 +0800") Message-ID: <87v9wqqp6h.fsf@codeaurora.org> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Fuqian Huang Cc: Ronak Doshi , Sergey Matyukevich , "VMware, Inc." , Chris Snook , Chi-Hsien Lin , Arend van Spriel , linux-kernel@vger.kernel.org, Vishal Kulkarni , Samuel Chessman , =?utf-8?Q?Rafa=C5=82_Mi=C5=82ecki?= , netdev@vger.kernel.org, Avinash Patil , Thomas Gleixner , Manish Chopra , linux-rdma@vger.kernel.org, Will Deacon , Guo-Fu Tseng , Rahul Verma , ath10k@lists.infradead.org, brcm80211-dev-list@cypress.com, Saeed Mahameed , linux-hippi@sunsite.dk, Franky Lin , Yang Wei , Jes Sorensen , Jay Cliburn , YueHaibing , Hante Meuleman , Ido Schimmel , Hans de Goede , Jiri Pirko , Wright Feng , Michael Chan , zhong jiang , Allison Randal , Mirko Lindner , Igor Mitsyanko , brcm80211-dev-list.pdl@broadcom.com, GR-Linux-NIC-Dev@marvell.com, Fugang Duan , Leon Romanovsky , Greg Kroah-Hartman , linux-wireless@vger.kernel.org, Mao Wenan , Stephen Hemminger , Luis Chamberlain , Jon Mason , Andrey Shevchenko , Colin Ian King , "David S. Miller" , Tariq Toukan Fuqian Huang writes: > The memset with 0 after zeroing allocator is unneeded. > > pci_alloc_persistent calls dma_alloc_coherent directly. > In commit af7ddd8a627c > ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"), > dma_alloc_coherent has already zeroed the memory. > So the memset after these functions is unneeded. > > Signed-off-by: Fuqian Huang > --- > drivers/net/ethernet/atheros/atlx/atl1.c | 2 -- > drivers/net/ethernet/atheros/atlx/atl2.c | 1 - > drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 -- > drivers/net/ethernet/chelsio/cxgb4/sched.c | 1 - > drivers/net/ethernet/freescale/fec_main.c | 2 -- > drivers/net/ethernet/jme.c | 5 ----- > drivers/net/ethernet/marvell/skge.c | 2 -- > drivers/net/ethernet/mellanox/mlx4/eq.c | 2 -- > drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 1 - > drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 2 -- > drivers/net/ethernet/mellanox/mlxsw/pci.c | 1 - > drivers/net/ethernet/neterion/s2io.c | 1 - > drivers/net/ethernet/qlogic/netxen/netxen_nic_ctx.c | 3 --- > drivers/net/ethernet/ti/tlan.c | 1 - > drivers/net/hippi/rrunner.c | 2 -- > drivers/net/vmxnet3/vmxnet3_drv.c | 1 - > drivers/net/wireless/ath/ath10k/ce.c | 5 ----- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 2 -- > drivers/net/wireless/quantenna/qtnfmac/pcie/pearl_pcie.c | 2 -- > drivers/net/wireless/quantenna/qtnfmac/pcie/topaz_pcie.c | 2 -- For the wireless part: Acked-by: Kalle Valo I assume Dave will take this. -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH v2 16/27] net: remove unneeded memset Date: Fri, 28 Jun 2019 08:00:54 +0300 Message-ID: <87v9wqqp6h.fsf@codeaurora.org> References: <20190628024843.15635-1-huangfq.daxian@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190628024843.15635-1-huangfq.daxian@gmail.com> (Fuqian Huang's message of "Fri, 28 Jun 2019 10:48:31 +0800") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath10k" Errors-To: ath10k-bounces+gldad-ath10k=m.gmane.org@lists.infradead.org To: Fuqian Huang Cc: Ronak Doshi , Sergey Matyukevich , "VMware, Inc." , Chris Snook , Chi-Hsien Lin , Arend van Spriel , linux-kernel@vger.kernel.org, Vishal Kulkarni , Samuel Chessman , =?utf-8?Q?Rafa=C5=82_Mi=C5=82ecki?= , netdev@vger.kernel.org, Avinash Patil , Thomas Gleixner , Manish Chopra , linux-rdma@vger.kernel.org, Will Deacon , Guo-Fu Tseng , Rahul Verma , ath10k@lists.infradead.org, brcm80211-dev-list@cypress.com, Saeed Mahameed , linux-hippi@sunsite.dk, Franky Lin , Yang Wei , Jes List-Id: linux-rdma@vger.kernel.org Fuqian Huang writes: > The memset with 0 after zeroing allocator is unneeded. > > pci_alloc_persistent calls dma_alloc_coherent directly. > In commit af7ddd8a627c > ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"), > dma_alloc_coherent has already zeroed the memory. > So the memset after these functions is unneeded. > > Signed-off-by: Fuqian Huang > --- > drivers/net/ethernet/atheros/atlx/atl1.c | 2 -- > drivers/net/ethernet/atheros/atlx/atl2.c | 1 - > drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 -- > drivers/net/ethernet/chelsio/cxgb4/sched.c | 1 - > drivers/net/ethernet/freescale/fec_main.c | 2 -- > drivers/net/ethernet/jme.c | 5 ----- > drivers/net/ethernet/marvell/skge.c | 2 -- > drivers/net/ethernet/mellanox/mlx4/eq.c | 2 -- > drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 1 - > drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 2 -- > drivers/net/ethernet/mellanox/mlxsw/pci.c | 1 - > drivers/net/ethernet/neterion/s2io.c | 1 - > drivers/net/ethernet/qlogic/netxen/netxen_nic_ctx.c | 3 --- > drivers/net/ethernet/ti/tlan.c | 1 - > drivers/net/hippi/rrunner.c | 2 -- > drivers/net/vmxnet3/vmxnet3_drv.c | 1 - > drivers/net/wireless/ath/ath10k/ce.c | 5 ----- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 2 -- > drivers/net/wireless/quantenna/qtnfmac/pcie/pearl_pcie.c | 2 -- > drivers/net/wireless/quantenna/qtnfmac/pcie/topaz_pcie.c | 2 -- For the wireless part: Acked-by: Kalle Valo I assume Dave will take this. -- Kalle Valo