From: Vladislav Ivanishin <vlad@ispras.ru>
To: kbd@lists.altlinux.org
Subject: [kbd] [Lint][Bug report] src/openvt.c:386: 'pid' may be used uninitialized
Date: Tue, 11 Jun 2019 21:20:04 +0300 [thread overview]
Message-ID: <87v9xcugq3.fsf@ispras.ru> (raw)
Hi,
I've found this bug using a static analyzer (slightly improved GCC).
Consider variable `pid` in function main from src/openvt.c:
src/openvt.c:166: int opt, pid, i;
src/openvt.c:303: if (direct_exec || ((pid = fork()) == 0)) {
src/openvt.c:386: if (pid < 0)
src/openvt.c:393: waitpid(pid, &retval, 0);
If direct_exec is TRUE, then pid doesn't get initialized, but it is used
outside the conditional regardless of that.
--
Vlad
next reply other threads:[~2019-06-11 18:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 18:20 Vladislav Ivanishin [this message]
2019-06-20 8:59 ` [kbd] [Lint][Bug report] src/openvt.c:386: 'pid' may be used uninitialized Alexey Gladkov
2019-07-11 18:03 ` Vladislav Ivanishin
2019-07-11 19:22 ` Alexey Gladkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9xcugq3.fsf@ispras.ru \
--to=vlad@ispras.ru \
--cc=kbd@lists.altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.