From: Kalle Valo <kvalo@codeaurora.org>
To: Tony Chuang <yhchuang@realtek.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 01/11] rtw88: resolve order of tx power setting routines
Date: Thu, 30 May 2019 07:59:34 +0300 [thread overview]
Message-ID: <87v9xspmfd.fsf@codeaurora.org> (raw)
In-Reply-To: <F7CD281DE3E379468C6D07993EA72F84D17FABBF@RTITMBSVM04.realtek.com.tw> (Tony Chuang's message of "Thu, 30 May 2019 02:29:10 +0000")
Tony Chuang <yhchuang@realtek.com> writes:
>> -----Original Message-----
>> From: Larry Finger [mailto:larry.finger@gmail.com] On Behalf Of Larry Finger
>> Sent: Wednesday, May 29, 2019 11:17 PM
>> To: Tony Chuang; kvalo@codeaurora.org
>> Cc: linux-wireless@vger.kernel.org
>> Subject: Re: [PATCH 01/11] rtw88: resolve order of tx power setting routines
>>
>> On 5/29/19 2:54 AM, yhchuang@realtek.com wrote:
>> > From: Yan-Hsuan Chuang <yhchuang@realtek.com>
>> >
>> > Some functions that should be static are unnecessarily exposed, remove
>> > their declaration in header file phy.h.
>> >
>> > After resolving their declaration order, they can be declared as static.
>> > So this commit changes nothing except the order and marking them static.
>> >
>> > Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
>>
>> This patch does not apply. Using quilt to see what is wrong, there are 6
>> changes
>> that have already been applied.
>>
>> Larry
>>
>
>
> These patches are based on
>
> https://kernel.googlesource.com/pub/scm/linux/kernel/git/kvalo/wireless-drivers
> branch master
>
> commit 6aca09771db4277a78853d6ac680d8d5f0d915e3
> Author: YueHaibing <yuehaibing@huawei.com>
> Date: Sat May 4 18:32:24 2019 +0800
>
> rtw88: Make some symbols static
>
>
> It should apply, did I miss something?
I keep the bar high and take to wireless-drivers only patches which fix
important, user visible problems. Everything else goes to
wireless-drivers-next. So you should use wireless-drivers-next as the
baseline for all regular patches.
--
Kalle Valo
next prev parent reply other threads:[~2019-05-30 4:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 7:54 [PATCH 00/11] rtw88: power index setting routine updates and fixes yhchuang
2019-05-29 7:54 ` [PATCH 01/11] rtw88: resolve order of tx power setting routines yhchuang
2019-05-29 15:16 ` Larry Finger
2019-05-30 2:29 ` Tony Chuang
2019-05-30 2:57 ` Larry Finger
2019-05-30 4:59 ` Kalle Valo [this message]
2019-05-30 5:05 ` Tony Chuang
2019-05-30 5:11 ` Kalle Valo
2019-05-30 5:15 ` Tony Chuang
2019-06-27 17:27 ` Kalle Valo
2019-05-29 7:54 ` [PATCH 02/11] rtw88: do not use (void *) as argument yhchuang
2019-05-29 7:54 ` [PATCH 03/11] rtw88: unify prefixes for tx power setting routine yhchuang
2019-05-29 7:54 ` [PATCH 04/11] rtw88: remove unused variable yhchuang
2019-05-29 7:54 ` [PATCH 05/11] rtw88: fix incorrect tx power limit at 5G yhchuang
2019-05-29 7:54 ` [PATCH 06/11] rtw88: choose the lowest as world-wide power limit yhchuang
2019-05-29 7:54 ` [PATCH 07/11] rtw88: correct power limit selection yhchuang
2019-05-29 7:54 ` [PATCH 08/11] rtw88: update tx power limit table to RF v20 yhchuang
2019-05-29 7:54 ` [PATCH 09/11] rtw88: remove all RTW_MAX_POWER_INDEX macro yhchuang
2019-07-11 22:05 ` Brian Norris
2019-07-16 8:15 ` Tony Chuang
2019-05-29 7:54 ` [PATCH 10/11] rtw88: refine flow to get tx power index yhchuang
2019-05-29 7:54 ` [PATCH 11/11] rtw88: debug: dump tx power indexes in use yhchuang
2019-06-01 22:51 ` Joe Perches
2019-06-04 8:18 ` Tony Chuang
2019-06-11 10:07 ` [PATCH 00/11] rtw88: power index setting routine updates and fixes Tony Chuang
2019-06-11 13:39 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9xspmfd.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.