From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Date: Thu, 21 Mar 2019 10:01:13 +0000 Subject: Re: [PATCH v2] drm/i915/selftests: fix NULL vs IS_ERR() check in mock_context_barrier() Message-Id: <87va0czguu.fsf@gaia.fi.intel.com> List-Id: References: <20190321092451.GK2202@kadam> In-Reply-To: <20190321092451.GK2202@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter , Jani Nikula , Chris Wilson Cc: David Airlie , intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, Matthew Auld Dan Carpenter writes: > The mock_context() function returns NULL on error, it doesn't return > error pointers. > > Fixes: 85fddf0b0027 ("drm/i915: Introduce a context barrier callback") > Signed-off-by: Dan Carpenter Reviewed-by: Mika Kuoppala > --- > V2: I accidentally sent a bunch of unrelated stuff... > > diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_context.c b/drivers/gpu/drm/i915/selftests/i915_gem_context.c > index 4399ef9ebf15..a172dbd9cb9e 100644 > --- a/drivers/gpu/drm/i915/selftests/i915_gem_context.c > +++ b/drivers/gpu/drm/i915/selftests/i915_gem_context.c > @@ -1620,8 +1620,8 @@ static int mock_context_barrier(void *arg) > mutex_lock(&i915->drm.struct_mutex); > > ctx = mock_context(i915, "mock"); > - if (IS_ERR(ctx)) { > - err = PTR_ERR(ctx); > + if (!ctx) { > + err = -ENOMEM; > goto unlock; > } > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH v2] drm/i915/selftests: fix NULL vs IS_ERR() check in mock_context_barrier() Date: Thu, 21 Mar 2019 12:01:13 +0200 Message-ID: <87va0czguu.fsf@gaia.fi.intel.com> References: <20190321092451.GK2202@kadam> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id AB4F189F5B for ; Thu, 21 Mar 2019 10:02:00 +0000 (UTC) In-Reply-To: <20190321092451.GK2202@kadam> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dan Carpenter , Jani Nikula , Chris Wilson Cc: David Airlie , intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, Matthew Auld List-Id: intel-gfx@lists.freedesktop.org RGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRlckBvcmFjbGUuY29tPiB3cml0ZXM6Cgo+IFRoZSBt b2NrX2NvbnRleHQoKSBmdW5jdGlvbiByZXR1cm5zIE5VTEwgb24gZXJyb3IsIGl0IGRvZXNuJ3Qg cmV0dXJuCj4gZXJyb3IgcG9pbnRlcnMuCj4KPiBGaXhlczogODVmZGRmMGIwMDI3ICgiZHJtL2k5 MTU6IEludHJvZHVjZSBhIGNvbnRleHQgYmFycmllciBjYWxsYmFjayIpCj4gU2lnbmVkLW9mZi1i eTogRGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRlckBvcmFjbGUuY29tPgoKUmV2aWV3ZWQtYnk6 IE1pa2EgS3VvcHBhbGEgPG1pa2Eua3VvcHBhbGFAbGludXguaW50ZWwuY29tPgoKPiAtLS0KPiBW MjogSSBhY2NpZGVudGFsbHkgc2VudCBhIGJ1bmNoIG9mIHVucmVsYXRlZCBzdHVmZi4uLgo+Cj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9pOTE1X2dlbV9jb250 ZXh0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxmdGVzdHMvaTkxNV9nZW1fY29udGV4dC5j Cj4gaW5kZXggNDM5OWVmOWViZjE1Li5hMTcyZGJkOWNiOWUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL2k5MTVfZ2VtX2NvbnRleHQuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9pOTE1X2dlbV9jb250ZXh0LmMKPiBAQCAtMTYyMCw4 ICsxNjIwLDggQEAgc3RhdGljIGludCBtb2NrX2NvbnRleHRfYmFycmllcih2b2lkICphcmcpCj4g IAltdXRleF9sb2NrKCZpOTE1LT5kcm0uc3RydWN0X211dGV4KTsKPiAgCj4gIAljdHggPSBtb2Nr X2NvbnRleHQoaTkxNSwgIm1vY2siKTsKPiAtCWlmIChJU19FUlIoY3R4KSkgewo+IC0JCWVyciA9 IFBUUl9FUlIoY3R4KTsKPiArCWlmICghY3R4KSB7Cj4gKwkJZXJyID0gLUVOT01FTTsKPiAgCQln b3RvIHVubG9jazsKPiAgCX0KPiAgCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2ludGVsLWdmeA==