From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: Call MG_DP_MODE() macro with the right parameters order Date: Mon, 25 Feb 2019 12:26:45 +0200 Message-ID: <87va18rwnu.fsf@intel.com> References: <20190222202437.6575-1-jose.souza@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 110A4892BB for ; Mon, 25 Feb 2019 10:24:42 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lucas De Marchi , =?utf-8?Q?Jos=C3=A9?= Roberto de Souza Cc: Intel Graphics List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCAyMiBGZWIgMjAxOSwgTHVjYXMgRGUgTWFyY2hpIDxsdWNhcy5kZS5tYXJjaGlAZ21h aWwuY29tPiB3cm90ZToKPiBPbiBGcmksIEZlYiAyMiwgMjAxOSBhdCAxMjoyNCBQTSBKb3PDqSBS b2JlcnRvIGRlIFNvdXphCj4gPGpvc2Uuc291emFAaW50ZWwuY29tPiB3cm90ZToKPj4KPj4gVGhl IGNvbW1pdCB0aGF0IHRoaXMgcGF0Y2ggZml4ZXMgY2hhbmdlZCB0aGUgb3JkZXIgb2YgdGhlIHBh cmFtZXRlcnMKPj4gb2YgTUdfRFBfTU9ERSgpIGJ1dCBkaW4ndCB1cGRhdGUgdGhlIGNhbGxlcnMs IGJyZWFraW5nIHR5cGUtYyBvbiBJQ0wuCj4KPiB1Z2guLi4KPgo+Pgo+PiBGaXhlczogNTgxMDZi N2Q4MTZlICgiZHJtL2k5MTU6IE1ha2UgTUcgUEhZIG1hY3JvcyBzZW1hbnRpY2FsbHkgY29uc2lz dGVudCIpCj4KPiBGcm9tIGEgcXVpY2sgZ3JlcCBpbiB0aGUgY29tbWl0Ogo+IGdpdCBzaG93IDU4 MTA2YjdkODE2ZSB8IGdyZXAgIl4rI2RlZmluZSIKPiArI2RlZmluZSBNR19QSFlfUE9SVF9MTihs biwgcG9ydCwgbG4wcDEsIGxuMHAyLCBsbjFwMSkgXAo+ICsjZGVmaW5lIE1HX1RYMV9MSU5LX1BB UkFNUyhsbiwgcG9ydCkgXAo+ICsjZGVmaW5lIE1HX1RYMl9MSU5LX1BBUkFNUyhsbiwgcG9ydCkg XAo+ICsjZGVmaW5lIE1HX1RYMV9QSVNPX1JFQURMT0FEKGxuLCBwb3J0KSBcCj4gKyNkZWZpbmUg TUdfVFgyX1BJU09fUkVBRExPQUQobG4sIHBvcnQpIFwKPiArI2RlZmluZSBNR19UWDFfU1dJTkdD VFJMKGxuLCBwb3J0KSBcCj4gKyNkZWZpbmUgTUdfVFgyX1NXSU5HQ1RSTChsbiwgcG9ydCkgXAo+ ICsjZGVmaW5lIE1HX1RYMV9EUlZDVFJMKGxuLCBwb3J0KSBcCj4gKyNkZWZpbmUgTUdfVFgyX0RS VkNUUkwobG4sIHBvcnQpIFwKPiArI2RlZmluZSBNR19DTEtIVUIobG4sIHBvcnQpIFwKPiArI2Rl ZmluZSBNR19UWDFfRENDKGxuLCBwb3J0KSBcCj4gKyNkZWZpbmUgTUdfVFgyX0RDQyhsbiwgcG9y dCkgXAo+ICsjZGVmaW5lIE1HX0RQX01PREUobG4sIHBvcnQpIFwKPgo+IEdvaW5nIHRocm91Z2gg ZWFjaCBvZiB0aG9zZSwgaXQgc2VlbXMgTUdfRFBfTU9ERSgpIHdhcyBpbmRlZWQgdGhlIG9ubHkK PiBvbmUgbGVmdCBiZWhpbmQuIENvdWxkIHlvdSBkb3VibGUgY2hlY2s/CgpJIGRvdWJsZSBjaGVj a2VkIHRoaXMgYXMgd2VsbCBhcyA5MTk0ZTQyYTE4MzcgKCJkcm0vaTkxNTogTWFrZSBjb21ibyBQ SFkKRERJIG1hY3JvIGRlZmluaXRpb25zIGNvbnNpc3RlbnQgZm9yIElDTCBhbmQgQ05MIikuIFNl ZW1zIHRvIGJlIGFsbApyaWdodCBub3cuCgpBcmd1YWJseSBJIHNob3VsZCd2ZSBkb25lIHRoaXMg d2hlbiBJIHB1c2hlZCB0aGUgY2hhbmdlLCBidXQgSSBvbmx5IGRpZApzb21lIHNwb3QgY2hlY2tz IGFzIEkgdHJ1c3RlZCB0aGUgUmV2aWV3ZWQtYnkuCgo+IFJldmlld2VkLWJ5OiBMdWNhcyBEZSBN YXJjaGkgPGx1Y2FzLmRlbWFyY2hpQGludGVsLmNvbT4KClRoYW5rcyBmb3IgdGhlIHBhdGNoIGFu ZCByZXZpZXcsIHB1c2hlZC4KCkJSLApKYW5pLgoKCj4KPiB0aGFua3MKPiBMdWNhcyBEZSBNYXJj aGkKPgo+PiBDYzogQ2xpbnQgVGF5bG9yIDxjbGludG9uLmEudGF5bG9yQGludGVsLmNvbT4KPj4g Q2M6IEltcmUgRGVhayA8aW1yZS5kZWFrQGludGVsLmNvbT4KPj4gQ2M6IEphbmkgTmlrdWxhIDxq YW5pLm5pa3VsYUBsaW51eC5pbnRlbC5jb20+Cj4+IENjOiBBZGl0eWEgU3dhcnVwIDxhZGl0eWEu c3dhcnVwQGludGVsLmNvbT4KPj4gQ2M6IE1hbmFzaSBuYXZhcmUgPG1hbmFzaS5kLm5hdmFyZUBp bnRlbC5jb20+Cj4+IENjOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+PiBT aWduZWQtb2ZmLWJ5OiBKb3PDqSBSb2JlcnRvIGRlIFNvdXphIDxqb3NlLnNvdXphQGludGVsLmNv bT4KPj4gLS0tCj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYyB8IDEwICsrKysr LS0tLS0KPj4gIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0p Cj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4+IGluZGV4IGVhODMwNzFhMjJjNC4uMTM1 NWJlOGRlYzNiIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGku Ywo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+PiBAQCAtMjkyOCw3 ICsyOTI4LDcgQEAgc3RhdGljIHZvaWQgaWNsX2VuYWJsZV9waHlfY2xvY2tfZ2F0aW5nKHN0cnVj dCBpbnRlbF9kaWdpdGFsX3BvcnQgKmRpZ19wb3J0KQo+PiAgICAgICAgIHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGlnX3BvcnQtPmJhc2UuYmFzZS5kZXYpOwo+ PiAgICAgICAgIGVudW0gcG9ydCBwb3J0ID0gZGlnX3BvcnQtPmJhc2UucG9ydDsKPj4gICAgICAg ICBlbnVtIHRjX3BvcnQgdGNfcG9ydCA9IGludGVsX3BvcnRfdG9fdGMoZGV2X3ByaXYsIHBvcnQp Owo+PiAtICAgICAgIGk5MTVfcmVnX3QgbWdfcmVnc1syXSA9IHsgTUdfRFBfTU9ERShwb3J0LCAw KSwgTUdfRFBfTU9ERShwb3J0LCAxKSB9Owo+PiArICAgICAgIGk5MTVfcmVnX3QgbWdfcmVnc1sy XSA9IHsgTUdfRFBfTU9ERSgwLCBwb3J0KSwgTUdfRFBfTU9ERSgxLCBwb3J0KSB9Owo+PiAgICAg ICAgIHUzMiB2YWw7Cj4+ICAgICAgICAgaW50IGk7Cj4+Cj4+IEBAIC0yOTk5LDggKzI5OTksOCBA QCBzdGF0aWMgdm9pZCBpY2xfcHJvZ3JhbV9tZ19kcF9tb2RlKHN0cnVjdCBpbnRlbF9kaWdpdGFs X3BvcnQgKmludGVsX2RpZ19wb3J0KQo+PiAgICAgICAgIGlmICh0Y19wb3J0ID09IFBPUlRfVENf Tk9ORSB8fCBpbnRlbF9kaWdfcG9ydC0+dGNfdHlwZSA9PSBUQ19QT1JUX1RCVCkKPj4gICAgICAg ICAgICAgICAgIHJldHVybjsKPj4KPj4gLSAgICAgICBsbjAgPSBJOTE1X1JFQUQoTUdfRFBfTU9E RShwb3J0LCAwKSk7Cj4+IC0gICAgICAgbG4xID0gSTkxNV9SRUFEKE1HX0RQX01PREUocG9ydCwg MSkpOwo+PiArICAgICAgIGxuMCA9IEk5MTVfUkVBRChNR19EUF9NT0RFKDAsIHBvcnQpKTsKPj4g KyAgICAgICBsbjEgPSBJOTE1X1JFQUQoTUdfRFBfTU9ERSgxLCBwb3J0KSk7Cj4+Cj4+ICAgICAg ICAgc3dpdGNoIChpbnRlbF9kaWdfcG9ydC0+dGNfdHlwZSkgewo+PiAgICAgICAgIGNhc2UgVENf UE9SVF9UWVBFQzoKPj4gQEAgLTMwNTAsOCArMzA1MCw4IEBAIHN0YXRpYyB2b2lkIGljbF9wcm9n cmFtX21nX2RwX21vZGUoc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQp Cj4+ICAgICAgICAgICAgICAgICByZXR1cm47Cj4+ICAgICAgICAgfQo+Pgo+PiAtICAgICAgIEk5 MTVfV1JJVEUoTUdfRFBfTU9ERShwb3J0LCAwKSwgbG4wKTsKPj4gLSAgICAgICBJOTE1X1dSSVRF KE1HX0RQX01PREUocG9ydCwgMSksIGxuMSk7Cj4+ICsgICAgICAgSTkxNV9XUklURShNR19EUF9N T0RFKDAsIHBvcnQpLCBsbjApOwo+PiArICAgICAgIEk5MTVfV1JJVEUoTUdfRFBfTU9ERSgxLCBw b3J0KSwgbG4xKTsKPj4gIH0KPj4KPj4gIHN0YXRpYyB2b2lkIGludGVsX2RwX3Npbmtfc2V0X2Zl Y19yZWFkeShzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLAo+PiAtLQo+PiAyLjIwLjEKPj4KPj4g X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPj4gSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdAo+PiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4+IGh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cgot LSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIEdyYXBoaWNzIENlbnRlcgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=