From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E63CC43381 for ; Thu, 21 Feb 2019 09:20:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2DD452086A for ; Thu, 21 Feb 2019 09:20:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=f-secure.com header.i=@f-secure.com header.b="M59Fjpxi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727690AbfBUJU1 (ORCPT ); Thu, 21 Feb 2019 04:20:27 -0500 Received: from helmsgmaster01.f-secure.com ([193.110.108.20]:40516 "EHLO helmsgmaster01.f-secure.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726339AbfBUJU1 (ORCPT ); Thu, 21 Feb 2019 04:20:27 -0500 X-Greylist: delayed 1048 seconds by postgrey-1.27 at vger.kernel.org; Thu, 21 Feb 2019 04:20:25 EST Received: from pps.filterd (helmsgmaster01.f-secure.com [127.0.0.1]) by helmsgmaster01.f-secure.com (8.16.0.27/8.16.0.27) with SMTP id x1L91rrW022035; Thu, 21 Feb 2019 11:05:05 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=f-secure.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : mime-version : content-type; s=msg2048; bh=4pgLzxkL9yHBeTx7gkuUTqz1fXIt+mdxNQXXbFXAtnI=; b=M59FjpxiSaMVpIMeRbUGMtxxp9qpBGop8bQNkq+jibYIVJu4OxESHC4qMGXEKdr78mAb oZW5vhkLG5KIp3eFPnA89aXyqtqn+etW9dSq4/UFA2CPBxQ+hfsrJuDGnrkoZKO29j1f di5VTtzPscxtnAmiwKboc03k/v94QNOwleiLteig2E6K2gxTEKJK4wr7XUpc0wLQHyuJ ezrmHdubdOA8Y2IBNsPnNUhHMH+PtgtAH1IzJXdzJbdrf8RDyb4nClpOUVVdUQZFRMRN hlRo8LQpzt9Hp3UMZ7Ocl8aqw3YIFleC2KHSetboUgEupPvgwfaAygAYaJteRURz/cIl tw== Received: from helex01.fi.f-secure.com ([10.190.48.70]) by helmsgmaster01.f-secure.com with ESMTP id 2qss00002t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 21 Feb 2019 11:05:05 +0200 Received: from drapion.f-secure.com (10.128.132.96) by helex01.FI.F-Secure.com (10.190.48.70) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 21 Feb 2019 11:02:43 +0200 From: Marko Rauhamaa To: Orion Poplawski CC: Jan Kara , , Amir Goldstein , Konstantin Khlebnikov , Vivek Trivedi Subject: Re: [PATCH v2 0/6] fanotify: Make wait for permission event response interruptible References: <20190213145443.26836-1-jack@suse.cz> Date: Thu, 21 Feb 2019 11:02:43 +0200 In-Reply-To: (Orion Poplawski's message of "Wed, 20 Feb 2019 10:27:04 -0700") Message-ID: <87va1dms3w.fsf@drapion.f-secure.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Orion Poplawski : > I backported these patches to the RHEL7 kernel and have started > running that. One thing I've noticed are messages like the following > at login time: > > bash: /etc/bash_completion.d/itweb-settings.bash: Interrupted system call > > [...] > > But I'm wondering if these changes are leading to more EINTR returns > from open() than expected. Of if this is the new "normal", or if this > points to bugs in the antivirus software holding the fanotify > callbacks. > > Thoughts? A great observation! I believe 99.9% of Linux software is unprepared for an EINTR from regular file I/O. That might even be considered a violation of the API. (You problem report is reminiscent of what I'm experiencing with emacs' "M-x compile" command. The compilation fails if I should change the window geometry simultaneously because a SIGWINCH hits the compilation job. Nothing to do with fanotify but somewhat analogous.) Marko