From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F989C43387 for ; Fri, 18 Jan 2019 16:52:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D493D2146F for ; Fri, 18 Jan 2019 16:52:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728034AbfARQwJ convert rfc822-to-8bit (ORCPT ); Fri, 18 Jan 2019 11:52:09 -0500 Received: from mail.bootlin.com ([62.4.15.54]:58379 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727481AbfARQwI (ORCPT ); Fri, 18 Jan 2019 11:52:08 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id 3BF76207A3; Fri, 18 Jan 2019 17:52:06 +0100 (CET) Received: from localhost (alyon-652-1-26-46.w109-213.abo.wanadoo.fr [109.213.9.46]) by mail.bootlin.com (Postfix) with ESMTPSA id 28F1A2074A; Fri, 18 Jan 2019 17:51:54 +0100 (CET) From: Gregory CLEMENT To: Miquel Raynal Cc: Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Thomas Petazzoni , Bjorn Helgaas , , Rob Herring , Mark Rutland , Lorenzo Pieralisi , linux-pci@vger.kernel.org, , , Antoine Tenart , Maxime Chevallier , Nadav Haklai Subject: Re: [PATCH v3 00/15] Bring suspend to RAM support to PCIe Aardvark driver References: <20190108162441.5278-1-miquel.raynal@bootlin.com> Date: Fri, 18 Jan 2019 17:51:52 +0100 In-Reply-To: <20190108162441.5278-1-miquel.raynal@bootlin.com> (Miquel Raynal's message of "Tue, 8 Jan 2019 17:24:25 +0100") Message-ID: <87va2llxhz.fsf@FE-laptop> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi Miquel, On mar., janv. 08 2019, Miquel Raynal wrote: > Hello, > > As part of an effort to bring suspend to RAM support to Armada 3700 > SoCs (main target: ESPRESSObin), this series handles the work around > the PCIe IP. > > First, more configuration is done in the 'setup' helper as inspired > from the U-Boot driver. This is needed to entirely initialize the IP > during future resume operation (patch 1). > > Then, reset GPIO, PHY and clock support are introduced (patch 2-4). As > current device trees do not provide the corresponding properties, not > finding one of these properties is not an error and just produces a > warning. However, if the property is present, an error during PHY > initialization will fail the probe of the driver. > > Note: To be sure the clock will be resumed before this driver, a first > series adding links between clocks and consumers has been submitted, > see [1]. Anyway, having the clock series applied first is not needed. > > Patch 5 adds suspend/resume hooks, re-using all the above. > > Finally, bindings and device trees are updated to reflect the hardware > (patch 6-12). While the clock depends on the SoC, the reset GPIO and > the PHY depends on the board so the clock is added in the > armada-37xx.dtsi file while the two other properties are added in > armada-3720-espressobin.dts. > > [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2019-January/623885.html > > Thanks, > Miquèl > > > Changes since v2: > ================= > * Minor patches reordering. > * Added pinctrl patches from Gregory Clement fixing the PCIe pins. His > changes implied modifications in the DT/bindings patches adding PCIe > reset pin support. Actually these patches are not in this series. You propably meant that this series is depend on these patches. If needed, for peoaple who wanted to test this series, the pinctrl changes are now in linux-next and also in pinctrl/for-next. Gregpry > * Added a new patch that enlarges the PIO timeout of the driver > (explanations in the commit log). > * With the timeout changed, removed the "experimental delay" that was > needed at resume time before accessing any register. > > Changes since v1: > ================= > * Change the capitalization in commit titles to follow the PCI > subsystem rules. > * Added Suggested-by tag to the patch adding PHY support and to the > patch adding the PHY property in the DT. > * Added Rob's Reviewed-by tags on bindings. > * I am following the discussion about calling functions that might > sleep in a NOIRQ context. As there is no real problem yet (as per my > understanding), I did not change anything on this regard. > > > Miquel Raynal (15): > PCI: aardvark: Enlarge PIO timeout > PCI: aardvark: Configure more registers in the configuration helper > PCI: aardvark: Add clock support > PCI: aardvark: Add PHY support > PCI: aardvark: Add PCIe warm reset support > PCI: aardvark: Add external reset GPIO support > PCI: aardvark: Add suspend to RAM support > dt-bindings: PCI: aardvark: Describe the clocks property > dt-bindings: PCI: aardvark: Describe the PHY property > dt-bindings: PCI: aardvark: Describe the PCIe endpoint card reset pins > dt-bindings: PCI: aardvark: Describe the reset-gpios property > ARM64: dts: marvell: armada-37xx: declare PCIe clock > ARM64: dts: marvell: armada-3720-espressobin: declare PCIe PHY > ARM64: dts: marvell: armada-37xx: declare PCIe reset pin > ARM64: dts: marvell: armada-3720-espressobin: declare PCIe warm reset > pin > > .../devicetree/bindings/pci/aardvark-pci.txt | 14 ++ > .../dts/marvell/armada-3720-espressobin.dts | 3 + > arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 10 + > drivers/pci/controller/pci-aardvark.c | 217 +++++++++++++++++- > 4 files changed, 243 insertions(+), 1 deletion(-) > > -- > 2.19.1 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0CE7C43387 for ; Fri, 18 Jan 2019 16:52:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A0F342086D for ; Fri, 18 Jan 2019 16:52:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eMuDY7V6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A0F342086D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fYebb1dpPq3M2sdTBPM4YOXpIwLPz4+BgLoTY0X2o9A=; b=eMuDY7V6bI/Aux YzIHKY3ddeeOEMCznRaj4Pdy+LYkAjVr90lOssRdqleZrUnTxtmA4xbC2wbaCm95ew2EKtce8S9gq m3E31CwCl/l4/NvF1EkJHA5KN7CCd2AoQWBMr0LE1vz17CxRVYlRlKpAZivKuoVtHEEzBvLiJShGo txjtUH2asB6QfgbDdFxnYxhuIiVUVnK2OIpcvHxlkOuqMBw8mx1MK2hohPicbJhJAFSwydKwkyvpA 3t7WAokNNVpl0PjdXykjjTn+j6uyZIjt8o0Wcg37pU+CUbqbJ6uUr2A7MAZnfa+5WVvnjgbpfVpH5 MjlsoWpUyDOxc38d/eJA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gkXNL-0003bK-K0; Fri, 18 Jan 2019 16:52:11 +0000 Received: from mail.bootlin.com ([62.4.15.54]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gkXNH-0003ah-ML for linux-arm-kernel@lists.infradead.org; Fri, 18 Jan 2019 16:52:09 +0000 Received: by mail.bootlin.com (Postfix, from userid 110) id 3BF76207A3; Fri, 18 Jan 2019 17:52:06 +0100 (CET) Received: from localhost (alyon-652-1-26-46.w109-213.abo.wanadoo.fr [109.213.9.46]) by mail.bootlin.com (Postfix) with ESMTPSA id 28F1A2074A; Fri, 18 Jan 2019 17:51:54 +0100 (CET) From: Gregory CLEMENT To: Miquel Raynal Subject: Re: [PATCH v3 00/15] Bring suspend to RAM support to PCIe Aardvark driver References: <20190108162441.5278-1-miquel.raynal@bootlin.com> Date: Fri, 18 Jan 2019 17:51:52 +0100 In-Reply-To: <20190108162441.5278-1-miquel.raynal@bootlin.com> (Miquel Raynal's message of "Tue, 8 Jan 2019 17:24:25 +0100") Message-ID: <87va2llxhz.fsf@FE-laptop> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190118_085207_997503_1E446F0B X-CRM114-Status: GOOD ( 26.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Andrew Lunn , Lorenzo Pieralisi , Jason Cooper , devicetree@vger.kernel.org, Antoine Tenart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Maxime Chevallier , Nadav Haklai , Rob Herring , Thomas Petazzoni , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTWlxdWVsLAogCiBPbiBtYXIuLCBqYW52LiAwOCAyMDE5LCBNaXF1ZWwgUmF5bmFsIDxtaXF1 ZWwucmF5bmFsQGJvb3RsaW4uY29tPiB3cm90ZToKCj4gSGVsbG8sCj4KPiBBcyBwYXJ0IG9mIGFu IGVmZm9ydCB0byBicmluZyBzdXNwZW5kIHRvIFJBTSBzdXBwb3J0IHRvIEFybWFkYSAzNzAwCj4g U29DcyAobWFpbiB0YXJnZXQ6IEVTUFJFU1NPYmluKSwgdGhpcyBzZXJpZXMgaGFuZGxlcyB0aGUg d29yayBhcm91bmQKPiB0aGUgUENJZSBJUC4KPgo+IEZpcnN0LCBtb3JlIGNvbmZpZ3VyYXRpb24g aXMgZG9uZSBpbiB0aGUgJ3NldHVwJyBoZWxwZXIgYXMgaW5zcGlyZWQKPiBmcm9tIHRoZSBVLUJv b3QgZHJpdmVyLiBUaGlzIGlzIG5lZWRlZCB0byBlbnRpcmVseSBpbml0aWFsaXplIHRoZSBJUAo+ IGR1cmluZyBmdXR1cmUgcmVzdW1lIG9wZXJhdGlvbiAocGF0Y2ggMSkuCj4KPiBUaGVuLCByZXNl dCBHUElPLCBQSFkgYW5kIGNsb2NrIHN1cHBvcnQgYXJlIGludHJvZHVjZWQgKHBhdGNoIDItNCku IEFzCj4gY3VycmVudCBkZXZpY2UgdHJlZXMgZG8gbm90IHByb3ZpZGUgdGhlIGNvcnJlc3BvbmRp bmcgcHJvcGVydGllcywgbm90Cj4gZmluZGluZyBvbmUgb2YgdGhlc2UgcHJvcGVydGllcyBpcyBu b3QgYW4gZXJyb3IgYW5kIGp1c3QgcHJvZHVjZXMgYQo+IHdhcm5pbmcuIEhvd2V2ZXIsIGlmIHRo ZSBwcm9wZXJ0eSBpcyBwcmVzZW50LCBhbiBlcnJvciBkdXJpbmcgUEhZCj4gaW5pdGlhbGl6YXRp b24gd2lsbCBmYWlsIHRoZSBwcm9iZSBvZiB0aGUgZHJpdmVyLgo+Cj4gTm90ZTogVG8gYmUgc3Vy ZSB0aGUgY2xvY2sgd2lsbCBiZSByZXN1bWVkIGJlZm9yZSB0aGlzIGRyaXZlciwgYSBmaXJzdAo+ IHNlcmllcyBhZGRpbmcgbGlua3MgYmV0d2VlbiBjbG9ja3MgYW5kIGNvbnN1bWVycyBoYXMgYmVl biBzdWJtaXR0ZWQsCj4gc2VlIFsxXS4gQW55d2F5LCBoYXZpbmcgdGhlIGNsb2NrIHNlcmllcyBh cHBsaWVkIGZpcnN0IGlzIG5vdCBuZWVkZWQuCj4KPiBQYXRjaCA1IGFkZHMgc3VzcGVuZC9yZXN1 bWUgaG9va3MsIHJlLXVzaW5nIGFsbCB0aGUgYWJvdmUuCj4KPiBGaW5hbGx5LCBiaW5kaW5ncyBh bmQgZGV2aWNlIHRyZWVzIGFyZSB1cGRhdGVkIHRvIHJlZmxlY3QgdGhlIGhhcmR3YXJlCj4gKHBh dGNoIDYtMTIpLiBXaGlsZSB0aGUgY2xvY2sgZGVwZW5kcyBvbiB0aGUgU29DLCB0aGUgcmVzZXQg R1BJTyBhbmQKPiB0aGUgUEhZIGRlcGVuZHMgb24gdGhlIGJvYXJkIHNvIHRoZSBjbG9jayBpcyBh ZGRlZCBpbiB0aGUKPiBhcm1hZGEtMzd4eC5kdHNpIGZpbGUgd2hpbGUgdGhlIHR3byBvdGhlciBw cm9wZXJ0aWVzIGFyZSBhZGRlZCBpbgo+IGFybWFkYS0zNzIwLWVzcHJlc3NvYmluLmR0cy4KPgo+ IFsxXSBodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9waXBlcm1haWwvbGludXgtYXJtLWtlcm5l bC8yMDE5LUphbnVhcnkvNjIzODg1Lmh0bWwKPgo+IFRoYW5rcywKPiBNaXF1w6hsCj4KPgo+IENo YW5nZXMgc2luY2UgdjI6Cj4gPT09PT09PT09PT09PT09PT0KPiAqIE1pbm9yIHBhdGNoZXMgcmVv cmRlcmluZy4KPiAqIEFkZGVkIHBpbmN0cmwgcGF0Y2hlcyBmcm9tIEdyZWdvcnkgQ2xlbWVudCBm aXhpbmcgdGhlIFBDSWUgcGlucy4gSGlzCj4gICBjaGFuZ2VzIGltcGxpZWQgbW9kaWZpY2F0aW9u cyBpbiB0aGUgRFQvYmluZGluZ3MgcGF0Y2hlcyBhZGRpbmcgUENJZQo+ICAgcmVzZXQgcGluIHN1 cHBvcnQuCgpBY3R1YWxseSB0aGVzZSBwYXRjaGVzIGFyZSBub3QgaW4gdGhpcyBzZXJpZXMuIFlv dSBwcm9wYWJseSBtZWFudCB0aGF0CnRoaXMgc2VyaWVzIGlzIGRlcGVuZCBvbiB0aGVzZSBwYXRj aGVzLgoKSWYgbmVlZGVkLCBmb3IgcGVvYXBsZSB3aG8gd2FudGVkIHRvIHRlc3QgdGhpcyBzZXJp ZXMsIHRoZSBwaW5jdHJsCmNoYW5nZXMgYXJlIG5vdyBpbiBsaW51eC1uZXh0IGFuZCBhbHNvIGlu IHBpbmN0cmwvZm9yLW5leHQuCgpHcmVncHJ5Cgo+ICogQWRkZWQgYSBuZXcgcGF0Y2ggdGhhdCBl bmxhcmdlcyB0aGUgUElPIHRpbWVvdXQgb2YgdGhlIGRyaXZlcgo+ICAgKGV4cGxhbmF0aW9ucyBp biB0aGUgY29tbWl0IGxvZykuCj4gKiBXaXRoIHRoZSB0aW1lb3V0IGNoYW5nZWQsIHJlbW92ZWQg dGhlICJleHBlcmltZW50YWwgZGVsYXkiIHRoYXQgd2FzCj4gICBuZWVkZWQgYXQgcmVzdW1lIHRp bWUgYmVmb3JlIGFjY2Vzc2luZyBhbnkgcmVnaXN0ZXIuCj4KPiBDaGFuZ2VzIHNpbmNlIHYxOgo+ ID09PT09PT09PT09PT09PT09Cj4gKiBDaGFuZ2UgdGhlIGNhcGl0YWxpemF0aW9uIGluIGNvbW1p dCB0aXRsZXMgdG8gZm9sbG93IHRoZSBQQ0kKPiAgIHN1YnN5c3RlbSBydWxlcy4KPiAqIEFkZGVk IFN1Z2dlc3RlZC1ieSB0YWcgdG8gdGhlIHBhdGNoIGFkZGluZyBQSFkgc3VwcG9ydCBhbmQgdG8g dGhlCj4gICBwYXRjaCBhZGRpbmcgdGhlIFBIWSBwcm9wZXJ0eSBpbiB0aGUgRFQuCj4gKiBBZGRl ZCBSb2IncyBSZXZpZXdlZC1ieSB0YWdzIG9uIGJpbmRpbmdzLgo+ICogSSBhbSBmb2xsb3dpbmcg dGhlIGRpc2N1c3Npb24gYWJvdXQgY2FsbGluZyBmdW5jdGlvbnMgdGhhdCBtaWdodAo+ICAgc2xl ZXAgaW4gYSBOT0lSUSBjb250ZXh0LiBBcyB0aGVyZSBpcyBubyByZWFsIHByb2JsZW0geWV0IChh cyBwZXIgbXkKPiAgIHVuZGVyc3RhbmRpbmcpLCBJIGRpZCBub3QgY2hhbmdlIGFueXRoaW5nIG9u IHRoaXMgcmVnYXJkLgo+Cj4KPiBNaXF1ZWwgUmF5bmFsICgxNSk6Cj4gICBQQ0k6IGFhcmR2YXJr OiBFbmxhcmdlIFBJTyB0aW1lb3V0Cj4gICBQQ0k6IGFhcmR2YXJrOiBDb25maWd1cmUgbW9yZSBy ZWdpc3RlcnMgaW4gdGhlIGNvbmZpZ3VyYXRpb24gaGVscGVyCj4gICBQQ0k6IGFhcmR2YXJrOiBB ZGQgY2xvY2sgc3VwcG9ydAo+ICAgUENJOiBhYXJkdmFyazogQWRkIFBIWSBzdXBwb3J0Cj4gICBQ Q0k6IGFhcmR2YXJrOiBBZGQgUENJZSB3YXJtIHJlc2V0IHN1cHBvcnQKPiAgIFBDSTogYWFyZHZh cms6IEFkZCBleHRlcm5hbCByZXNldCBHUElPIHN1cHBvcnQKPiAgIFBDSTogYWFyZHZhcms6IEFk ZCBzdXNwZW5kIHRvIFJBTSBzdXBwb3J0Cj4gICBkdC1iaW5kaW5nczogUENJOiBhYXJkdmFyazog RGVzY3JpYmUgdGhlIGNsb2NrcyBwcm9wZXJ0eQo+ICAgZHQtYmluZGluZ3M6IFBDSTogYWFyZHZh cms6IERlc2NyaWJlIHRoZSBQSFkgcHJvcGVydHkKPiAgIGR0LWJpbmRpbmdzOiBQQ0k6IGFhcmR2 YXJrOiBEZXNjcmliZSB0aGUgUENJZSBlbmRwb2ludCBjYXJkIHJlc2V0IHBpbnMKPiAgIGR0LWJp bmRpbmdzOiBQQ0k6IGFhcmR2YXJrOiBEZXNjcmliZSB0aGUgcmVzZXQtZ3Bpb3MgcHJvcGVydHkK PiAgIEFSTTY0OiBkdHM6IG1hcnZlbGw6IGFybWFkYS0zN3h4OiBkZWNsYXJlIFBDSWUgY2xvY2sK PiAgIEFSTTY0OiBkdHM6IG1hcnZlbGw6IGFybWFkYS0zNzIwLWVzcHJlc3NvYmluOiBkZWNsYXJl IFBDSWUgUEhZCj4gICBBUk02NDogZHRzOiBtYXJ2ZWxsOiBhcm1hZGEtMzd4eDogZGVjbGFyZSBQ Q0llIHJlc2V0IHBpbgo+ICAgQVJNNjQ6IGR0czogbWFydmVsbDogYXJtYWRhLTM3MjAtZXNwcmVz c29iaW46IGRlY2xhcmUgUENJZSB3YXJtIHJlc2V0Cj4gICAgIHBpbgo+Cj4gIC4uLi9kZXZpY2V0 cmVlL2JpbmRpbmdzL3BjaS9hYXJkdmFyay1wY2kudHh0ICB8ICAxNCArKwo+ICAuLi4vZHRzL21h cnZlbGwvYXJtYWRhLTM3MjAtZXNwcmVzc29iaW4uZHRzICAgfCAgIDMgKwo+ICBhcmNoL2FybTY0 L2Jvb3QvZHRzL21hcnZlbGwvYXJtYWRhLTM3eHguZHRzaSAgfCAgMTAgKwo+ICBkcml2ZXJzL3Bj aS9jb250cm9sbGVyL3BjaS1hYXJkdmFyay5jICAgICAgICAgfCAyMTcgKysrKysrKysrKysrKysr KystCj4gIDQgZmlsZXMgY2hhbmdlZCwgMjQzIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkK Pgo+IC0tIAo+IDIuMTkuMQo+CgotLSAKR3JlZ29yeSBDbGVtZW50LCBCb290bGluCkVtYmVkZGVk IExpbnV4IGFuZCBLZXJuZWwgZW5naW5lZXJpbmcKaHR0cDovL2Jvb3RsaW4uY29tCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVs IG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory CLEMENT Subject: Re: [PATCH v3 00/15] Bring suspend to RAM support to PCIe Aardvark driver Date: Fri, 18 Jan 2019 17:51:52 +0100 Message-ID: <87va2llxhz.fsf@FE-laptop> References: <20190108162441.5278-1-miquel.raynal@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <20190108162441.5278-1-miquel.raynal@bootlin.com> (Miquel Raynal's message of "Tue, 8 Jan 2019 17:24:25 +0100") Sender: linux-kernel-owner@vger.kernel.org To: Miquel Raynal Cc: Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Thomas Petazzoni , Bjorn Helgaas , devicetree@vger.kernel.org, Rob Herring , Mark Rutland , Lorenzo Pieralisi , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Antoine Tenart , Maxime Chevallier , Nadav Haklai List-Id: devicetree@vger.kernel.org Hi Miquel, On mar., janv. 08 2019, Miquel Raynal wrote: > Hello, > > As part of an effort to bring suspend to RAM support to Armada 3700 > SoCs (main target: ESPRESSObin), this series handles the work around > the PCIe IP. > > First, more configuration is done in the 'setup' helper as inspired > from the U-Boot driver. This is needed to entirely initialize the IP > during future resume operation (patch 1). > > Then, reset GPIO, PHY and clock support are introduced (patch 2-4). As > current device trees do not provide the corresponding properties, not > finding one of these properties is not an error and just produces a > warning. However, if the property is present, an error during PHY > initialization will fail the probe of the driver. > > Note: To be sure the clock will be resumed before this driver, a first > series adding links between clocks and consumers has been submitted, > see [1]. Anyway, having the clock series applied first is not needed. > > Patch 5 adds suspend/resume hooks, re-using all the above. > > Finally, bindings and device trees are updated to reflect the hardware > (patch 6-12). While the clock depends on the SoC, the reset GPIO and > the PHY depends on the board so the clock is added in the > armada-37xx.dtsi file while the two other properties are added in > armada-3720-espressobin.dts. > > [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2019-January/623885.html > > Thanks, > Miquèl > > > Changes since v2: > ================= > * Minor patches reordering. > * Added pinctrl patches from Gregory Clement fixing the PCIe pins. His > changes implied modifications in the DT/bindings patches adding PCIe > reset pin support. Actually these patches are not in this series. You propably meant that this series is depend on these patches. If needed, for peoaple who wanted to test this series, the pinctrl changes are now in linux-next and also in pinctrl/for-next. Gregpry > * Added a new patch that enlarges the PIO timeout of the driver > (explanations in the commit log). > * With the timeout changed, removed the "experimental delay" that was > needed at resume time before accessing any register. > > Changes since v1: > ================= > * Change the capitalization in commit titles to follow the PCI > subsystem rules. > * Added Suggested-by tag to the patch adding PHY support and to the > patch adding the PHY property in the DT. > * Added Rob's Reviewed-by tags on bindings. > * I am following the discussion about calling functions that might > sleep in a NOIRQ context. As there is no real problem yet (as per my > understanding), I did not change anything on this regard. > > > Miquel Raynal (15): > PCI: aardvark: Enlarge PIO timeout > PCI: aardvark: Configure more registers in the configuration helper > PCI: aardvark: Add clock support > PCI: aardvark: Add PHY support > PCI: aardvark: Add PCIe warm reset support > PCI: aardvark: Add external reset GPIO support > PCI: aardvark: Add suspend to RAM support > dt-bindings: PCI: aardvark: Describe the clocks property > dt-bindings: PCI: aardvark: Describe the PHY property > dt-bindings: PCI: aardvark: Describe the PCIe endpoint card reset pins > dt-bindings: PCI: aardvark: Describe the reset-gpios property > ARM64: dts: marvell: armada-37xx: declare PCIe clock > ARM64: dts: marvell: armada-3720-espressobin: declare PCIe PHY > ARM64: dts: marvell: armada-37xx: declare PCIe reset pin > ARM64: dts: marvell: armada-3720-espressobin: declare PCIe warm reset > pin > > .../devicetree/bindings/pci/aardvark-pci.txt | 14 ++ > .../dts/marvell/armada-3720-espressobin.dts | 3 + > arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 10 + > drivers/pci/controller/pci-aardvark.c | 217 +++++++++++++++++- > 4 files changed, 243 insertions(+), 1 deletion(-) > > -- > 2.19.1 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com