From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Andrew Lunn <andrew@lunn.ch>, Jason Cooper <jason@lakedaemon.net>,
Jamie Lentin <jm@lentin.co.uk>,
linux-arm-kernel@lists.infradead.org,
Julien D'Ascenzio <jdascenzio@posteo.net>,
Guenter Roeck <linux@roeck-us.net>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH] ARM: dts: kirkwood: Fix polarity of GPIO fan lines
Date: Thu, 10 Jan 2019 12:25:25 +0100 [thread overview]
Message-ID: <87va2woiu2.fsf@FE-laptop> (raw)
In-Reply-To: <20190107230818.6020-1-linus.walleij@linaro.org> (Linus Walleij's message of "Tue, 8 Jan 2019 00:08:18 +0100")
Hi Linus,
On mar., janv. 08 2019, Linus Walleij <linus.walleij@linaro.org> wrote:
> These two lines are active high, not active low. The bug was
> found when we changed the kernel to respect the polarity defined
> in the device tree.
>
> Fixes: 1b90e06b1429 ("ARM: kirkwood: Use devicetree to define DNS-32[05] fan")
> Cc: Jamie Lentin <jm@lentin.co.uk>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Jason Cooper <jason@lakedaemon.net>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Gregory Clement <gregory.clement@bootlin.com>
> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> Cc: Julien D'Ascenzio <jdascenzio@posteo.net>
> Reported-by: Julien D'Ascenzio <jdascenzio@posteo.net>
> Tested-by: Julien D'Ascenzio <jdascenzio@posteo.net>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Applied on mvebu/fixes with tags from Andrew and Jamie
Thanks,
Gregory
> ---
> arch/arm/boot/dts/kirkwood-dnskw.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/kirkwood-dnskw.dtsi b/arch/arm/boot/dts/kirkwood-dnskw.dtsi
> index cbaf06f2f78e..eb917462b219 100644
> --- a/arch/arm/boot/dts/kirkwood-dnskw.dtsi
> +++ b/arch/arm/boot/dts/kirkwood-dnskw.dtsi
> @@ -36,8 +36,8 @@
> compatible = "gpio-fan";
> pinctrl-0 = <&pmx_fan_high_speed &pmx_fan_low_speed>;
> pinctrl-names = "default";
> - gpios = <&gpio1 14 GPIO_ACTIVE_LOW
> - &gpio1 13 GPIO_ACTIVE_LOW>;
> + gpios = <&gpio1 14 GPIO_ACTIVE_HIGH
> + &gpio1 13 GPIO_ACTIVE_HIGH>;
> gpio-fan,speed-map = <0 0
> 3000 1
> 6000 2>;
> --
> 2.19.2
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-01-10 11:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 23:08 [PATCH] ARM: dts: kirkwood: Fix polarity of GPIO fan lines Linus Walleij
2019-01-08 23:02 ` Jamie Lentin
2019-01-08 23:09 ` Andrew Lunn
2019-01-10 11:25 ` Gregory CLEMENT [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87va2woiu2.fsf@FE-laptop \
--to=gregory.clement@bootlin.com \
--cc=andrew@lunn.ch \
--cc=jason@lakedaemon.net \
--cc=jdascenzio@posteo.net \
--cc=jm@lentin.co.uk \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.