From: Baruch Siach <baruch@tkos.co.il>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: linux-rtc@vger.kernel.org
Subject: Re: [PATCH] rtc: dt-binding: abx80x: fix resistance scale
Date: Thu, 22 Nov 2018 19:50:16 +0200 [thread overview]
Message-ID: <87va4pdmsn.fsf@tkos.co.il> (raw)
In-Reply-To: <20181122171819.GK12656@piout.net>
Hi Alexandre,
Alexandre Belloni writes:
> On 19/11/2018 14:34:02+0200, Baruch Siach wrote:
>> The abracon,tc-resistor property value is in KOhm.
>>
>> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>> ---
>> Documentation/devicetree/bindings/rtc/abracon,abx80x.txt | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt b/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt
>> index be789685a1c2..e668b5f65314 100644
>> --- a/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt
>> +++ b/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt
>> @@ -27,4 +27,4 @@ and valid to enable charging:
>>
>> - "abracon,tc-diode": should be "standard" (0.6V) or "schottky" (0.3V)
>> - "abracon,tc-resistor": should be <0>, <3>, <6> or <11>. 0 disables the output
>> - resistor, the other values are in ohm.
>> + resistor, the other values are in KOhm.
>
> The correct SI prefix is k so this should be kOhm. If you agree, I can
> fix this up.
I am fine with that. Please fix the commit message as well.
Thanks,
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
prev parent reply other threads:[~2018-11-22 17:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 12:34 [PATCH] rtc: dt-binding: abx80x: fix resistance scale Baruch Siach
2018-11-22 17:18 ` Alexandre Belloni
2018-11-22 17:50 ` Baruch Siach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87va4pdmsn.fsf@tkos.co.il \
--to=baruch@tkos.co.il \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.