From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: avoid rebuilding i915_gpu_error.o on version string updates Date: Wed, 21 Nov 2018 12:05:05 +0200 Message-ID: <87va4qeofi.fsf@intel.com> References: <20181121095423.20760-1-hans.ml.holmberg@owltronix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4BBCF6E503 for ; Wed, 21 Nov 2018 10:04:37 +0000 (UTC) In-Reply-To: <20181121095423.20760-1-hans.ml.holmberg@owltronix.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Hans Holmberg , David Airlie Cc: Hans Holmberg , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAyMSBOb3YgMjAxOCwgSGFucyBIb2xtYmVyZyA8aGFucy5tbC5ob2xtYmVyZ0Bvd2x0 cm9uaXguY29tPiB3cm90ZToKPiBGcm9tOiBIYW5zIEhvbG1iZXJnIDxoYW5zLmhvbG1iZXJnQGNu ZXhsYWJzLmNvbT4KPgo+IFRoZXJlIGlzIG5vIG5lZWQgdG8gcmVidWlsZCBpOTE1X2dwdV9lcnJv ci5vIHdoZW4gdGhlIHZlcnNpb24gc3RyaW5nCj4gY2hhbmdlcyBhcyB0aGUgdmVyc2lvbiBpcyBh dmFpbGFibGUgaW4gaW5pdF91dHNuYW1lKCktPnJlbGVhc2UuCj4KPiBTaWduZWQtb2ZmLWJ5OiBI YW5zIEhvbG1iZXJnIDxoYW5zLmhvbG1iZXJnQGNuZXhsYWJzLmNvbT4KCk5pY2UhCgpSZXZpZXdl ZC1ieTogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KCj4gLS0tCj4gIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3B1X2Vycm9yLmMgfCA0ICsrLS0KPiAgMSBmaWxlIGNoYW5n ZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dwdV9lcnJvci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9ncHVfZXJyb3IuYwo+IGluZGV4IDg3NjJkMTdiNjY1OS4uOTU4ZTE0ODRhM2RkIDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3B1X2Vycm9yLmMKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dwdV9lcnJvci5jCj4gQEAgLTI3LDcgKzI3LDcgQEAK PiAgICoKPiAgICovCj4gIAo+IC0jaW5jbHVkZSA8Z2VuZXJhdGVkL3V0c3JlbGVhc2UuaD4KPiAr I2luY2x1ZGUgPGxpbnV4L3V0c25hbWUuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L3N0b3BfbWFjaGlu ZS5oPgo+ICAjaW5jbHVkZSA8bGludXgvemxpYi5oPgo+ICAjaW5jbHVkZSA8ZHJtL2RybV9wcmlu dC5oPgo+IEBAIC02NTAsNyArNjUwLDcgQEAgaW50IGk5MTVfZXJyb3Jfc3RhdGVfdG9fc3RyKHN0 cnVjdCBkcm1faTkxNV9lcnJvcl9zdGF0ZV9idWYgKm0sCj4gIAo+ICAJaWYgKCplcnJvci0+ZXJy b3JfbXNnKQo+ICAJCWVycl9wcmludGYobSwgIiVzXG4iLCBlcnJvci0+ZXJyb3JfbXNnKTsKPiAt CWVycl9wcmludGYobSwgIktlcm5lbDogIiBVVFNfUkVMRUFTRSAiXG4iKTsKPiArCWVycl9wcmlu dGYobSwgIktlcm5lbDogJXNcbiIsIGluaXRfdXRzbmFtZSgpLT5yZWxlYXNlKTsKPiAgCXRzID0g a3RpbWVfdG9fdGltZXNwZWM2NChlcnJvci0+dGltZSk7Cj4gIAllcnJfcHJpbnRmKG0sICJUaW1l OiAlbGxkIHMgJWxkIHVzXG4iLAo+ICAJCSAgIChzNjQpdHMudHZfc2VjLCB0cy50dl9uc2VjIC8g TlNFQ19QRVJfVVNFQyk7CgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIEdyYXBo aWNzIENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B095CC43441 for ; Wed, 21 Nov 2018 10:04:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7937020684 for ; Wed, 21 Nov 2018 10:04:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7937020684 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729171AbeKUUiZ (ORCPT ); Wed, 21 Nov 2018 15:38:25 -0500 Received: from mga17.intel.com ([192.55.52.151]:24890 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727046AbeKUUiZ (ORCPT ); Wed, 21 Nov 2018 15:38:25 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2018 02:04:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,260,1539673200"; d="scan'208";a="109960345" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.72.61]) by fmsmga001.fm.intel.com with ESMTP; 21 Nov 2018 02:04:34 -0800 From: Jani Nikula To: Hans Holmberg , David Airlie Cc: Joonas Lahtinen , Rodrigo Vivi , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Hans Holmberg Subject: Re: [PATCH] drm/i915: avoid rebuilding i915_gpu_error.o on version string updates In-Reply-To: <20181121095423.20760-1-hans.ml.holmberg@owltronix.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20181121095423.20760-1-hans.ml.holmberg@owltronix.com> Date: Wed, 21 Nov 2018 12:05:05 +0200 Message-ID: <87va4qeofi.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 21 Nov 2018, Hans Holmberg wrote: > From: Hans Holmberg > > There is no need to rebuild i915_gpu_error.o when the version string > changes as the version is available in init_utsname()->release. > > Signed-off-by: Hans Holmberg Nice! Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_gpu_error.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c > index 8762d17b6659..958e1484a3dd 100644 > --- a/drivers/gpu/drm/i915/i915_gpu_error.c > +++ b/drivers/gpu/drm/i915/i915_gpu_error.c > @@ -27,7 +27,7 @@ > * > */ > > -#include > +#include > #include > #include > #include > @@ -650,7 +650,7 @@ int i915_error_state_to_str(struct drm_i915_error_state_buf *m, > > if (*error->error_msg) > err_printf(m, "%s\n", error->error_msg); > - err_printf(m, "Kernel: " UTS_RELEASE "\n"); > + err_printf(m, "Kernel: %s\n", init_utsname()->release); > ts = ktime_to_timespec64(error->time); > err_printf(m, "Time: %lld s %ld us\n", > (s64)ts.tv_sec, ts.tv_nsec / NSEC_PER_USEC); -- Jani Nikula, Intel Open Source Graphics Center