From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Anholt <eric@anholt.net>
Subject: Re: [PATCH 2/3] drm/vc4: Force ->x_scaling[1] should never be set to
 VC4_SCALING_NONE
Date: Thu, 08 Nov 2018 06:52:44 -0800
Message-ID: <87va57oc3n.fsf@anholt.net>
References: <20181024100505.22436-1-boris.brezillon@bootlin.com>
 <20181024100505.22436-2-boris.brezillon@bootlin.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0937897862=="
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from anholt.net (anholt.net [50.246.234.109])
 by gabe.freedesktop.org (Postfix) with ESMTP id 90BA96E65B
 for <dri-devel@lists.freedesktop.org>; Thu,  8 Nov 2018 14:52:47 +0000 (UTC)
In-Reply-To: <20181024100505.22436-2-boris.brezillon@bootlin.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
Cc: Boris Brezillon <boris.brezillon@bootlin.com>, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

--===============0937897862==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"

--=-=-=
Content-Type: text/plain

Boris Brezillon <boris.brezillon@bootlin.com> writes:

> For the YUV conversion to work properly, ->x_scaling[0,1] should never
> be set to VC4_SCALING_NONE, but vc4_get_scaling_mode() might return
> VC4_SCALING_NONE if the horizontal scaling ratio exactly matches the
> horizontal subsampling factor. Add a test to turn VC4_SCALING_NONE
> into VC4_SCALING_PPF when that happens.
>
> Fixes: fc04023fafec ("drm/vc4: Add support for YUV planes.")
> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>

I couldn't find a spec justification for this -- did you have a testcase
that fails?

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlvkTbwACgkQtdYpNtH8
nujMwA//b3RvA3xM/NfSEhUhv21NnIxlX2pTFskq1TfvonztwIE0tb+7suVKY3lj
f/5ZKXUjb071/8mayKiG8UpCp1yKubspZ7QxjFpNKdtfa2PeZYqjBYpCkTNqmGWH
miAwQn0efMhOMHUVmdNiQrPY26yImy/jHjRuGiOwgfOmmy0RdEnTNeGemLXLU4F+
1z08U1Mt1eOxYBg3gDgoIHyhcyt/cxRxcG1mw6p9ZmxxqEwySy4G1Qy8+8xZKb5F
jch6TqoHnYgRSs6AmC9tMi/4z+W3YefDX6t/vV1Yx4kDKBbo9CZdiQuvAjIIsbW2
hFotXy8kkAlfeNar0LekixskMOqnONgKyKcHRZa0z46fbjWjnjc4we6TkHuF4olW
8aysYXn6jjZEBgpodVcBHQ5cCCkBjHWfDjK+XP4IomCHVFQIiqg6i7HaKnwtpM4P
T4m02LBiqmbBcgd5ccCKi+sEeDnQgIRm6+Jugv29Sw0Cx+OGMyMf/JeN/UJxpHmD
SFWlF1/QG1ChwIYUiaRQE7ibKIu4J+8r3O+agF+2QemITSlXN35r04S5yPsZx1JF
aM4wAyTQC53pFz2lkWIUiEE+/6yZxPgCpdU4CbcMn3nJiCy26lSfSKeCWDWxBpRJ
PSMnLj2l6unYBe0CmJkYF7psTWCpYu1knzvP+lil7ZjL4nO89hM=
=jP89
-----END PGP SIGNATURE-----
--=-=-=--

--===============0937897862==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==

--===============0937897862==--