All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] font-awesome compatible with fontconfig
Date: Fri, 21 Sep 2018 08:03:32 +0300	[thread overview]
Message-ID: <87va6zsaqj.fsf@tkos.co.il> (raw)
In-Reply-To: <CAOt0XSfL9ossLTQ6Z7eBA92=XE9a1PKGbH5Pyrjcao3W3JhC_A@mail.gmail.com>

Hi Benjam?n,

Benjam?n Calder?n writes:
> the standard location for fonts is /usr/share/fonts/* and whatever is there
> can be used by other programs that use fontconfig (Qt5 in my case)
> This patch fixed the directory where font-awesome is installed from
> /usr/share/font-awesome to /usr/share/fonts/font-awesome thus it can be
> accessed by other applications and appears when running fc-list.
>
> I have tested it with Qt5 in rpi3 and with fc-list on qemu_x86_64
>
> On Thu, Sep 20, 2018 at 11:56 PM Baruch Siach <baruch@tkos.co.il> wrote:
>> Benjamin Calderon writes:
>> > This commit installs font-awesome in the standard fonts directory
>> > making it available systemwide.
>> >
>> > Signed-off-by: Benjamin Calderon <benj.calderon@gmail.com>
>> > ---
>> >  package/font-awesome/font-awesome.mk | 6 ++----
>> >  1 file changed, 2 insertions(+), 4 deletions(-)
>> >
>> > diff --git a/package/font-awesome/font-awesome.mk
>> b/package/font-awesome/font-awesome.mk
>> > index f39401041a..b1026b3c4d 100644
>> > --- a/package/font-awesome/font-awesome.mk
>> > +++ b/package/font-awesome/font-awesome.mk
>> > @@ -7,12 +7,10 @@
>> >  FONT_AWESOME_VERSION = v4.7.0
>> >  FONT_AWESOME_SITE = $(call
>> github,FortAwesome,Font-Awesome,$(FONT_AWESOME_VERSION))
>> >  FONT_AWESOME_LICENSE = OFL-1.1 (font), MIT (CSS, LESS and Sass files)
>> > -FONT_AWESOME_DIRECTORIES_LIST = css fonts less scss
>> >
>> >  define FONT_AWESOME_INSTALL_TARGET_CMDS
>> > -     mkdir -p $(TARGET_DIR)/usr/share/font-awesome/
>> > -     $(foreach d,$(FONT_AWESOME_DIRECTORIES_LIST),\
>> > -             cp -dpfr $(@D)/$(d)
>> $(TARGET_DIR)/usr/share/font-awesome$(sep))
>> > +     mkdir -p $(TARGET_DIR)/usr/share/fonts/font-awesome/

So why do we need this directory? And what about fonts in the
directories listed in FONT_AWESOME_DIRECTORIES_LIST? Aren't they useful
anymore? If so, please update the license.

baruch

>> > +     cp $(@D)/fonts/FontAwesome.otf
>> $(TARGET_DIR)/usr/share/fonts/font-awesome
>>
>> What does this patch fix? What about the fonts in other directories?
>>
>> >  endef
>> >
>> >  $(eval $(generic-package))

--
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

  reply	other threads:[~2018-09-21  5:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-21  3:16 [Buildroot] [PATCH 1/1] font-awesome compatible with fontconfig Benjamin Calderon
2018-09-21  3:56 ` Baruch Siach
2018-09-21  4:02   ` Benjamín Calderón
2018-09-21  5:03     ` Baruch Siach [this message]
     [not found]       ` <CAOt0XSc31keNicgWfc4jcn=-z43D8Vdb=0SCnVtL4POJz1QzoQ@mail.gmail.com>
2018-09-21 14:46         ` Baruch Siach
2018-09-21 14:50           ` Benjamín Calderón

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87va6zsaqj.fsf@tkos.co.il \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.