From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fYryR-0001uQ-Fb for ath10k@lists.infradead.org; Fri, 29 Jun 2018 11:54:00 +0000 From: Kalle Valo Subject: Re: [PATCH 1/3] ath10k: sdio: use same endpoint id for all packets in a bundle References: <20180620084222.3521-1-niklas.cassel@linaro.org> <20180620084222.3521-2-niklas.cassel@linaro.org> <87zhzdersm.fsf@codeaurora.org> Date: Fri, 29 Jun 2018 14:53:44 +0300 In-Reply-To: <87zhzdersm.fsf@codeaurora.org> (Kalle Valo's message of "Fri, 29 Jun 2018 14:49:29 +0300") Message-ID: <87vaa1erlj.fsf@codeaurora.org> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Niklas Cassel Cc: alagusankar@silex-india.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, "David S. Miller" Kalle Valo writes: > Niklas Cassel writes: > >> All packets in a bundle should use the same endpoint id as the >> first lookahead. >> >> This matches how things are done is ath6kl, however, >> this patch can theoretically handle several bundles >> in ath10k_sdio_mbox_rx_process_packets(). >> >> Without this patch we get lots of errors about invalid endpoint id: >> >> ath10k_sdio mmc2:0001:1: invalid endpoint in look-ahead: 224 >> ath10k_sdio mmc2:0001:1: failed to get pending recv messages: -12 >> ath10k_sdio mmc2:0001:1: failed to process pending SDIO interrupts: -12 >> >> Signed-off-by: Alagu Sankar >> Signed-off-by: Niklas Cassel > > You have Alagu's s-o-b first so that implies Alagu is the author. So > should I add From header for Alagu and add you (Niklas) as > Co-Developed-by? Or vice versa? Ah, the same issue is with all three patches. So whatever we decide, I'll do the same changes on all three. -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:51998 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933005AbeF2Lxu (ORCPT ); Fri, 29 Jun 2018 07:53:50 -0400 From: Kalle Valo To: Niklas Cassel Cc: alagusankar@silex-india.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, "David S. Miller" Subject: Re: [PATCH 1/3] ath10k: sdio: use same endpoint id for all packets in a bundle References: <20180620084222.3521-1-niklas.cassel@linaro.org> <20180620084222.3521-2-niklas.cassel@linaro.org> <87zhzdersm.fsf@codeaurora.org> Date: Fri, 29 Jun 2018 14:53:44 +0300 In-Reply-To: <87zhzdersm.fsf@codeaurora.org> (Kalle Valo's message of "Fri, 29 Jun 2018 14:49:29 +0300") Message-ID: <87vaa1erlj.fsf@codeaurora.org> (sfid-20180629_135408_739687_47FBD1B3) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: Kalle Valo writes: > Niklas Cassel writes: > >> All packets in a bundle should use the same endpoint id as the >> first lookahead. >> >> This matches how things are done is ath6kl, however, >> this patch can theoretically handle several bundles >> in ath10k_sdio_mbox_rx_process_packets(). >> >> Without this patch we get lots of errors about invalid endpoint id: >> >> ath10k_sdio mmc2:0001:1: invalid endpoint in look-ahead: 224 >> ath10k_sdio mmc2:0001:1: failed to get pending recv messages: -12 >> ath10k_sdio mmc2:0001:1: failed to process pending SDIO interrupts: -12 >> >> Signed-off-by: Alagu Sankar >> Signed-off-by: Niklas Cassel > > You have Alagu's s-o-b first so that implies Alagu is the author. So > should I add From header for Alagu and add you (Niklas) as > Co-Developed-by? Or vice versa? Ah, the same issue is with all three patches. So whatever we decide, I'll do the same changes on all three. -- Kalle Valo