From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50587) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fMHO5-0000Xg-Hy for qemu-devel@nongnu.org; Fri, 25 May 2018 14:24:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fMHO4-0004JD-Lo for qemu-devel@nongnu.org; Fri, 25 May 2018 14:24:25 -0400 From: Juan Quintela In-Reply-To: <1527266793-301361-16-git-send-email-mst@redhat.com> (Michael S. Tsirkin's message of "Fri, 25 May 2018 19:48:04 +0300") References: <1527266793-301361-1-git-send-email-mst@redhat.com> <1527266793-301361-16-git-send-email-mst@redhat.com> Reply-To: quintela@redhat.com Date: Fri, 25 May 2018 20:27:03 +0200 Message-ID: <87vabb1thk.fsf@secure.laptop> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v2 15/20] migration: use local path for local headers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, eblake@redhat.com, peter.maydell@linaro.org, Stefan Hajnoczi , Fam Zheng , "Dr. David Alan Gilbert" , qemu-block@nongnu.org "Michael S. Tsirkin" wrote: > When pulling in headers that are in the same directory as C file (as > opposed to one in include/), we should use its relative path, without a > directory. Directory based path works more or less by accident. I don't agree with the comment that they work by accident, it is "by-design". But if you want to change the design, I agree with removing "$ROOT" from the default include path. > > Signed-off-by: Michael S. Tsirkin Reviewed-by: Juan Quintela Later, Juan.