From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: vc4: Detect working driver from cmdline Date: Mon, 21 May 2018 10:55:01 -0700 Message-ID: <87vabgdhca.fsf@anholt.net> References: <2128012459.52582.1526639683667@email.1und1.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0326124342==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id ED9346E4BA for ; Mon, 21 May 2018 17:55:04 +0000 (UTC) In-Reply-To: <2128012459.52582.1526639683667@email.1und1.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Stefan Wahren , Boris Brezillon , "Schake, Stefan" Cc: khilman@baylibre.com, dri-devel List-Id: dri-devel@lists.freedesktop.org --===============0326124342== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Stefan Wahren writes: > Hi, > in order to improve kernelci.org results and avoid false positive cases like this [1], i suggested to also test for a working VC4 driver. In order to keep it simple, we should do it from userspace. > > My first idea was: > > test -d /sys/kernel/debug/dri/0 || echo "Error case" > > But maybe you have a better / more reliable solution? > > [1] - https://storage.kernelci.org/mainline/master/v4.17-rc5-69-g3acf4e395260/arm64/defconfig/lab-mhart/boot-bcm2837-rpi-3-b.html GL testing involves running piglit and comparing to a previous run to confirm no regressions, and we're building out the intel-gpu-tools support for display testing now. That's what you'd need to make sure the driver actually works. If you just want to make sure module probe doesn't fail, I guess that test is fine (it would catch bugs we've seen in the past). --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlsDB/UACgkQtdYpNtH8 nuhvMw/8D163a6HZ6UYRhHwEd6SR6t8Sf04KPplJqisoh/O/ST5+L+DfTCrx+MDl cTkIjtJpQSqpzgEfO7Xv6OaPkCoT9YLxumSPTWXm8VUXjo8tVtbtLe9fJRcAyyqQ lLW9ZBS1OePYzj9b1OLlphraey/C+pkletO6ieZCF2Qpl2gkf3L9nsF/OP+fwIHq xEsIFp1xRndCT1D6knIV8yPMKun0+dVMoST7yYFsgp9wLVFoq5aXvg/mDgqh4J1H jhiqOpX1HKdX5cJSSu8MIwafpCUKJG5XfWvMEbuAqYW0gmSz67HwxkZSAClDKwdQ 1cRjarUoTDnf69zRIjVLGzX3lCamVlrXjY1q9kE8UHHlOfUB8RdXeEstkc6DD2Hk n1++G6bMkmnzDXTOQjDFVtOOIQGo7z7NTpXq1CtQSWK37N+S49WxAxG5K1WQ8ugB XgoNHqlUPdcTtIhgcdHO2oBDG/SFD9MFOVMZqtvzC/DuoooLLSHQv2mFCr0zGe6x 56aAqTODd6xcfgEMlEeav6wfpzpiPplqhZ7zr5GiXR4aSu/P1GCfANN77RqKam6N 8xzF/+BBNtzh7lVAh2zzxfjTfrGuZB62QPjZ7ieZV8W6m4D7Qd9phTR5Tbbdl7Kb ReMaoBf907rx+Gd8Hm76XjH0SwaWlPdnH/b+U2SOqnhM4287VbQ= =qVbp -----END PGP SIGNATURE----- --=-=-=-- --===============0326124342== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0326124342==--