From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3/3] net: Dynamically allocate struct station_info
Date: Wed, 09 May 2018 23:36:27 +0200 [thread overview]
Message-ID: <87vabwy0is.fsf@toke.dk> (raw)
In-Reply-To: <1525901625.6910.33.camel@sipsolutions.net>
Johannes Berg <johannes@sipsolutions.net> writes:
>> WARN_ON is used where the function has no way to signal errors to the
>> caller.
>
> There isn't really much point in that - failing allocations are already
> *very* noisy. Please respin with that removed (and then I guess you can
> fix the Fixes: too)
OK, will do.
> You didn't actually do that in this patch though :-)
Well, I may have copy-pasted that from the commit message of the
previous patch ;)
> It's bool so you don't need the !!(...) :-)
But what if I want it to be extra super duper bool? ;)
-Toke
next prev parent reply other threads:[~2018-05-09 21:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 12:13 [PATCH 1/3] wireless-drivers: Dynamically allocate struct station_info Toke Høiland-Jørgensen
2018-05-09 12:13 ` [PATCH 3/3] net: " Toke Høiland-Jørgensen
2018-05-09 21:33 ` Johannes Berg
2018-05-09 21:36 ` Toke Høiland-Jørgensen [this message]
2018-05-09 22:55 ` kbuild test robot
2018-05-09 23:07 ` Toke Høiland-Jørgensen
2018-05-10 0:06 ` kbuild test robot
2018-05-09 12:13 ` [PATCH 2/3] staging: " Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vabwy0is.fsf@toke.dk \
--to=toke@toke.dk \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.