From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: Disable some extra clang warnings Date: Mon, 19 Mar 2018 10:21:34 +0200 Message-ID: <87vads1nn5.fsf@intel.com> References: <20180317003151.252750-1-mka@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180317003151.252750-1-mka@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Joonas Lahtinen , Rodrigo Vivi , David Airlie Cc: Guenter Roeck , intel-gfx@lists.freedesktop.org, Matthias Kaehlcke , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAxNiBNYXIgMjAxOCwgTWF0dGhpYXMgS2FlaGxja2UgPG1rYUBjaHJvbWl1bS5vcmc+ IHdyb3RlOgo+IENvbW1pdCAzOWJmNGRlODlmZjcgKCJkcm0vaTkxNTogQWRkIC1XYWxsIC1XZXh0 cmEgdG8gb3VyIGJ1aWxkLCBzZXQKPiB3YXJuaW5ncyB0byBmdWxsIikgZW5hYmxlZCBleHRyYSB3 YXJuaW5ncyBmb3IgaTkxNSB0byBzcG90IHBvc3NpYmxlCj4gYnVncyBpbiBuZXcgY29kZSwgYW5k IHRoZW4gZGlzYWJsZWQgYSBzdWJzZXQgb2YgdGhlc2Ugd2FybmluZ3MgdG8ga2VlcAo+IHRoZSBj dXJyZW50IGNvZGUgYnVpbGRpbmcgd2l0aG91dCB3YXJuaW5ncyAod2l0aCBnY2MpLiBFbmFibGlu ZyB0aGUKPiBleHRyYSB3YXJuaW5ncyBhbHNvIGVuYWJsZWQgc29tZSBhZGRpdGlvbmFsIGNsYW5n LW9ubHkgd2FybmluZ3MsIGFzIGEKPiByZXN1bHQgYnVpbGRpbmcgaTkxNSB3aXRoIGNsYW5nIGN1 cnJlbnRseSBpcyBleHRyZW1lbHkgbm9pc3kuIEZvciBub3cKPiBhbHNvIGRpc2FibGUgdGhlIGNs YW5nIHdhcm5pbmdzIHNpZ24tY29tcGFyZSwgc29tZXRpbWVzLXVuaW5pdGlhbGl6ZWQsCj4gdW5u ZWVkZWQtaW50ZXJuYWwtZGVjbGFyYXRpb24gYW5kIGluaXRpYWxpemVyLW92ZXJyaWRlcy4gSWYg ZGVzaXJlZAo+IHRoZXkgY2FuIGJlIHJlLWVuYWJsZWQgYWZ0ZXIgdGhlIGNvZGUgaGFzIGJlZW4g Zml4ZWQuCj4KPiBGaXhlczogMzliZjRkZTg5ZmY3ICgiZHJtL2k5MTU6IEFkZCAtV2FsbCAtV2V4 dHJhIHRvIG91ciBidWlsZCwgc2V0Cj4gd2FybmluZ3MgdG8gZnVsbCIpCj4gU2lnbmVkLW9mZi1i eTogTWF0dGhpYXMgS2FlaGxja2UgPG1rYUBjaHJvbWl1bS5vcmc+CgpUaGFua3MgZm9yIHRoZSBw YXRjaCwgSSB0aGluayBpdCdzIHRoZSByaWdodCB0aGluZyB0byBkby4gSSdtIGFmcmFpZCBpdApk b2Vzbid0IGFwcGx5IHRvIGN1cnJlbnQgY29kZSwgaG93ZXZlci4gUGxlYXNlIHJlYmFzZSBvbiB0 b3Agb2YgZHJtLXRpcApicmFuY2ggb2YgWzFdLgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvTWFrZWZpbGUgfCA0ICsrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKQo+ Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L01ha2VmaWxlIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvTWFrZWZpbGUKPiBpbmRleCAwOTFhZWYyODE5NjMuLmFkMDU3OTZhOTZiYSAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9NYWtlZmlsZQo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L01ha2VmaWxlCj4gQEAgLTE3LDYgKzE3LDEwIEBAIHN1YmRpci1jY2Zs YWdzLXkgKz0gJChjYWxsIGNjLWRpc2FibGUtd2FybmluZywgdW51c2VkLXBhcmFtZXRlcikKPiAg c3ViZGlyLWNjZmxhZ3MteSArPSAkKGNhbGwgY2MtZGlzYWJsZS13YXJuaW5nLCB0eXBlLWxpbWl0 cykKPiAgc3ViZGlyLWNjZmxhZ3MteSArPSAkKGNhbGwgY2MtZGlzYWJsZS13YXJuaW5nLCBtaXNz aW5nLWZpZWxkLWluaXRpYWxpemVycykKPiAgc3ViZGlyLWNjZmxhZ3MteSArPSAkKGNhbGwgY2Mt ZGlzYWJsZS13YXJuaW5nLCBpbXBsaWNpdC1mYWxsdGhyb3VnaCkKCldoaWxlIGF0IGl0LCBwbGVh c2UgYWRkIGEgY29tbWVudCBoZXJlIG5vdGluZyB0aGF0IHRoZSBiZWxvdyBkaXNhYmxlcwphcmUg Zm9yIENsYW5nLgoKVGhhbmtzLApKYW5pLgoKWzFdIGh0dHBzOi8vYnVncy5mcmVlZGVza3RvcC5v cmcvZW50ZXJfYnVnLmNnaT9wcm9kdWN0PURSSSZjb21wb25lbnQ9RFJNL0ludGVsCgoKPiArc3Vi ZGlyLWNjZmxhZ3MteSArPSAkKGNhbGwgY2MtZGlzYWJsZS13YXJuaW5nLCBzaWduLWNvbXBhcmUp Cj4gK3N1YmRpci1jY2ZsYWdzLXkgKz0gJChjYWxsIGNjLWRpc2FibGUtd2FybmluZywgc29tZXRp bWVzLXVuaW5pdGlhbGl6ZWQpCj4gK3N1YmRpci1jY2ZsYWdzLXkgKz0gJChjYWxsIGNjLWRpc2Fi bGUtd2FybmluZywgdW5uZWVkZWQtaW50ZXJuYWwtZGVjbGFyYXRpb24pCj4gK3N1YmRpci1jY2Zs YWdzLXkgKz0gJChjYWxsIGNjLWRpc2FibGUtd2FybmluZywgaW5pdGlhbGl6ZXItb3ZlcnJpZGVz KQo+ICBzdWJkaXItY2NmbGFncy0kKENPTkZJR19EUk1fSTkxNV9XRVJST1IpICs9IC1XZXJyb3IK PiAgCj4gICMgRmluZSBncmFpbmVkIHdhcm5pbmdzIGRpc2FibGUKCi0tIApKYW5pIE5pa3VsYSwg SW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932322AbeCSIVx (ORCPT ); Mon, 19 Mar 2018 04:21:53 -0400 Received: from mga18.intel.com ([134.134.136.126]:50957 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753013AbeCSIVu (ORCPT ); Mon, 19 Mar 2018 04:21:50 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,329,1517904000"; d="scan'208";a="25155646" From: Jani Nikula To: Matthias Kaehlcke , Joonas Lahtinen , Rodrigo Vivi , David Airlie Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Guenter Roeck , Matthias Kaehlcke Subject: Re: [PATCH] drm/i915: Disable some extra clang warnings In-Reply-To: <20180317003151.252750-1-mka@chromium.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20180317003151.252750-1-mka@chromium.org> Date: Mon, 19 Mar 2018 10:21:34 +0200 Message-ID: <87vads1nn5.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 16 Mar 2018, Matthias Kaehlcke wrote: > Commit 39bf4de89ff7 ("drm/i915: Add -Wall -Wextra to our build, set > warnings to full") enabled extra warnings for i915 to spot possible > bugs in new code, and then disabled a subset of these warnings to keep > the current code building without warnings (with gcc). Enabling the > extra warnings also enabled some additional clang-only warnings, as a > result building i915 with clang currently is extremely noisy. For now > also disable the clang warnings sign-compare, sometimes-uninitialized, > unneeded-internal-declaration and initializer-overrides. If desired > they can be re-enabled after the code has been fixed. > > Fixes: 39bf4de89ff7 ("drm/i915: Add -Wall -Wextra to our build, set > warnings to full") > Signed-off-by: Matthias Kaehlcke Thanks for the patch, I think it's the right thing to do. I'm afraid it doesn't apply to current code, however. Please rebase on top of drm-tip branch of [1]. > --- > drivers/gpu/drm/i915/Makefile | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile > index 091aef281963..ad05796a96ba 100644 > --- a/drivers/gpu/drm/i915/Makefile > +++ b/drivers/gpu/drm/i915/Makefile > @@ -17,6 +17,10 @@ subdir-ccflags-y += $(call cc-disable-warning, unused-parameter) > subdir-ccflags-y += $(call cc-disable-warning, type-limits) > subdir-ccflags-y += $(call cc-disable-warning, missing-field-initializers) > subdir-ccflags-y += $(call cc-disable-warning, implicit-fallthrough) While at it, please add a comment here noting that the below disables are for Clang. Thanks, Jani. [1] https://bugs.freedesktop.org/enter_bug.cgi?product=DRI&component=DRM/Intel > +subdir-ccflags-y += $(call cc-disable-warning, sign-compare) > +subdir-ccflags-y += $(call cc-disable-warning, sometimes-uninitialized) > +subdir-ccflags-y += $(call cc-disable-warning, unneeded-internal-declaration) > +subdir-ccflags-y += $(call cc-disable-warning, initializer-overrides) > subdir-ccflags-$(CONFIG_DRM_I915_WERROR) += -Werror > > # Fine grained warnings disable -- Jani Nikula, Intel Open Source Technology Center