From: Stewart Smith <stewart@linux.vnet.ibm.com>
To: Deepak Kodihalli <dkodihal@linux.vnet.ibm.com>,
Brad Bishop <bradleyb@fuzziesquirrel.com>,
geissonator@gmail.com, anoo@linux.vnet.ibm.com
Cc: OpenBMC Maillist <openbmc@lists.ozlabs.org>
Subject: Re: Parse PELs sent by OpenPOWER host firmware
Date: Wed, 14 Mar 2018 11:36:56 +1100 [thread overview]
Message-ID: <87vadzo5lj.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <2815fac8-3a1f-d2ed-3c3d-ca7072de9db2@linux.vnet.ibm.com>
Deepak Kodihalli <dkodihal@linux.vnet.ibm.com> writes:
> The SELs/eSELs (System Event Log) that OpenBMC receives from
> hostboot/skiboot today are not interpreted, and are dumped as-is in a
> property of the error log D-Bus object. This means that if there's a PEL
> (Platform Event Log) hidden in the eSEL, admins/users of the error log
> need to depend on external tools to parse the PEL to human readable
> text.
My lack of love for PELs is probably fairly well known, but even if we
replace them down the line, I think there's opportunity here for making
things better for users (including myself).
> Here's a proposal to have the BMC itself parse such eSELs (the
> motivation is to make the OpenBMC error logs more useful in this
> context, without needing the extra steps to parse such errors) :
>
> - Separate this from phosphor-logging. This code can't go to a phosphor
> app, because it's OpenPOWER specific. Have, for example, an
> openpower-logging app implement a D-Bus interface to parse out a PEL
> from an eSEL. This app will host it's own D-Bus service.
It would be a bonus if we could take different actions based on log
format. If in the future we had a hypothetical other format, it'd be
great if it was *really* easy to plug into OpenBMC. I suspect other
platforms may have similar things (e.g. Google has done protobuf based
logs in the past at least, which are structurally somewhat similar to
PELs but different serialisation format).
> - Such an app can watch for error D-Bus objects being created in the
> phosphor namespace. If it finds an eSEL in an error log, it can attempt
> to parse a PEL (if there's one), and store the PELs parsed text
> representation in a D-Bus property.
>
> - The app can create a D-Bus object with the same path as the original
> object and have a D-Bus object-manager at the error log root path, so
> that when someone uses the OpenBMC REST API to read an error log,
> properties across all D-Bus services will be returned
> (phosphor-rest-server does this today already). This means with the
> existing REST API to enumerate error logs, a parsed PEL would be
> returned, if present.
Is thre any reason for this approach rather than something like
phosphor-logging having a list of properties/formats and external
parsing tools? Kind of like mime type/action lists?
> - To parse the PEL, use opal-elog-parse.
+1
--
Stewart Smith
OPAL Architect, IBM.
next prev parent reply other threads:[~2018-03-14 0:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 13:39 Parse PELs sent by OpenPOWER host firmware Deepak Kodihalli
2018-03-14 0:36 ` Stewart Smith [this message]
2018-04-09 10:47 ` Alexander Amelkin
2018-04-12 5:32 ` Stewart Smith
2018-03-19 6:13 ` Vasant Hegde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vadzo5lj.fsf@linux.vnet.ibm.com \
--to=stewart@linux.vnet.ibm.com \
--cc=anoo@linux.vnet.ibm.com \
--cc=bradleyb@fuzziesquirrel.com \
--cc=dkodihal@linux.vnet.ibm.com \
--cc=geissonator@gmail.com \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.