From: Andi Kleen <ak@linux.intel.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Mikael Pettersson <mikpelinux@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org
Subject: Re: [PATCH] mm: disable `vm.max_map_count' sysctl limit
Date: Mon, 27 Nov 2017 09:25:16 -0800 [thread overview]
Message-ID: <87vahv8whv.fsf@linux.intel.com> (raw)
In-Reply-To: <20171127101232.ykriowhatecnvjvg@dhcp22.suse.cz> (Michal Hocko's message of "Mon, 27 Nov 2017 11:12:32 +0100")
Michal Hocko <mhocko@kernel.org> writes:
>
> Could you be more explicit about _why_ we need to remove this tunable?
> I am not saying I disagree, the removal simplifies the code but I do not
> really see any justification here.
It's an arbitrary scaling limit on the how many mappings the process
has. The more memory you have the bigger a problem it is. We've
ran into this problem too on larger systems.
The reason the limit was there originally because it allows a DoS
attack against the kernel by filling all unswappable memory up with VMAs.
The old limit was designed for much smaller systems than we have
today.
There needs to be some limit, but it should be on the number of memory
pinned by the VMAs, and needs to scale with the available memory,
so that large systems are not penalized.
Unfortunately just making it part of the existing mlock limit could
break some existing setups which max out the mlock limit with something
else. Maybe we need a new rlimit for this?
-Andi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <ak@linux.intel.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Mikael Pettersson <mikpelinux@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org
Subject: Re: [PATCH] mm: disable `vm.max_map_count' sysctl limit
Date: Mon, 27 Nov 2017 09:25:16 -0800 [thread overview]
Message-ID: <87vahv8whv.fsf@linux.intel.com> (raw)
In-Reply-To: <20171127101232.ykriowhatecnvjvg@dhcp22.suse.cz> (Michal Hocko's message of "Mon, 27 Nov 2017 11:12:32 +0100")
Michal Hocko <mhocko@kernel.org> writes:
>
> Could you be more explicit about _why_ we need to remove this tunable?
> I am not saying I disagree, the removal simplifies the code but I do not
> really see any justification here.
It's an arbitrary scaling limit on the how many mappings the process
has. The more memory you have the bigger a problem it is. We've
ran into this problem too on larger systems.
The reason the limit was there originally because it allows a DoS
attack against the kernel by filling all unswappable memory up with VMAs.
The old limit was designed for much smaller systems than we have
today.
There needs to be some limit, but it should be on the number of memory
pinned by the VMAs, and needs to scale with the available memory,
so that large systems are not penalized.
Unfortunately just making it part of the existing mlock limit could
break some existing setups which max out the mlock limit with something
else. Maybe we need a new rlimit for this?
-Andi
next prev parent reply other threads:[~2017-11-27 17:25 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-26 16:09 [PATCH] mm: disable `vm.max_map_count' sysctl limit Mikael Pettersson
2017-11-26 16:09 ` Mikael Pettersson
2017-11-26 16:09 ` Mikael Pettersson
2017-11-27 10:12 ` Michal Hocko
2017-11-27 10:12 ` Michal Hocko
2017-11-27 16:22 ` Matthew Wilcox
2017-11-27 16:22 ` Matthew Wilcox
[not found] ` <20171127162207.GA8265-PfSpb0PWhxZc2C7mugBRk2EX/6BAtgUQ@public.gmane.org>
2017-11-27 19:28 ` Mikael Pettersson
2017-11-27 19:28 ` Mikael Pettersson
2017-11-27 19:28 ` Mikael Pettersson
2017-11-27 17:25 ` Andi Kleen [this message]
2017-11-27 17:25 ` Andi Kleen
[not found] ` <87vahv8whv.fsf-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-11-27 18:32 ` Michal Hocko
2017-11-27 18:32 ` Michal Hocko
2017-11-27 18:32 ` Michal Hocko
2017-11-27 19:57 ` Michal Hocko
2017-11-27 19:57 ` Michal Hocko
[not found] ` <20171127195732.3hkfx57d3ytyccvp-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2017-11-27 20:21 ` Andi Kleen
2017-11-27 20:21 ` Andi Kleen
2017-11-27 20:21 ` Andi Kleen
2017-11-27 20:52 ` Michal Hocko
2017-11-27 20:52 ` Michal Hocko
2017-11-27 19:36 ` Mikael Pettersson
2017-11-27 19:36 ` Mikael Pettersson
[not found] ` <20171127101232.ykriowhatecnvjvg-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2017-11-27 19:18 ` Mikael Pettersson
2017-11-27 19:18 ` Mikael Pettersson
2017-11-27 19:18 ` Mikael Pettersson
[not found] ` <CAM43=SPVvBTPz31Uu=iz3fpS9tb75uSmL=pYP3AfsfmYr9u4Og-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-11-27 19:52 ` Michal Hocko
2017-11-27 19:52 ` Michal Hocko
2017-11-27 19:52 ` Michal Hocko
[not found] ` <20171127195207.vderbbkbgygawuhx-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2017-11-27 23:26 ` John Hubbard
2017-11-27 23:26 ` John Hubbard
2017-11-27 23:26 ` John Hubbard
2017-11-27 23:26 ` John Hubbard
2017-11-28 8:12 ` Michal Hocko
2017-11-28 8:12 ` Michal Hocko
2017-11-29 5:14 ` John Hubbard
2017-11-29 5:14 ` John Hubbard
2017-11-29 5:14 ` John Hubbard
[not found] ` <5ca7d54b-5ae4-646d-f3a0-9b85129c9ccf-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2017-11-29 8:32 ` Michal Hocko
2017-11-29 8:32 ` Michal Hocko
2017-11-29 8:32 ` Michal Hocko
-- strict thread matches above, loose matches on Subject: below --
2017-11-27 19:46 Alexey Dobriyan
2017-11-27 19:46 ` Alexey Dobriyan
2017-11-27 19:47 ` Alexey Dobriyan
2017-11-27 19:47 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vahv8whv.fsf@linux.intel.com \
--to=ak@linux.intel.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mikpelinux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.