From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.2 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD, UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 3101620281 for ; Thu, 2 Nov 2017 22:26:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934536AbdKBW0p convert rfc822-to-8bit (ORCPT ); Thu, 2 Nov 2017 18:26:45 -0400 Received: from marcos.anarc.at ([206.248.172.91]:36030 "EHLO marcos.anarc.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934407AbdKBW0o (ORCPT ); Thu, 2 Nov 2017 18:26:44 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: anarcat) with ESMTPSA id 345711A00AA From: =?utf-8?Q?Antoine_Beaupr=C3=A9?= To: Thomas Adam Cc: git@vger.kernel.org Subject: Re: [PATCH v3 7/7] remote-mediawiki: show progress while fetching namespaces In-Reply-To: <20171102221807.juon446b6zfw64cq@laptop.local> Organization: Debian References: <20171030025142.19421-1-anarcat@debian.org> <20171102212518.1601-1-anarcat@debian.org> <20171102212518.1601-8-anarcat@debian.org> <20171102221807.juon446b6zfw64cq@laptop.local> Date: Thu, 02 Nov 2017 18:26:43 -0400 Message-ID: <87vais48rg.fsf@curie.anarc.at> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 2017-11-02 22:18:07, Thomas Adam wrote: > Hi, > > On Thu, Nov 02, 2017 at 05:25:18PM -0400, Antoine Beaupré wrote: >> + print {*STDERR} "$#{$mw_pages} found in namespace $local_namespace ($namespace_id)\n"; > > How is this any different to using warn()? I appreciate you're using a > globbed filehandle, but it seems superfluous to me. It's what is used everywhere in the module, I'm just tagging along. This was discussed before: there's an issue about cleaning up the messaging in that module, that can be fixed separately. A. -- N'aimer qu'un seul est barbarie, car c'est au détriment de tous les autres. Fût-ce l'amour de Dieu. - Nietzsche, "Par delà le bien et le mal"