From: "Lluís Vilanova" <vilanova@ac.upc.edu>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH] tcg: Initialize cpu_env generically
Date: Thu, 12 Oct 2017 23:32:39 +0300 [thread overview]
Message-ID: <87vajkgl94.fsf@frigg.lan> (raw)
In-Reply-To: <888cfe83-7c47-5673-7b1b-8280cc50d8ba@linaro.org> (Richard Henderson's message of "Thu, 12 Oct 2017 07:45:30 -0700")
Richard Henderson writes:
> On 10/11/2017 11:43 PM, Lluís Vilanova wrote:
>>> /* Track which vCPU triggers events */
>>> CPUState *cpu; /* *_trans */
>>> - TCGv_env tcg_env; /* *_exec */
>>
>> I would rather keep it here instead of making a new global variable, since that
>> should make it easier in the future to have multiple translation contexts.
> Why do you believe this prevents it? The variable is literally identical for
> *all* targets.
If someone decides to make tcg_ctx thread-local or have one per target
architecture (supporting multiple target archs concurrently), having all that
info on the tcg_ctx object is easier to track and modify, compared to having
multiple global variables.
> r~
> PS: Everyone, please trim context that you don't care about. If you just add
> two lines in the middle of 1000, I'll not always find it.
So true; I just went with the flow of the list, sorry.
Cheers,
Lluis
next prev parent reply other threads:[~2017-10-12 20:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 21:45 [Qemu-devel] [PATCH] tcg: Initialize cpu_env generically Richard Henderson
2017-10-10 22:44 ` Philippe Mathieu-Daudé
2017-10-10 23:41 ` Emilio G. Cota
2017-10-12 6:43 ` Lluís Vilanova
2017-10-12 14:45 ` Richard Henderson
2017-10-12 20:32 ` Lluís Vilanova [this message]
2017-10-12 21:05 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vajkgl94.fsf@frigg.lan \
--to=vilanova@ac.upc.edu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.