From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751727AbdG0H4g (ORCPT ); Thu, 27 Jul 2017 03:56:36 -0400 Received: from mga01.intel.com ([192.55.52.88]:42257 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751678AbdG0H4e (ORCPT ); Thu, 27 Jul 2017 03:56:34 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,419,1496127600"; d="asc'?scan'208";a="130043701" From: Felipe Balbi To: Lu Baolu , Mathias Nyman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, zhengjun.xing@linux.intel.com, Lu Baolu Subject: Re: [PATCH v2 5/5] usb: xhci: Handle USB transaction error on address command In-Reply-To: <1501122098-10935-6-git-send-email-baolu.lu@linux.intel.com> References: <1501122098-10935-1-git-send-email-baolu.lu@linux.intel.com> <1501122098-10935-6-git-send-email-baolu.lu@linux.intel.com> Date: Thu, 27 Jul 2017 10:55:57 +0300 Message-ID: <87vame2u0i.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Lu Baolu writes: > Xhci driver handles USB transaction errors on transfer events, > but transaction errors are possible on address device command > completion events as well. > > The xHCI specification (section 4.6.5) says: A USB Transaction > Error Completion Code for an Address Device Command may be due > to a Stall response from a device. Software should issue a Disable > Slot Command for the Device Slot then an Enable Slot Command to > recover from this error. > > This patch handles USB transaction errors on address command > completion events. The related discussion threads can be found > through below links. > > http://marc.info/?l=3Dlinux-usb&m=3D149362010728921&w=3D2 > http://marc.info/?l=3Dlinux-usb&m=3D149252752825755&w=3D2 > > Suggested-by: Mathias Nyman > Signed-off-by: Lu Baolu > --- > drivers/usb/host/xhci.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c > index d6b728d..95780f8 100644 > --- a/drivers/usb/host/xhci.c > +++ b/drivers/usb/host/xhci.c > @@ -3822,6 +3822,11 @@ static int xhci_setup_device(struct usb_hcd *hcd, = struct usb_device *udev, > break; > case COMP_USB_TRANSACTION_ERROR: > dev_warn(&udev->dev, "Device not responding to setup %s.\n", act); > + > + ret =3D xhci_disable_slot(xhci, udev->slot_id); > + if (!ret) > + xhci_alloc_dev(hcd, udev); aren't you leaking previously allocated virt_dev ? =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAll5nI0ACgkQzL64meEa mQZMZBAAh7ftg/XUiuDVCYAeVKyhqPbdT9zzfTLzTrkbbObEoEf65oHR9gKo0Oi5 vkHxxkUir6MNklxEeGh8KXYUVyCscgRqvaTWkch+eBOXYn6OhufAqxKIJS1R5Dz/ El9iiGYEblTtzxdF15zOrV5e0fcVTkIh577XQUM1WkV9e/BdhtF3NZT1IqnsC/mO 6L1PLQE8OW0AJAL7POa9BCSwkvbhRZoHB6+Sak24bPvvPxzF+x95EzJnXmyAKQb2 lAi4FP6rDbzGoUxViG7pPjqsS/xBUuRu9lUCQTzNIS1+jMyNhWdJrI4i1VegRPGz Fx2CP1SwkzGKREy/ddCESVoyfl3U/H0UEC8L+7EfSTLkeDcitmX75RAxI58FHBD9 g3HuHxTMsl4Ifi6gcH+S1oUKJJ2fxyLCLzV6wrBCsIQo7tBWdU6ob1ijYTeOHGnb sTWt2TR98Ed7Am407G6PpcpxIN5ot2TrSZWTVzSRz1wsAaDp7SWNuBpJ99n3zMNe 2dkcVTaxmQYKjw3egg0fOQuhDJSSTVj3R6vD175ec2VBTdRznJEWDUz7Tw5Wf+Mf H+9c1djdSsGeJyZDgeal7gvuQzd7bhZ1P5sRxjUGH79VIScTKhFyQTlQ7SiedR4N 414nx5DzwCp48MszivpyP/PL7UJRFV0lG9UrCI7fVhsP8LO6mgU= =saal -----END PGP SIGNATURE----- --=-=-=--