From: Kalle Valo <kvalo@codeaurora.org>
To: Brian Norris <briannorris@chromium.org>
Cc: Shawn Lin <shawn.lin@rock-chips.com>,
Amitkumar Karwar <amitkarwar@gmail.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
Nishant Sarmukadam <nishants@marvell.com>,
Xinming Hu <huxm@marvell.com>
Subject: Re: [PATCH] mwifiex: fix compile warning of unused variable
Date: Tue, 25 Jul 2017 15:33:31 +0300 [thread overview]
Message-ID: <87vamgitlw.fsf@codeaurora.org> (raw)
In-Reply-To: <20170706171152.GA120202@google.com> (Brian Norris's message of "Thu, 6 Jul 2017 10:11:53 -0700")
Brian Norris <briannorris@chromium.org> writes:
> On Thu, Jul 06, 2017 at 03:50:33PM +0800, Shawn Lin wrote:
>> We got a compile warning shows below:
>>
>> drivers/net/wireless/marvell/mwifiex/sdio.c: In function
>> 'mwifiex_sdio_remove':
>> drivers/net/wireless/marvell/mwifiex/sdio.c:377:6: warning: variable
>> 'ret' set but not used [-Wunused-but-set-variable]
>
> It's probably worth noting that this is not a default warning [1],
> especially if you resend. It already confused Kalle.
Exactly, that way I can prioritise the patch accordingly. (W=1 warnings
are not that important so they go automatically to -next)
--
Kalle Valo
next prev parent reply other threads:[~2017-07-25 12:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 7:50 [PATCH] mwifiex: fix compile warning of unused variable Shawn Lin
2017-07-06 7:50 ` Shawn Lin
2017-07-06 7:57 ` Kalle Valo
2017-07-06 8:18 ` Shawn Lin
2017-07-06 17:11 ` Brian Norris
2017-07-25 12:33 ` Kalle Valo [this message]
2017-07-28 14:50 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vamgitlw.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=amitkarwar@gmail.com \
--cc=briannorris@chromium.org \
--cc=huxm@marvell.com \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nishants@marvell.com \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.