From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm: Reduce scope of 'state' variable Date: Thu, 15 Jun 2017 18:10:34 +0300 Message-ID: <87vanxxp5h.fsf@intel.com> References: <20170615104142.GA29276@gmail.com> <871sqlzewc.fsf@intel.com> <20170615142430.GA13398@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 98B436E731 for ; Thu, 15 Jun 2017 15:10:38 +0000 (UTC) In-Reply-To: <20170615142430.GA13398@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dawid Kurek Cc: Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCAxNSBKdW4gMjAxNywgRGF3aWQgS3VyZWsgPGRhd2lrdXJAZ21haWwuY29tPiB3cm90 ZToKPiBPbiAxNS8wNi8xNywgSmFuaSBOaWt1bGEgd3JvdGU6Cj4+IFNlcGFyYXRlIGRlY2xhcmF0 aW9uIGFuZCBpbml0aWFsaXphdGlvbiB3b3VsZCBsZWFkIHRvIGEgY2xlYW5lciBwYXRjaAo+PiBh bmQgcmVzdWx0Lgo+Cj4gSSBzYXcgY29tYmluaW5nIGRlY2xhcmF0aW9uIGFuZCBpbml0aWFsaXph dGlvbiBpcyBxdWl0ZSBjb21tb24sIGkuZS4gaW4KPiBkcm1fYXRvbWljIGZpbGUuIFBlcnNvbmFs bHksIEkgYWxzbyBwcmVmZXIgdGhvc2UgaW4gb25lIHN0YXRlbWVudC4gQnV0IHllcywgaXQKPiBs b29rcyBjbGVhbmVyIGhlcmUsIGluIHR3byBsaW5lcy4KCkknZCBzYXkgdGhlIHJ1bGUgb2YgdGh1 bWIgaXMgdGhhdCBjb21iaW5lZCBkZWNsYXJhdGlvbiBhbmQKaW5pdGlhbGl6YXRpb24gaXMgZmlu ZSBpZiB0aGUgaW5pdGlhbGl6YXRpb24gaXMgdHJpdmlhbCwgaW4gcGFydGljdWxhcgpjYW4gbmV2 ZXIgZmFpbC4gSWYgeW91IG5lZWQgdG8gY2hlY2sgdGhlIHJldHVybiB2YWx1ZSwgbGlrZSBpbiB0 aGlzCmNhc2UsIEknZCBwcmVmZXIgc2VwYXJhdGUgaW5pdGlhbGl6YXRpb24uCgpCUiwKSmFuaS4K CgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753137AbdFOPKj (ORCPT ); Thu, 15 Jun 2017 11:10:39 -0400 Received: from mga07.intel.com ([134.134.136.100]:27694 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753098AbdFOPKi (ORCPT ); Thu, 15 Jun 2017 11:10:38 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,343,1493708400"; d="scan'208";a="868307213" From: Jani Nikula To: Dawid Kurek Cc: Daniel Vetter , Sean Paul , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: Reduce scope of 'state' variable In-Reply-To: <20170615142430.GA13398@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20170615104142.GA29276@gmail.com> <871sqlzewc.fsf@intel.com> <20170615142430.GA13398@gmail.com> Date: Thu, 15 Jun 2017 18:10:34 +0300 Message-ID: <87vanxxp5h.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 15 Jun 2017, Dawid Kurek wrote: > On 15/06/17, Jani Nikula wrote: >> Separate declaration and initialization would lead to a cleaner patch >> and result. > > I saw combining declaration and initialization is quite common, i.e. in > drm_atomic file. Personally, I also prefer those in one statement. But yes, it > looks cleaner here, in two lines. I'd say the rule of thumb is that combined declaration and initialization is fine if the initialization is trivial, in particular can never fail. If you need to check the return value, like in this case, I'd prefer separate initialization. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center