From: Jani Nikula <jani.nikula@linux.intel.com>
To: Thomas Hellstrom <thellstrom@vmware.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: Static code analyzer annotations in driver code?
Date: Thu, 05 Jan 2017 13:38:22 +0200 [thread overview]
Message-ID: <87vattg2j5.fsf@intel.com> (raw)
In-Reply-To: <25019d75-83e0-e17e-97e1-0f02979dcc17@vmware.com>
On Wed, 04 Jan 2017, Thomas Hellstrom <thellstrom@vmware.com> wrote:
> What is the general opinion about out-of-tree static analyzer
> annotations in drm driver code, for example comments like
>
> /* coverity[missing_lock] */
>
> which typically squelches false positives in constructors or destructors
> of refcounted structs that contain members that are elsewhere protected
> by locks.
It's not about out-of-tree, it's about proprietary. We already have
annotations for sparse, though they're extra attributes rather than
comments. Anyone can run sparse, or other open source tools. Not so with
properietary tools. When you don't have the crowds maintaining the
annotations, they will bitrot, becoming just stale comments in source.
I know the intention is good, but I'm not convinced.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-01-05 11:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 13:06 Static code analyzer annotations in driver code? Thomas Hellstrom
2017-01-05 11:38 ` Jani Nikula [this message]
2017-01-05 11:57 ` Thomas Hellstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vattg2j5.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=thellstrom@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.