All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, ashijeetacharya@gmail.com,
	qemu-stable@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] migrate: Fix cpu-throttle-increment regression in HMP
Date: Wed, 05 Oct 2016 11:12:23 +0200	[thread overview]
Message-ID: <87vax7tb0o.fsf@emacs.mitica> (raw)
In-Reply-To: <1473390856-4502-2-git-send-email-eblake@redhat.com> (Eric Blake's message of "Thu, 8 Sep 2016 22:14:14 -0500")

Eric Blake <eblake@redhat.com> wrote:
> Commit 69ef1f3 accidentally broke migrate_set_parameter's ability
> to set the cpu-throttle-increment to anything other than the
> default, because it forgot to parse the user's string into an
> integer.
>
> CC: qemu-stable@nongnu.org
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>  hmp.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/hmp.c b/hmp.c
> index ad33b44..d6c6c01 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -1286,6 +1286,7 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict *qdict)
>                  break;
>              case MIGRATION_PARAMETER_CPU_THROTTLE_INCREMENT:
>                  has_cpu_throttle_increment = true;
> +                use_int_value = true;
>                  break;
>              case MIGRATION_PARAMETER_TLS_CREDS:
>                  has_tls_creds = true;

Reviewed-by: Juan Quintela <quintela@redhat.com>

  parent reply	other threads:[~2016-10-05  9:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-09  3:14 [Qemu-devel] [PATCH 0/3] migrate: simplify migrate-set-parameters Eric Blake
2016-09-09  3:14 ` [Qemu-devel] [PATCH 1/3] migrate: Fix cpu-throttle-increment regression in HMP Eric Blake
2016-09-09  8:06   ` Marc-André Lureau
2016-10-05  9:12   ` Juan Quintela [this message]
2016-09-09  3:14 ` [Qemu-devel] [PATCH 2/3] migrate: Share common MigrationParameters struct Eric Blake
2016-09-09  9:08   ` Marc-André Lureau
2016-10-05  9:23   ` Juan Quintela
2016-10-17 21:31   ` Eric Blake
2016-09-09  3:14 ` [Qemu-devel] [PATCH 3/3] migrate: Use boxed qapi for migrate-set-parameters Eric Blake
2016-09-09  9:08   ` Marc-André Lureau
2016-10-05  9:26   ` Juan Quintela
2016-10-05  9:37 ` [Qemu-devel] [PATCH 0/3] migrate: simplify migrate-set-parameters Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vax7tb0o.fsf@emacs.mitica \
    --to=quintela@redhat.com \
    --cc=ashijeetacharya@gmail.com \
    --cc=eblake@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.