From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm: include linux/seq_file.h as needed Date: Mon, 19 Sep 2016 16:27:41 +0300 Message-ID: <87vaxsm33m.fsf@intel.com> References: <20160919125218.1565529-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3109A6E0BC for ; Mon, 19 Sep 2016 13:27:46 +0000 (UTC) In-Reply-To: <20160919125218.1565529-1-arnd@arndb.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: David Airlie Cc: Arnd Bergmann , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Mika Kahola , Lyude List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCAxOSBTZXAgMjAxNiwgQXJuZCBCZXJnbWFubiA8YXJuZEBhcm5kYi5kZT4gd3JvdGU6 Cj4gVGhlIGFkZGl0aW9uIG9mIHRoZSBkZWJ1Z2ZzIGluZm8gY3JlYXRlZCByZWZlcmVuY2VzIHRv IHNlcV9wdXRzKCkgYW5kCj4gc2VxX3ByaW50ZigpLCBidXQgcmVsaWVkIG9uIHRoZSBkZWJ1Z2Zz IGhlYWRlciB0byBiZSBpbmNsdWRlZCBpbXBsaWNpdGx5LAo+IHdoaWNoIGFwcGFyZW50bHkgZG9l c24ndCBoYXBwZW4gYWxsIHRoZSB0aW1lLCBhcyBzZWVuIGZyb20gdGhpcyByYW5kY29uZmlnCj4g YnVpbGQgb3V0cHV0Ogo+Cj4gZHJpdmVycy9ncHUvZHJtL2RybV9kcF9oZWxwZXIuYzogSW4gZnVu Y3Rpb24gJ2RybV9kcF9kb3duc3RyZWFtX2RlYnVnJzoKPiBkcml2ZXJzL2dwdS9kcm0vZHJtX2Rw X2hlbHBlci5jOjU1MjoyOiBlcnJvcjogaW1wbGljaXQgZGVjbGFyYXRpb24gb2YgZnVuY3Rpb24g J3NlcV9wcmludGYnIFstV2Vycm9yPWltcGxpY2l0LWZ1bmN0aW9uLWRlY2xhcmF0aW9uXQo+IGRy aXZlcnMvZ3B1L2RybS9kcm1fZHBfaGVscGVyLmM6NTYwOjM6IGVycm9yOiBpbXBsaWNpdCBkZWNs YXJhdGlvbiBvZiBmdW5jdGlvbiAnc2VxX3B1dHMnIFstV2Vycm9yPWltcGxpY2l0LWZ1bmN0aW9u LWRlY2xhcmF0aW9uXQo+Cj4gQWRkaW5nIHRoZSBleHRyYSBpbmNsdWRlIGJyaW5ncyBiYWNrIGEg Y2xlYW4gYnVpbGQuCgpCZWF0IHlvdSB0byBpdCwgYnV0IG5vIHJldmlldy9hY2tzLi4uCgpodHRw Oi8vcGF0Y2h3b3JrLmZyZWVkZXNrdG9wLm9yZy9wYXRjaC9tc2dpZC8xNDc0MDIwMzk2LTE0ODc1 LTEtZ2l0LXNlbmQtZW1haWwtamFuaS5uaWt1bGFAaW50ZWwuY29tCgpCUiwKSmFuaS4KCgo+Cj4g Rml4ZXM6IDgwMjA5ZTVmMmM0MiAoImRybTogQWRkIERQIGJyYW5jaCBkZXZpY2UgaW5mbyBvbiBk ZWJ1Z2ZzIikKPiBTaWduZWQtb2ZmLWJ5OiBBcm5kIEJlcmdtYW5uIDxhcm5kQGFybmRiLmRlPgo+ IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2RwX2hlbHBlci5jIHwgMSArCj4gIDEgZmlsZSBj aGFuZ2VkLCAxIGluc2VydGlvbigrKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9k cm1fZHBfaGVscGVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2RwX2hlbHBlci5jCj4gaW5kZXgg YTA3YWRmMGEwN2RiLi4zZTZmZTgyYzZkNjQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2RybV9kcF9oZWxwZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZHBfaGVscGVyLmMK PiBAQCAtMjcsNiArMjcsNyBAQAo+ICAjaW5jbHVkZSA8bGludXgvZXJybm8uaD4KPiAgI2luY2x1 ZGUgPGxpbnV4L3NjaGVkLmg+Cj4gICNpbmNsdWRlIDxsaW51eC9pMmMuaD4KPiArI2luY2x1ZGUg PGxpbnV4L3NlcV9maWxlLmg+Cj4gICNpbmNsdWRlIDxkcm0vZHJtX2RwX2hlbHBlci5oPgo+ICAj aW5jbHVkZSA8ZHJtL2RybVAuaD4KCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2Ug VGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938617AbcISN2N (ORCPT ); Mon, 19 Sep 2016 09:28:13 -0400 Received: from mga09.intel.com ([134.134.136.24]:29584 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755810AbcISN2E (ORCPT ); Mon, 19 Sep 2016 09:28:04 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,361,1470726000"; d="scan'208";a="1058925961" From: Jani Nikula To: Arnd Bergmann , David Airlie Cc: Arnd Bergmann , Daniel Vetter , Dave Airlie , Mika Kahola , Ville =?utf-8?B?U3lyasOkbMOk?= , Lyude , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: include linux/seq_file.h as needed In-Reply-To: <20160919125218.1565529-1-arnd@arndb.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20160919125218.1565529-1-arnd@arndb.de> User-Agent: Notmuch/0.22.1+63~g648dcc7 (https://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Mon, 19 Sep 2016 16:27:41 +0300 Message-ID: <87vaxsm33m.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 19 Sep 2016, Arnd Bergmann wrote: > The addition of the debugfs info created references to seq_puts() and > seq_printf(), but relied on the debugfs header to be included implicitly, > which apparently doesn't happen all the time, as seen from this randconfig > build output: > > drivers/gpu/drm/drm_dp_helper.c: In function 'drm_dp_downstream_debug': > drivers/gpu/drm/drm_dp_helper.c:552:2: error: implicit declaration of function 'seq_printf' [-Werror=implicit-function-declaration] > drivers/gpu/drm/drm_dp_helper.c:560:3: error: implicit declaration of function 'seq_puts' [-Werror=implicit-function-declaration] > > Adding the extra include brings back a clean build. Beat you to it, but no review/acks... http://patchwork.freedesktop.org/patch/msgid/1474020396-14875-1-git-send-email-jani.nikula@intel.com BR, Jani. > > Fixes: 80209e5f2c42 ("drm: Add DP branch device info on debugfs") > Signed-off-by: Arnd Bergmann > --- > drivers/gpu/drm/drm_dp_helper.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c > index a07adf0a07db..3e6fe82c6d64 100644 > --- a/drivers/gpu/drm/drm_dp_helper.c > +++ b/drivers/gpu/drm/drm_dp_helper.c > @@ -27,6 +27,7 @@ > #include > #include > #include > +#include > #include > #include -- Jani Nikula, Intel Open Source Technology Center