From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36603) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bIEwS-0006kn-RA for qemu-devel@nongnu.org; Wed, 29 Jun 2016 08:50:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bIEwO-0001gg-Ld for qemu-devel@nongnu.org; Wed, 29 Jun 2016 08:50:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49646) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bIEwO-0001ga-Fm for qemu-devel@nongnu.org; Wed, 29 Jun 2016 08:50:04 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5FF193B3F9 for ; Wed, 29 Jun 2016 12:50:02 +0000 (UTC) From: Markus Armbruster References: <1467102269-11112-1-git-send-email-imammedo@redhat.com> Date: Wed, 29 Jun 2016 14:49:59 +0200 In-Reply-To: <1467102269-11112-1-git-send-email-imammedo@redhat.com> (Igor Mammedov's message of "Tue, 28 Jun 2016 10:24:29 +0200") Message-ID: <87vb0sw45k.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] virtio: abort on fatal error instead of just exiting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, mst@redhat.com Igor Mammedov writes: > replace mainly useless exit(1) on fatal error path with > abort(), so that it would be possible to generate core > dump, that could be used to analyse cause of problem. > > Signed-off-by: Igor Mammedov > --- > hw/virtio/virtio.c | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c > index 7ed06ea..9d3ac72 100644 > --- a/hw/virtio/virtio.c > +++ b/hw/virtio/virtio.c > @@ -315,7 +315,7 @@ static int virtqueue_num_heads(VirtQueue *vq, unsigned int idx) > if (num_heads > vq->vring.num) { > error_report("Guest moved used index from %u to %u", > idx, vq->shadow_avail_idx); > - exit(1); > + abort(); What's wrong with a simple assert(num_heads <= vq->vring.num)? > } > /* On success, callers read a descriptor at vq->last_avail_idx. > * Make sure descriptor read does not bypass avail index read. */ [...]