Re: [balbi-usb:testing/next 64/67] otg.c:undefined reference to `usb_gadget_vbus_disconnect'

[Felipe Balbi <felipe.balbi-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2586 bytes --]


Hi,

Peter Chen <hzpeterchen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> writes:
> On Wed, Jun 08, 2016 at 12:59:51PM +0300, Felipe Balbi wrote:
>> 
>> Hi,
>> 
>> kbuild test robot <fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> writes:
>> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next
>> > head:   fc4d1f3f522648d92d0c046beedbc1469979499a
>> > commit: 74e51eb7b5b4f7ab33c099c20def3dce0c699006 [64/67] usb: gadget: move gadget API functions to udc-core
>> > config: i386-randconfig-h1-06081244 (attached as .config)
>> > compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
>> > reproduce:
>> >         git checkout 74e51eb7b5b4f7ab33c099c20def3dce0c699006
>> >         # save the attached .config to linux build tree
>> >         make ARCH=i386 
>> >
>> > All errors (new ones prefixed by >>):
>> >
>> >    drivers/built-in.o: In function `nop_set_peripheral':
>> >    phy-generic.c:(.text+0x59f7a6): undefined reference to `usb_gadget_vbus_connect'
>> >    drivers/built-in.o: In function `nop_gpio_vbus_thread':
>> >    phy-generic.c:(.text+0x59f8a1): undefined reference to `usb_gadget_vbus_connect'
>> >    phy-generic.c:(.text+0x59f925): undefined reference to `usb_gadget_vbus_disconnect'
>> >    drivers/built-in.o: In function `gpio_vbus_set_peripheral':
>> >    phy-gpio-vbus-usb.c:(.text+0x59ff45): undefined reference to `usb_gadget_vbus_disconnect'
>> >    drivers/built-in.o: In function `gpio_vbus_work':
>> >    phy-gpio-vbus-usb.c:(.text+0x5a02dd): undefined reference to `usb_gadget_vbus_disconnect'
>> >    phy-gpio-vbus-usb.c:(.text+0x5a0333): undefined reference to `usb_gadget_vbus_connect'
>> >    drivers/built-in.o: In function `ci_handle_vbus_change.part.6':
>> >>> otg.c:(.text+0x605e3b): undefined reference to `usb_gadget_vbus_disconnect'
>> >>> otg.c:(.text+0x605e49): undefined reference to `usb_gadget_vbus_connect'
>> >    drivers/built-in.o: In function `isp1704_charger_work':
>> >    isp1704_charger.c:(.text+0x648335): undefined reference to `usb_gadget_disconnect'
>> >    isp1704_charger.c:(.text+0x64839d): undefined reference to `usb_gadget_connect'
>> >    drivers/built-in.o: In function `isp1704_charger_probe':
>> >    isp1704_charger.c:(.text+0x648760): undefined reference to `usb_gadget_disconnect'
>> 
>> thanks, fixed:
>> 
>
> Hi Felipe,
>
> Your patch does not fix above issue, I have tried. At least, I can
> reproduce phy-gpio-vbus-usb build error if it is build in, and
> USB_GADGET is module.

alright, I'll look at this today.

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]