From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47681) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8nug-000078-S7 for qemu-devel@nongnu.org; Fri, 03 Jun 2016 08:09:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b8nuc-00027J-E3 for qemu-devel@nongnu.org; Fri, 03 Jun 2016 08:09:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34438) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8nuc-00027F-8O for qemu-devel@nongnu.org; Fri, 03 Jun 2016 08:09:14 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E9C5B28A49 for ; Fri, 3 Jun 2016 12:09:13 +0000 (UTC) From: Markus Armbruster References: <1463632874-28559-1-git-send-email-eblake@redhat.com> Date: Fri, 03 Jun 2016 14:09:11 +0200 In-Reply-To: <1463632874-28559-1-git-send-email-eblake@redhat.com> (Eric Blake's message of "Wed, 18 May 2016 22:40:46 -0600") Message-ID: <87vb1qxymw.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v4 00/28] Add qapi-to-JSON and clone visitors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org Most patches are ready as is or with minor touch-ups. I'd probably drop PATCH 01. The file name collision no longer exists, and moving files just to improve their names a bit doesn't seem worth the bother. There are memory leaks in PATCH 12 and 24 (see review of PATCH 24). PATCH 13 needs more work than I'm comfortable to do on commit. Mostly missing comment updates, but also a crash bug. On PATCH 21, I have minor interface design doubts. The only difficult question is what to do about invalid UTF-8 strings and non-finite numbers. Patches before PATCH 29 show opinions, but a decision isn't made until PATCH 29. Good, because it leaves most of this series not blocked by the debate on what we should do. I guess I could take PATCH 02-12 now, and let you respin the rest. But perhaps its easier if you respin all of them.